The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Andi Kleen <ak@muc.de>
To: Andrew Morton <akpm@osdl.org>
Cc: Andi Kleen <ak@suse.de>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [2/3] Create call_usermodehelper_pipe()
Date: Wed, 16 Aug 2006 09:22:18 +0200	[thread overview]
Message-ID: <20060816092218.4ee23eb8.ak@muc.de> (raw)
In-Reply-To: <20060815191319.e535f5c6.akpm@osdl.org>

 current->files=&init_files.
> 
> hm, that's wrong, isn't it - we're not using CLONE_FILES...

Yes, I thought I got that right but you shocked me quickly :)

> 
> So what we have is a copy of init_files.  So the sys_close(0) shouldn't be needed?

Probably not. It was just paranoia I guess.

-Andi

  reply	other threads:[~2006-08-16  7:22 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20060814 127.183332000@suse.de>
2006-08-14 11:27 ` [PATCH] [1/3] Some cleanup in the pipe code Andi Kleen
2006-08-14 11:27 ` [PATCH] [2/3] Create call_usermodehelper_pipe() Andi Kleen
2006-08-15 21:22   ` Andrew Morton
2006-08-16  2:13     ` Andrew Morton
2006-08-16  7:22       ` Andi Kleen [this message]
2006-08-14 11:27 ` [PATCH] [3/3] Support piping into commands in /proc/sys/kernel/core_pattern Andi Kleen
2006-08-15  0:43   ` Andrew Morton
2006-08-15  6:04     ` Andi Kleen
2006-08-16  8:43   ` Greg KH
2006-08-16  9:18     ` Andi Kleen
2006-08-16 18:10       ` Andrew Morton
2006-08-17  9:46         ` Andi Kleen
2006-08-17 11:27           ` Alan Cox
2006-08-18  5:30             ` Andrew Morton
2006-08-18  8:29               ` Andi Kleen
2006-08-18 12:01                 ` Arjan van de Ven
2006-08-18 12:10                   ` Arjan van de Ven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060816092218.4ee23eb8.ak@muc.de \
    --to=ak@muc.de \
    --cc=ak@suse.de \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox