public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@osdl.org>
To: Dirk <noisyb@gmx.net>
Cc: linux-kernel@vger.kernel.org
Subject: Re: PATCH/FIX for drivers/cdrom/cdrom.c
Date: Wed, 16 Aug 2006 15:25:09 -0700	[thread overview]
Message-ID: <20060816152509.166ce663.akpm@osdl.org> (raw)
In-Reply-To: <44E3552A.6010705@gmx.net>

On Wed, 16 Aug 2006 19:26:02 +0200
Dirk <noisyb@gmx.net> wrote:

> I have changed a message that didn't clearly tell the user what was goin
> on...
> 
> Please have a look!
> 
> Thank you,
> Dirk
> 
>
> --- drivers/cdrom/cdrom.c.old	2006-08-16 19:04:11.000000000 +0200
> +++ drivers/cdrom/cdrom.c	2006-08-16 19:04:51.000000000 +0200
> @@ -2455,7 +2455,7 @@
>  		if (tracks.data > 0) return CDS_DATA_1;
>  		/* Policy mode off */
>  
> -		cdinfo(CD_WARNING,"This disc doesn't have any tracks I recognize!\n");
> +		cdinfo(CD_WARNING,"I'm a stupid fuck that will repeat this interesting message while endlessly trying to access the media you just inserted until your CD/DVD burning task is eventually fucked\n");
>  		return CDS_NO_INFO;
>  		}

Please keep the code formatted to fit in an 80-column xterm.  See
Documentation/CodingStyle.  Thanks.

(And you forget the Signed-off-by: line)

  parent reply	other threads:[~2006-08-16 22:25 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-08-16 17:26 PATCH/FIX for drivers/cdrom/cdrom.c Dirk
2006-08-16 17:40 ` Jan Engelhardt
2006-08-16 18:37   ` Dirk
2006-08-16 18:37 ` Lennart Sorensen
2006-08-16 18:44   ` Arjan van de Ven
2006-08-16 19:30   ` Dirk
2006-08-16 19:08 ` Alan Cox
2006-08-16 22:25 ` Andrew Morton [this message]
2006-08-17  7:50   ` Jan Engelhardt
2006-08-17 11:57   ` YMMD (Was: Re: PATCH/FIX for drivers/cdrom/cdrom.c) Christian Trefzer
     [not found] <6Kxns-7AV-13@gated-at.bofh.it>
     [not found] ` <6Kytd-1g2-31@gated-at.bofh.it>
     [not found]   ` <6KyCQ-1w7-25@gated-at.bofh.it>
2006-08-17 12:27     ` PATCH/FIX for drivers/cdrom/cdrom.c Bodo Eggert
2006-08-17 12:35       ` Arjan van de Ven
2006-08-18 12:31         ` Bodo Eggert
2006-08-18 12:53           ` Arjan van de Ven
2006-08-18 16:45           ` Alan Cox
2006-08-17 13:39       ` Alan Cox
2006-08-17 13:23         ` Lennart Sorensen
2006-08-17 13:41           ` Jeff Garzik
2006-08-17 13:54             ` Lennart Sorensen
2006-08-17 14:38               ` Helge Hafting
2006-08-18 12:39                 ` Bodo Eggert
2006-08-17 13:48           ` Alan Cox
2006-08-17 14:36             ` Lennart Sorensen
2006-08-17 14:38               ` Arjan van de Ven
2006-08-17 15:09               ` Alan Cox
2006-08-19 17:52               ` Oleg Verych
2006-08-21 17:31                 ` Lennart Sorensen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060816152509.166ce663.akpm@osdl.org \
    --to=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=noisyb@gmx.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox