Re: New version of ClownToolKit

[Sam Ravnborg <sam@ravnborg.org>]

On Thu, Aug 17, 2006 at 01:15:43AM +0200, Bodo Eggert wrote:
> Sam Ravnborg <sam@ravnborg.org> wrote:
> 
> > A small nitpick about the way ou build the ekrnel module:
> > 
> > In mk_and_insmod you can replace:
> > make -C /usr/src/linux SUBDIRS=$PWD modules
> > with
> > LIBDIR=/lib/modules/`uname -r`
> > make -C $LIBDIR/source O=$LIBDIR/build SUBDIRS=`pwd` modules
> > 
> > For a normal kernel installation this will do the right thing.
> > source points to the kernel source and build point to the output
> > directory (they are often equal but not always).
> 
> Please don't tell module authors to unconditionally use `uname -r`.
> I frequently build kernels for differentd hosts, and if I don't, I'll
> certainly compile the needed modules before installing the kernel.
> Therefore /lib/modules/`uname -r` is most certainly the completely
> wrong place to look for the kernel source.
/lib/modules/`uname -r` is the general solution that works for most
people and should be at least default. It is certainly better than
/usr/src/linux.
But yes they better make it override able.

	Sam