From: Russell King <rmk+lkml@arm.linux.org.uk>
To: Jean-Paul Saman <jean-paul.saman@philips.com>
Cc: linux-kernel@vger.kernel.org, linux-kernel-owner@vger.kernel.org,
Vitaly Wool <vitalywool@gmail.com>
Subject: Re: ip3106_uart oddity
Date: Fri, 18 Aug 2006 09:27:56 +0100 [thread overview]
Message-ID: <20060818082756.GB6901@flint.arm.linux.org.uk> (raw)
In-Reply-To: <OF21337E37.31820A4F-ONC12571CE.002682FD-C12571CE.002AB6EB@philips.com>
On Fri, Aug 18, 2006 at 09:46:01AM +0200, Jean-Paul Saman wrote:
> linux-kernel-owner@vger.kernel.org wrote on 17-08-2006 22:29:54:
> > On Thu, Aug 17, 2006 at 06:29:48PM +0400, Vitaly Wool wrote:
> > > I'd like to take the burden of restoring the UART functionality for
> > > PNX8550 boards in the mainline. This very UART HW is very weird and
> > > doesn't fit well into 8250 model, even with fixups like those that
> > > were introduced for Alchemy. It also differs from the IP_3106-based
> > > UARTs used on Philips ARM targets in registers layout so I'm not
> > > sure it's correct to call it ip3106_uart.
> > > So, given the above, does it make sense to try make it fir into
> > > standard 8250 driver model or restore/rework the custom driver?
> >
> > No real clue. Is it similar to any other drivers?
>
> The ip3106_uart.c file that was used in the PNX8550 boards is wrongly
> named. The uart just isn't an ip3106, because those are used in philips
> ARM based devices.
>
> If you restore the ip3106T_uart.c, then please rename it pnx8550_uart.c
> (or pnx8xxxx_uart.c).
There are no plans what so ever to "restore" what was never even there.
Searching around, there was a pnx0105 driver submitted but needed some
additional work which was never done.
The same situation seems to apply to this driver. Ralf submitted a
driver called ip3106_uart.c which claimed to be a rewrite of
pnx8550_uart.c. Comments were given at that time, no real feedback
came of that.
I would suggest you read the "Serial driver for the Philips PNX8550
SOC." thread, but it was a private one between Ralf, me and an
embeddedalley.com employee (who allegedly was the author of the driver
and who volunteered to do the work to fix the comments, but seemingly
never actually did anything.)
I suggest you ask embeddedalley.com...
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of: 2.6 Serial core
next prev parent reply other threads:[~2006-08-18 8:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-17 14:29 ip3106_uart oddity Vitaly Wool
2006-08-17 20:29 ` Russell King
2006-08-18 7:46 ` Jean-Paul Saman
2006-08-18 8:27 ` Russell King [this message]
2006-08-18 11:23 ` Vitaly Wool
2006-08-18 12:56 ` Russell King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060818082756.GB6901@flint.arm.linux.org.uk \
--to=rmk+lkml@arm.linux.org.uk \
--cc=jean-paul.saman@philips.com \
--cc=linux-kernel-owner@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vitalywool@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox