From: "Jörn Engel" <joern@wohnheim.fh-wedel.de>
To: Thomas Klein <osstklei@de.ibm.com>
Cc: Arjan van de Ven <arjan@infradead.org>,
Jan-Bernd Themann <ossthema@de.ibm.com>,
netdev <netdev@vger.kernel.org>,
Christoph Raisch <raisch@de.ibm.com>,
Jan-Bernd Themann <themann@de.ibm.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-ppc <linuxppc-dev@ozlabs.org>,
Marcus Eder <meder@de.ibm.com>, Thomas Klein <tklein@de.ibm.com>
Subject: Re: [2.6.19 PATCH 3/7] ehea: queue management
Date: Fri, 18 Aug 2006 16:33:28 +0200 [thread overview]
Message-ID: <20060818143328.GC6393@wohnheim.fh-wedel.de> (raw)
In-Reply-To: <44E5BFB7.4000400@de.ibm.com>
On Fri, 18 August 2006 15:25:11 +0200, Thomas Klein wrote:
> Arjan van de Ven wrote:
> >>+ queue->queue_length = nr_of_pages * pagesize;
> >>+ queue->queue_pages = vmalloc(nr_of_pages * sizeof(void *));
> >
> >
> >wow... is this really so large that it warrants a vmalloc()???
>
> Agreed: Replaced with kmalloc()
kzalloc() and you can remove the memset() as well.
Jörn
--
Data dominates. If you've chosen the right data structures and organized
things well, the algorithms will almost always be self-evident. Data
structures, not algorithms, are central to programming.
-- Rob Pike
next prev parent reply other threads:[~2006-08-18 14:33 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-18 11:31 [2.6.19 PATCH 3/7] ehea: queue management Jan-Bernd Themann
2006-08-18 12:17 ` Arjan van de Ven
2006-08-18 13:25 ` Thomas Klein
2006-08-18 13:47 ` Arnd Bergmann
2006-08-18 14:24 ` Christoph Raisch
2006-08-18 16:16 ` Arnd Bergmann
2006-08-18 14:33 ` Jörn Engel [this message]
2006-08-18 14:40 ` Jörn Engel
-- strict thread matches above, loose matches on Subject: below --
2006-08-22 12:53 Jan-Bernd Themann
[not found] ` <200608221601.24882.arnd.bergmann@de.ibm.com>
2006-08-22 13:51 ` Jan-Bernd Themann
2006-08-23 8:57 Jan-Bernd Themann
2006-09-04 10:39 Jan-Bernd Themann
2006-09-06 13:32 Jan-Bernd Themann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060818143328.GC6393@wohnheim.fh-wedel.de \
--to=joern@wohnheim.fh-wedel.de \
--cc=arjan@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=meder@de.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=ossthema@de.ibm.com \
--cc=osstklei@de.ibm.com \
--cc=raisch@de.ibm.com \
--cc=themann@de.ibm.com \
--cc=tklein@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox