public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Paul Jackson <pj@sgi.com>
To: "Siddha, Suresh B" <suresh.b.siddha@intel.com>
Cc: akpm@osdl.org, linux-kernel@vger.kernel.org,
	nickpiggin@yahoo.com.au, mingo@redhat.com, apw@shadowen.org
Subject: Re: [patch] sched: generic sched_group cpu power setup
Date: Fri, 18 Aug 2006 17:09:45 -0700	[thread overview]
Message-ID: <20060818170945.43ced12b.pj@sgi.com> (raw)
In-Reply-To: <20060818154230.A23214@unix-os.sc.intel.com>

> If any one has a better suggestion, I am open.

I'm still trying to figure out what the hell it is ;).

Sorry ... as my teenage son would gladly tell you, I can be dense
at times.

If all the CPUs in a system have the same computational capacity,
then is it just the number of CPUs in a group (times a scale factor
of 128, to simulate fixed point arithmetic with integers)?

I presume "yes", from such code lines as:

  power = SCHED_LOAD_SCALE * cpus_weight(sd->groups->cpumask);

If two CPUs, side by side, have the same computational capacity,
but one consumes more electrical power (watts) than the other, do they
have different cpu_power?

I presume "no" - electrical power consumption does not affect this value
(though some effort might be made to minimize electrical power consumption
in these calculations, by letting some CPUs go idle if the job mix allows
for that.)

If I presumed correctly, then apparently what we're talking about here
is computational capacity, as is typically measured in such units as
MIPS, megaflops/sec or Drystones. In other words, what Andrew termed
"computing power" when he fired the starter's pistol on this scrum.

Is that what this is -- computational capacity, aka computing power
(appropriately scaled for the convenience of the arithmetic)?

And is the unit of measure just the number of CPUs in the group
(times 128)?

If the above is accurate, then the group structure member could almost
be called "ncpus" (number of cpus in group), unscaled.  Perhaps you
only need to scale the value for fixed point arithmetic while calculating
what balancing to attempt.

One more  detail, as you likely already noticed, if you rename
"cpu_power" to not mention "power", then consider also the routine 
init_numa_sched_groups_power(), the variables pwr_now, pwr_move and
power, and the mentions of "power" in the comments.

-- 
                  I won't rest till it's the best ...
                  Programmer, Linux Scalability
                  Paul Jackson <pj@sgi.com> 1.925.600.0401

  reply	other threads:[~2006-08-19  0:10 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-08-16  0:55 [patch] sched: group CPU power setup cleanup Siddha, Suresh B
2006-08-16  4:24 ` Paul Jackson
2006-08-16  4:47   ` Andrew Morton
2006-08-16  5:53     ` Paul Jackson
2006-08-16 18:03     ` Siddha, Suresh B
2006-08-17 17:20       ` Paul Jackson
2006-08-17 18:03         ` Siddha, Suresh B
2006-08-17 19:18           ` Paul Jackson
2006-08-17 23:29             ` Ian Stirling
2006-08-17 23:35               ` Paul Jackson
2006-08-17 23:56         ` Peter Williams
2006-08-18  4:15         ` Paul Mackerras
2006-08-16 17:45   ` Siddha, Suresh B
2006-08-18 21:23     ` [patch] sched: generic sched_group cpu power setup Siddha, Suresh B
2006-08-18 22:29       ` Paul Jackson
2006-08-18 22:42         ` Siddha, Suresh B
2006-08-19  0:09           ` Paul Jackson [this message]
2006-08-21 22:19             ` Siddha, Suresh B

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060818170945.43ced12b.pj@sgi.com \
    --to=pj@sgi.com \
    --cc=akpm@osdl.org \
    --cc=apw@shadowen.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=nickpiggin@yahoo.com.au \
    --cc=suresh.b.siddha@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox