From: Arnd Bergmann <arnd@arndb.de>
To: linuxppc-dev@ozlabs.org
Cc: Linas Vepstas <linas@austin.ibm.com>,
Jeff Garzik <jgarzik@pobox.com>,
akpm@osdl.org, netdev@vger.kernel.org,
James K Lewis <jklewis@us.ibm.com>,
linux-kernel@vger.kernel.org,
ens Osterkamp <Jens.Osterkamp@de.ibm.com>
Subject: Re: [PATCH 4/6]: powerpc/cell spidernet ethtool -i version number info.
Date: Sat, 19 Aug 2006 00:56:34 +0200 [thread overview]
Message-ID: <200608190056.35775.arnd@arndb.de> (raw)
In-Reply-To: <20060818222500.GK26889@austin.ibm.com>
On Saturday 19 August 2006 00:25, Linas Vepstas wrote:
> This patch adds version information as reported by
> ethtool -i to the Spidernet driver.
Acked-by: Arnd Bergmann <arnd.bergmann@de.ibm.com>
except for
> @@ -2293,6 +2294,8 @@ static struct pci_driver spider_net_driv
> */
> static int __init spider_net_init(void)
> {
> + printk("spidernet Version %s.\n",VERSION);
> +
This printk is missing a level (KERN_INFO or similar). Moreover,
it is rather strange for a driver to print a message when no
device is actually used by it. I'd rather drop the version
printk completely, but I know that Jim has strong feelings about
what to do with version information. I suggest that if we decide
to keep something like that in the driver, it should be printed
in spider_net_probe().
Arnd <><
next prev parent reply other threads:[~2006-08-18 22:56 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-18 22:07 [PATCH 0/6]: powerpc/cell spidernet ethernet driver update Linas Vepstas
2006-08-18 22:20 ` [PATCH 1/6]: powerpc/cell spidernet burst alignment patch Linas Vepstas
2006-08-18 22:51 ` Arnd Bergmann
2006-08-18 22:21 ` [PATCH 2/6]: powerpc/cell spidernet low watermark patch Linas Vepstas
[not found] ` <200608190109.15129.arnd@arndb.de>
2006-08-20 6:31 ` Benjamin Herrenschmidt
2006-08-20 10:03 ` Arnd Bergmann
2006-08-23 21:36 ` Linas Vepstas
2006-08-23 22:03 ` David Miller
2006-08-18 22:23 ` [PATCH 3/6]: powerpc/cell spidernet stop error printing patch Linas Vepstas
2006-08-18 22:25 ` [PATCH 4/6]: powerpc/cell spidernet ethtool -i version number info Linas Vepstas
2006-08-18 22:56 ` Arnd Bergmann [this message]
2006-08-18 22:26 ` [PATCH 5/6]: powerpc/cell spidernet bottom half Linas Vepstas
2006-08-18 23:03 ` Arnd Bergmann
2006-08-19 0:56 ` [RFC] HOWTO use NAPI to reduce TX interrupts Arnd Bergmann
2006-08-20 1:31 ` Stephen Hemminger
2006-08-19 11:25 ` Arnd Bergmann
2006-08-20 17:48 ` [RFC v2] " Arnd Bergmann
2006-08-21 20:40 ` NAPI documentation Stephen Hemminger
2006-08-21 22:05 ` David Miller
2006-08-21 22:09 ` Stephen Hemminger
2006-08-21 22:17 ` David Miller
2006-08-21 23:52 ` [RFC] HOWTO use NAPI to reduce TX interrupts Linas Vepstas
2006-08-21 23:56 ` David Miller
2006-08-22 0:29 ` Roland Dreier
2006-08-22 0:32 ` David Miller
2006-08-23 21:52 ` [PATCH 5/6]: powerpc/cell spidernet bottom half Linas Vepstas
2006-08-18 22:29 ` [PATCH 6/6]: powerpc/cell spidernet refine locking Linas Vepstas
-- strict thread matches above, loose matches on Subject: below --
2006-09-29 23:05 [PATCH 0/6]: powerpc/cell spidernet ethernet patches Linas Vepstas
2006-09-29 23:21 ` [PATCH 4/6]: powerpc/cell spidernet ethtool -i version number info Linas Vepstas
2006-09-30 10:33 ` Arnd Bergmann
2006-10-02 17:14 ` Linas Vepstas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200608190056.35775.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=Jens.Osterkamp@de.ibm.com \
--cc=akpm@osdl.org \
--cc=jgarzik@pobox.com \
--cc=jklewis@us.ibm.com \
--cc=linas@austin.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox