Re: [PATCH 7/7] CPU controller V1 - (temporary) cpuset interface

Srivatsa Vaddagiri
2006-08-22T10:11:08Z

On Tue, Aug 22, 2006 at 11:10:36AM +0000, Mike Galbraith wrote:
> Doesn't seem to work here, but maybe I'm doing something wrong.
>
> I set up cpuset "all" containing cpu 0-1 (all, 1.something cpus I have;)

You are assigning all the CPUs to the cpuset "all" and then making it an
exclusive/metered cpuset?

I dont think I am handling that case well (yet), primarily because usage of
remaining tasks (which are not in cpuset "all", "mikeg" & "root") is not
accounted/controlled. Note that those remaining tasks will be running on one of
the CPUs assigned to "all". What needs to happen is those remaining tasks need
to be moved to a separate group (and a runqueue), being given some left-over
CPU quota (which is left over from assignment of quota to mikeg and root),
which is not handled in the patches (yet). One of the reason why I havent
handled it yet is that there is no easy way to retrieve list of tasks attached
to a cpuset.

Can you try assigning (NUM_CPUS-1) cpus to "all" and give it a shot?
Essentially you need to ensure that only tasks chosen by you are running in
cpus given to "all" and other child-cpusets under it.

--
Regards,
vatsa