Re: [PATCH] copy_process: cosmetic ->ioprio tweak

Andrew Morton
2006-08-21T21:32:33Z

On Sun, 20 Aug 2006 18:53:21 +0400
Oleg Nesterov <oleg@tv-sign.ru> wrote:

> copy_process:
> // holds tasklist_lock + ->siglock
> /*
> * inherit ioprio
> */
> p->ioprio = current->ioprio;
>
> Why? ->ioprio was already copied in dup_task_struct().

It might just be a thinko.

> I guess this is needed
> to ensure that the child can't escape sys_ioprio_set(IOPRIO_WHO_{PGRP,USER}),
> yes?

How could the child escape that if this assignment was not present?

> In that case we don't need ->siglock held, and the comment should be updated.

Surely.