From: Solar Designer <solar@openwall.com>
To: Ulrich Drepper <drepper@redhat.com>
Cc: Arjan van de Ven <arjan@infradead.org>,
Alex Riesen <fork0@users.sourceforge.net>,
Willy Tarreau <wtarreau@hera.kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] set*uid() must not fail-and-return on OOM/rlimits
Date: Sun, 20 Aug 2006 20:48:41 +0400 [thread overview]
Message-ID: <20060820164841.GA20433@openwall.com> (raw)
In-Reply-To: <44E88DC3.7000708@redhat.com>
> Arjan van de Ven wrote:
> > sounds like a good argument to get the setuid functions marked
> > __must_check in glibc...
I agree.
On Sun, Aug 20, 2006 at 09:28:51AM -0700, Ulrich Drepper wrote:
> There are too many false positives. E.g., in a SUID binaries switching
> back from a non-root UID to root will not fail. Very common.
I wouldn't call those false positives. They're warnings of poorly
written code that might fail with further changes to the kernel or with
custom security modules, or on another Unix-like platform.
Of course, the kernel or security modules must not change the semantics
arbitrarily yet expect old apps to work, however expecting that apps
honor return value from set*[ug]id() would be reasonable. (The only
reason why it is not is that there are so many broken apps out there and
more are being developed.)
Alexander
next prev parent reply other threads:[~2006-08-20 16:52 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-20 0:38 [PATCH] set*uid() must not fail-and-return on OOM/rlimits Solar Designer
2006-08-20 7:52 ` Kari Hurtta
2006-08-20 18:10 ` Alan Cox
2006-08-21 5:05 ` Kari Hurtta
2006-08-20 8:26 ` Willy Tarreau
2006-08-20 15:25 ` Solar Designer
2006-08-20 10:07 ` Alex Riesen
2006-08-20 15:30 ` Solar Designer
2006-08-20 15:53 ` Arjan van de Ven
2006-08-20 16:17 ` Willy Tarreau
2006-08-20 16:28 ` Ulrich Drepper
2006-08-20 16:45 ` Arjan van de Ven
2006-08-20 16:47 ` Michael Buesch
2006-08-20 16:48 ` Solar Designer [this message]
2006-08-20 18:03 ` Alan Cox
2006-08-20 18:10 ` Willy Tarreau
2006-08-20 18:36 ` Alan Cox
2006-08-20 18:21 ` Willy Tarreau
2006-08-20 18:52 ` Alan Cox
2006-08-20 19:01 ` Willy Tarreau
2006-08-20 19:33 ` Alan Cox
2006-08-20 19:17 ` Willy Tarreau
2006-08-20 16:04 ` Florian Weimer
2006-08-20 16:25 ` Solar Designer
2006-08-20 18:14 ` Alan Cox
2006-08-20 22:12 ` Solar Designer
2006-08-20 22:51 ` Alan Cox
2006-08-20 22:58 ` Solar Designer
2006-08-20 23:00 ` Alan Cox
2006-08-21 0:23 ` Peter Williams
2006-08-21 0:45 ` Solar Designer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060820164841.GA20433@openwall.com \
--to=solar@openwall.com \
--cc=arjan@infradead.org \
--cc=drepper@redhat.com \
--cc=fork0@users.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=wtarreau@hera.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox