* [PATCH] cfq_cic_link: fix? usage of wrong cfq_io_context
@ 2006-08-20 21:09 Oleg Nesterov
2006-08-21 0:34 ` OGAWA Hirofumi
2006-08-21 6:29 ` Jens Axboe
0 siblings, 2 replies; 3+ messages in thread
From: Oleg Nesterov @ 2006-08-20 21:09 UTC (permalink / raw)
To: Jens Axboe; +Cc: Andrew Morton, linux-kernel
Obviously, cfq_cic_link() shouldn't free a just allocated cfq_io_context ?
Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru>
--- 2.6.18-rc4/block/cfq-iosched.c~7_set 2006-08-20 21:23:25.000000000 +0400
+++ 2.6.18-rc4/block/cfq-iosched.c 2006-08-21 00:53:27.000000000 +0400
@@ -1561,7 +1561,7 @@ restart:
/* ->key must be copied to avoid race with cfq_exit_queue() */
k = __cic->key;
if (unlikely(!k)) {
- cfq_drop_dead_cic(ioc, cic);
+ cfq_drop_dead_cic(ioc, __cic);
goto restart;
}
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] cfq_cic_link: fix? usage of wrong cfq_io_context
2006-08-20 21:09 [PATCH] cfq_cic_link: fix? usage of wrong cfq_io_context Oleg Nesterov
@ 2006-08-21 0:34 ` OGAWA Hirofumi
2006-08-21 6:29 ` Jens Axboe
1 sibling, 0 replies; 3+ messages in thread
From: OGAWA Hirofumi @ 2006-08-21 0:34 UTC (permalink / raw)
To: Oleg Nesterov; +Cc: Jens Axboe, Andrew Morton, linux-kernel
Oleg Nesterov <oleg@tv-sign.ru> writes:
> if (unlikely(!k)) {
> - cfq_drop_dead_cic(ioc, cic);
> + cfq_drop_dead_cic(ioc, __cic);
> goto restart;
> }
Ugh, I think you are right, and it's my fault. Sorry.
--
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] cfq_cic_link: fix? usage of wrong cfq_io_context
2006-08-20 21:09 [PATCH] cfq_cic_link: fix? usage of wrong cfq_io_context Oleg Nesterov
2006-08-21 0:34 ` OGAWA Hirofumi
@ 2006-08-21 6:29 ` Jens Axboe
1 sibling, 0 replies; 3+ messages in thread
From: Jens Axboe @ 2006-08-21 6:29 UTC (permalink / raw)
To: Oleg Nesterov; +Cc: Andrew Morton, linux-kernel
On Mon, Aug 21 2006, Oleg Nesterov wrote:
> Obviously, cfq_cic_link() shouldn't free a just allocated cfq_io_context ?
>
> Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru>
>
> --- 2.6.18-rc4/block/cfq-iosched.c~7_set 2006-08-20 21:23:25.000000000 +0400
> +++ 2.6.18-rc4/block/cfq-iosched.c 2006-08-21 00:53:27.000000000 +0400
> @@ -1561,7 +1561,7 @@ restart:
> /* ->key must be copied to avoid race with cfq_exit_queue() */
> k = __cic->key;
> if (unlikely(!k)) {
> - cfq_drop_dead_cic(ioc, cic);
> + cfq_drop_dead_cic(ioc, __cic);
> goto restart;
> }
Yep, that's a typo. Applied.
--
Jens Axboe
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2006-08-21 6:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-08-20 21:09 [PATCH] cfq_cic_link: fix? usage of wrong cfq_io_context Oleg Nesterov
2006-08-21 0:34 ` OGAWA Hirofumi
2006-08-21 6:29 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox