Re: [PATCH] introduce CONFIG_BINFMT_ELF_AOUT

Willy Tarreau
2006-08-21T04:51:57Z

On Mon, Aug 21, 2006 at 05:07:00AM +0400, Solar Designer wrote:
> Willy,
>
> On Sun, Aug 20, 2006 at 02:16:37AM +0200, Willy Tarreau wrote:
> > Most people compiling 2.4 for
> > servers right now most probably do not enable support for a.out already.
>
> I'm afraid that most don't change the default, not being aware that this
> is an unreasonable security risk.
>
> > - you split the defconfig changes from the rest and let them in a
> > state compatible with 2.4.33 features, which even implies setting
> > CONFIG_BINFMT_ELF_AOUT to 'y', even if this sounds gross to you.
> > - I merge the changes to support the new option
>
> I can do that, but:
>
> - it almost defeats the purpose of the patch since most people won't
> know to change the defaults;
> - Marcelo is of the opinion that it's "not 2.4 material at this point in
> time".
>
> Given the above, do you still want me to resubmit a reworked patch like
> that?

Well, do not bother then.

> > - you just have to maintain the patch for the defconfig files in owl.
>
> I submit these patches in hope that they will be useful for mainstream
> kernels, not in an attempt to simplify maintenance of -ow patches.

I'm perfectly aware of this. You proposed me some of your patches which
have proved useful in your tree, I agreed to review them but other people
are more reluctant than me because those patches are prevention measures
and don't fix anything. Well, end of the story. Keep them in -ow, and I
will also push some of them in my own tree because I understand why they
can help. That's just a matter of opinion.

> Thanks,
>
> Alexander

Thanks,
Willy