* [PATCH] x86-64 add missing PMU MSR definitions
@ 2006-08-20 21:48 Stephane Eranian
2006-08-20 23:13 ` Andi Kleen
0 siblings, 1 reply; 3+ messages in thread
From: Stephane Eranian @ 2006-08-20 21:48 UTC (permalink / raw)
To: linux-kernel; +Cc: Stephane Eranian, ak
[-- Attachment #1: Type: text/plain, Size: 312 bytes --]
Hello,
Here is a patch to add a couple of missing MSR definitions related
to Performance monitoring for EM64T. A separate patch contains the
i386 equivalent.
Changelog:
- add MSR definitions for IA32_PEBS_ENABLE and PEBS_MATRIX_VERT
signed-off-by: stephane eranian <eranian@hpl.hp.com>
--
-Stephane
[-- Attachment #2: msr-x86_64.diff --]
[-- Type: text/plain, Size: 380 bytes --]
--- linux-2.6.17.8.orig/include/asm-x86_64/msr.h 2006-08-06 21:18:54.000000000 -0700
+++ linux-2.6.17.8/include/asm-x86_64/msr.h 2006-08-20 14:40:52.000000000 -0700
@@ -396,4 +396,7 @@ static inline unsigned int cpuid_edx(uns
#define MSR_P4_U2L_ESCR0 0x3b0
#define MSR_P4_U2L_ESCR1 0x3b1
+#define MSR_IA32_PEBS_ENABLE 0x3f1
+#define MSR_PEBS_MATRIX_VERT 0x3f2
+
#endif
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] x86-64 add missing PMU MSR definitions
2006-08-20 21:48 [PATCH] x86-64 add missing PMU MSR definitions Stephane Eranian
@ 2006-08-20 23:13 ` Andi Kleen
2006-08-22 10:34 ` Stephane Eranian
0 siblings, 1 reply; 3+ messages in thread
From: Andi Kleen @ 2006-08-20 23:13 UTC (permalink / raw)
To: eranian; +Cc: linux-kernel
On Sunday 20 August 2006 23:48, Stephane Eranian wrote:
> Hello,
>
> Here is a patch to add a couple of missing MSR definitions related
> to Performance monitoring for EM64T. A separate patch contains the
> i386 equivalent.
>
> Changelog:
> - add MSR definitions for IA32_PEBS_ENABLE and PEBS_MATRIX_VERT
The names seem somewhat mixed up.
I think I would prefer P4 and no IA32 prefixes for all of them.
(or does Core2 still have PEBS?)
-Andi
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] x86-64 add missing PMU MSR definitions
2006-08-20 23:13 ` Andi Kleen
@ 2006-08-22 10:34 ` Stephane Eranian
0 siblings, 0 replies; 3+ messages in thread
From: Stephane Eranian @ 2006-08-22 10:34 UTC (permalink / raw)
To: Andi Kleen; +Cc: linux-kernel
Andi,
On Mon, Aug 21, 2006 at 01:13:44AM +0200, Andi Kleen wrote:
> On Sunday 20 August 2006 23:48, Stephane Eranian wrote:
> > Hello,
> >
> > Here is a patch to add a couple of missing MSR definitions related
> > to Performance monitoring for EM64T. A separate patch contains the
> > i386 equivalent.
> >
> > Changelog:
> > - add MSR definitions for IA32_PEBS_ENABLE and PEBS_MATRIX_VERT
>
>
> The names seem somewhat mixed up.
>
> I think I would prefer P4 and no IA32 prefixes for all of them.
> (or does Core2 still have PEBS?)
OK, let's wait until Intel *finally* releases the Core 2 PMU specification
publicly and then I'll push a patch. Those MSRs are not that critical anyway.
Perfmon2 is probably the only consumer.
--
-Stephane
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2006-08-22 10:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-08-20 21:48 [PATCH] x86-64 add missing PMU MSR definitions Stephane Eranian
2006-08-20 23:13 ` Andi Kleen
2006-08-22 10:34 ` Stephane Eranian
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox