From: Jens Axboe <axboe@suse.de>
To: Oleg Nesterov <oleg@tv-sign.ru>
Cc: Andrew Morton <akpm@osdl.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sys_ioprio_set: minor do_each_thread+break fix
Date: Mon, 21 Aug 2006 08:28:30 +0200 [thread overview]
Message-ID: <20060821062829.GG4290@suse.de> (raw)
In-Reply-To: <20060820150929.GA1577@oleg>
On Sun, Aug 20 2006, Oleg Nesterov wrote:
> From include/linux/sched.h:
> /*
> * Careful: do_each_thread/while_each_thread is a double loop so
> * 'break' will not work as expected - use goto instead.
> */
>
> Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru>
>
> --- 2.6.18-rc4/fs/ioprio.c~2_break 2006-07-16 01:53:08.000000000 +0400
> +++ 2.6.18-rc4/fs/ioprio.c 2006-08-20 18:57:38.000000000 +0400
> @@ -111,9 +111,9 @@ asmlinkage long sys_ioprio_set(int which
> continue;
> ret = set_task_ioprio(p, ioprio);
> if (ret)
> - break;
> + goto free_uid;
> } while_each_thread(g, p);
> -
> +free_uid:
> if (who)
> free_uid(user);
> break;
Good catch, applied!
--
Jens Axboe
prev parent reply other threads:[~2006-08-21 6:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-20 15:09 [PATCH] sys_ioprio_set: minor do_each_thread+break fix Oleg Nesterov
2006-08-21 6:28 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060821062829.GG4290@suse.de \
--to=axboe@suse.de \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg@tv-sign.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox