From: Jens Axboe <axboe@suse.de>
To: Oleg Nesterov <oleg@tv-sign.ru>
Cc: Andrew Morton <akpm@osdl.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] cfq_cic_link: fix? usage of wrong cfq_io_context
Date: Mon, 21 Aug 2006 08:29:30 +0200 [thread overview]
Message-ID: <20060821062930.GJ4290@suse.de> (raw)
In-Reply-To: <20060820210903.GA6123@oleg>
On Mon, Aug 21 2006, Oleg Nesterov wrote:
> Obviously, cfq_cic_link() shouldn't free a just allocated cfq_io_context ?
>
> Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru>
>
> --- 2.6.18-rc4/block/cfq-iosched.c~7_set 2006-08-20 21:23:25.000000000 +0400
> +++ 2.6.18-rc4/block/cfq-iosched.c 2006-08-21 00:53:27.000000000 +0400
> @@ -1561,7 +1561,7 @@ restart:
> /* ->key must be copied to avoid race with cfq_exit_queue() */
> k = __cic->key;
> if (unlikely(!k)) {
> - cfq_drop_dead_cic(ioc, cic);
> + cfq_drop_dead_cic(ioc, __cic);
> goto restart;
> }
Yep, that's a typo. Applied.
--
Jens Axboe
prev parent reply other threads:[~2006-08-21 6:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-20 21:09 [PATCH] cfq_cic_link: fix? usage of wrong cfq_io_context Oleg Nesterov
2006-08-21 0:34 ` OGAWA Hirofumi
2006-08-21 6:29 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060821062930.GJ4290@suse.de \
--to=axboe@suse.de \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg@tv-sign.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox