From: Bill Huey (hui) <billh@gnuppy.monkey.org>
To: Oleg Nesterov <oleg@tv-sign.ru>
Cc: Andrew Morton <akpm@osdl.org>, Ingo Molnar <mingo@elte.hu>,
Thomas Gleixner <tglx@linutronix.de>,
Steven Rostedt <rostedt@goodmis.org>,
linux-kernel@vger.kernel.org,
"Bill Huey (hui)" <billh@gnuppy.monkey.org>
Subject: Re: [PATCH 1/3] futex_find_get_task: remove an obscure EXIT_ZOMBIE check
Date: Mon, 21 Aug 2006 17:01:10 -0700 [thread overview]
Message-ID: <20060822000110.GA31751@gnuppy.monkey.org> (raw)
In-Reply-To: <20060821170604.GA1640@oleg>
On Mon, Aug 21, 2006 at 09:06:04PM +0400, Oleg Nesterov wrote:
> (Compile tested).
>
> futex_find_get_task:
>
> if (p->state == EXIT_ZOMBIE || p->exit_state == EXIT_ZOMBIE)
> return NULL;
>
> I can't understand this. First, p->state can't be EXIT_ZOMBIE. The ->exit_state
> check looks strange too. Sub-threads or tasks whose ->parent ignores SIGCHLD go
> directly to EXIT_DEAD state (I am ignoring a ptrace case). Why EXIT_DEAD tasks
> should be ok? Yes, EXIT_ZOMBIE is more important (a task may stay zombie for a
> long time), but this doesn't mean we should explicitely ignore other EXIT_XXX
> states.
The p->state variable for EXIT_ZOMBIE is only live for some mystery architecture
in arch/xtensa/kernel/ptrace.c
It could be a typo under architecture so maybe it's better fixed there as well
with a "state" to "exit_state" change. I don't really know for sure since I don't
work under that architecure.
bill
next prev parent reply other threads:[~2006-08-22 0:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-21 17:06 [PATCH 1/3] futex_find_get_task: remove an obscure EXIT_ZOMBIE check Oleg Nesterov
2006-08-22 0:01 ` Bill Huey [this message]
2006-08-22 18:34 ` Oleg Nesterov
2006-08-22 22:03 ` Bill Huey
2006-08-22 10:43 ` Ingo Molnar
2006-08-22 19:10 ` Oleg Nesterov
2006-08-25 10:28 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060822000110.GA31751@gnuppy.monkey.org \
--to=billh@gnuppy.monkey.org \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=oleg@tv-sign.ru \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox