From: Russell King <rmk+lkml@arm.linux.org.uk>
To: Denis Vlasenko <vda.linux@googlemail.com>
Cc: linux-kernel@vger.kernel.org, Andrew Morton <akpm@osdl.org>
Subject: Re: [PATCH 3/3] add generic udelay(), mdelay() and ssleep()
Date: Tue, 22 Aug 2006 17:55:36 +0100 [thread overview]
Message-ID: <20060822165536.GA31064@flint.arm.linux.org.uk> (raw)
In-Reply-To: <200608221622.43244.vda.linux@googlemail.com>
On Tue, Aug 22, 2006 at 04:22:43PM +0200, Denis Vlasenko wrote:
> On Tuesday 22 August 2006 15:51, Denis Vlasenko wrote:
> > > A few arch files won't see the definition of udelay()
> > > in asm/delay.h anymore. Prevent that from biting us later.
> >
> > We are going to kill MAX_UDELAY_MS, so replace it
> > in common code with 1. Also fix a buglet on the way:
> > mpc83xx_spi->nsecs > MAX_UDELAY_MS * 1000
> > was comparing nanoseconds to microseconds.
>
> This patch does the following:
> * make it so than asm/delay.h does not define udelay(),
> only __udelay(), to be used in generic udelay()
> * add generic udelay() which calls __udelay() repeatedly,
> as needed. Protect against overflow in udelay() argument.
> * similarly for mdelay() and ssleep()
> * __const_udelay for all arches is removed or renamed to
> __const_delay (it did not do microsecond delays anyway)
> if still used by arch ndelay() function/macro
> * remove EXPORT_SYMBOL(__udelay). It is not used in modules
> anymore
> * remove MAX_UDELAY_MS
>
> We specifically do not touch ndelay() in thess patches.
> It is not changed.
Please keep a "const" version in ARM. Thanks.
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of: 2.6 Serial core
prev parent reply other threads:[~2006-08-22 16:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200608221545.26019.vda.linux@googlemail.com>
2006-08-22 13:48 ` [PATCH 1/3] s/#include <asm/delay.h>/#include <linux/delay.h>/ Denis Vlasenko
2006-08-22 13:51 ` [PATCH 2/3] remove references to MAX_UDELAY_MS; fix comment Denis Vlasenko
2006-08-22 14:22 ` [PATCH 3/3] add generic udelay(), mdelay() and ssleep() Denis Vlasenko
2006-08-22 16:55 ` Russell King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060822165536.GA31064@flint.arm.linux.org.uk \
--to=rmk+lkml@arm.linux.org.uk \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vda.linux@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox