From: Martin Schwidefsky <schwidefsky@de.ibm.com>
To: linux-kernel@vger.kernel.org
Subject: [patch] dubious process system time.
Date: Thu, 24 Aug 2006 14:18:25 +0200 [thread overview]
Message-ID: <20060824121825.GA4425@skybase> (raw)
From: Martin Schwidefsky <schwidefsky@de.ibm.com>
[patch] dubious process system time.
The system time that is accounted to a process includes the time spent
in three different contexts: normal system time, hardirq time and
softirq time. To account hardirq time and sortirq time to a process
seems wrong, because the process could just happen to run when the
interrupt arrives that was caused by an i/o for a completly different
process. And the sum over stime and cstime of all processes won't
match cputstat->system either.
The following patch changes the accounting of system time so that
hardirq and softirq time are not accounted to a process anymore.
Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
---
kernel/sched.c | 7 +++----
1 files changed, 3 insertions(+), 4 deletions(-)
diff -urpN linux-2.6/kernel/sched.c linux-2.6-patched/kernel/sched.c
--- linux-2.6/kernel/sched.c 2006-08-01 10:09:55.000000000 +0200
+++ linux-2.6-patched/kernel/sched.c 2006-08-24 13:42:40.000000000 +0200
@@ -2939,17 +2939,16 @@ void account_system_time(struct task_str
struct rq *rq = this_rq();
cputime64_t tmp;
- p->stime = cputime_add(p->stime, cputime);
-
/* Add system time to cpustat. */
tmp = cputime_to_cputime64(cputime);
if (hardirq_count() - hardirq_offset)
cpustat->irq = cputime64_add(cpustat->irq, tmp);
else if (softirq_count())
cpustat->softirq = cputime64_add(cpustat->softirq, tmp);
- else if (p != rq->idle)
+ else if (p != rq->idle) {
+ p->stime = cputime_add(p->stime, cputime);
cpustat->system = cputime64_add(cpustat->system, tmp);
- else if (atomic_read(&rq->nr_iowait) > 0)
+ } else if (atomic_read(&rq->nr_iowait) > 0)
cpustat->iowait = cputime64_add(cpustat->iowait, tmp);
else
cpustat->idle = cputime64_add(cpustat->idle, tmp);
next reply other threads:[~2006-08-24 12:18 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-24 12:18 Martin Schwidefsky [this message]
2006-08-24 12:32 ` [patch] dubious process system time Andi Kleen
2006-08-24 13:28 ` Martin Schwidefsky
2006-08-24 15:18 ` Andi Kleen
2006-08-24 16:02 ` Martin Schwidefsky
2006-08-25 10:12 ` Helge Hafting
2006-08-25 10:29 ` Martin Schwidefsky
2006-08-25 12:58 ` Paul Mackerras
2006-08-24 23:40 ` Paul Mackerras
2006-08-25 8:18 ` Martin Schwidefsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060824121825.GA4425@skybase \
--to=schwidefsky@de.ibm.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox