From: Andi Kleen <ak@suse.de>
To: Paul Jackson <pj@sgi.com>
Cc: Andrew Morton <akpm@osdl.org>, Jan Beulich <jbeulich@novell.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86_64: mm fix x86 cpuid keys used in alternative_smp fix
Date: Thu, 24 Aug 2006 13:33:35 +0200 [thread overview]
Message-ID: <200608241333.35985.ak@suse.de> (raw)
In-Reply-To: <20060824105846.23508.59971.sendpatchset@sam.engr.sgi.com>
On Thursday 24 August 2006 12:58, Paul Jackson wrote:
> From: Paul Jackson <pj@sgi.com>
>
> The x86_64 crosstool build was failing due to:
>
> kernel/built-in.o(.smp_altinstructions+0x58): \
> include/asm/spinlock.h:54: undefined reference to `X86_FEATURE_UP'
>
> This reference to X86_FEATURE_UP was added to the definition of
> the alternative_smp() macro in alternative.h by the patch:
> x86_64-mm-fix-x86-cpuid-keys-used-in-alternative_smp
>
> The alternative_smp() macro is used in spinlock.h.
>
> The definition of X86_FEATURE_UP is in asm-x86_64/cpufeature.h.
> If this is included in alternative.h, then the build succeeds.
Ok it seems to depend on the .config, but nobody before submitted
the buggy .config
I folded the patch in
-Andi
prev parent reply other threads:[~2006-08-24 11:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-24 10:58 [PATCH] x86_64: mm fix x86 cpuid keys used in alternative_smp fix Paul Jackson
2006-08-24 11:33 ` Andi Kleen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200608241333.35985.ak@suse.de \
--to=ak@suse.de \
--cc=akpm@osdl.org \
--cc=jbeulich@novell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pj@sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox