From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751152AbWHXLdm (ORCPT ); Thu, 24 Aug 2006 07:33:42 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751158AbWHXLdm (ORCPT ); Thu, 24 Aug 2006 07:33:42 -0400 Received: from mx2.suse.de ([195.135.220.15]:475 "EHLO mx2.suse.de") by vger.kernel.org with ESMTP id S1751152AbWHXLdl (ORCPT ); Thu, 24 Aug 2006 07:33:41 -0400 From: Andi Kleen To: Paul Jackson Subject: Re: [PATCH] x86_64: mm fix x86 cpuid keys used in alternative_smp fix Date: Thu, 24 Aug 2006 13:33:35 +0200 User-Agent: KMail/1.9.3 Cc: Andrew Morton , Jan Beulich , linux-kernel@vger.kernel.org References: <20060824105846.23508.59971.sendpatchset@sam.engr.sgi.com> In-Reply-To: <20060824105846.23508.59971.sendpatchset@sam.engr.sgi.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200608241333.35985.ak@suse.de> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Thursday 24 August 2006 12:58, Paul Jackson wrote: > From: Paul Jackson > > The x86_64 crosstool build was failing due to: > > kernel/built-in.o(.smp_altinstructions+0x58): \ > include/asm/spinlock.h:54: undefined reference to `X86_FEATURE_UP' > > This reference to X86_FEATURE_UP was added to the definition of > the alternative_smp() macro in alternative.h by the patch: > x86_64-mm-fix-x86-cpuid-keys-used-in-alternative_smp > > The alternative_smp() macro is used in spinlock.h. > > The definition of X86_FEATURE_UP is in asm-x86_64/cpufeature.h. > If this is included in alternative.h, then the build succeeds. Ok it seems to depend on the .config, but nobody before submitted the buggy .config I folded the patch in -Andi