From: Christoph Hellwig <hch@infradead.org>
To: Badari Pulavarty <pbadari@us.ibm.com>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
akpm@osdl.org, lkml <linux-kernel@vger.kernel.org>,
ext2-devel <Ext2-devel@lists.sourceforge.net>
Subject: Re: [RFC][PATCH] Manage jbd allocations from its own slabs
Date: Thu, 24 Aug 2006 19:53:42 +0100 [thread overview]
Message-ID: <20060824185342.GA20935@infradead.org> (raw)
In-Reply-To: <1156374495.30517.5.camel@dyn9047017100.beaverton.ibm.com>
On Wed, Aug 23, 2006 at 04:08:15PM -0700, Badari Pulavarty wrote:
> Hi,
>
> Here is the fix to "bh: Ensure bh fits within a page" problem
> caused by JBD.
>
> BTW, I realized that this problem can happen only with 1k, 2k
> filesystems - as 4k, 8k allocations disable slab debug
> automatically. But for completeness, I created slabs for those
> also.
>
> What do you think ? I ran basic tests and things are fine.
Why can't you just use alloc_page? I bet the whole slab overhead
eats more memory than what's wasted when using alloc_pages. Especially
as the typical usecase is a 4k blocks filesystem with 4k pagesize
where the overhead of alloc_page is non-existant.
next prev parent reply other threads:[~2006-08-24 18:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-23 23:08 [RFC][PATCH] Manage jbd allocations from its own slabs Badari Pulavarty
2006-08-23 23:34 ` Andrew Morton
2006-08-24 12:41 ` [Ext2-devel] " Dave Kleikamp
2006-08-25 0:00 ` Badari Pulavarty
2006-08-24 12:29 ` [Ext2-devel] " Dave Kleikamp
2006-08-24 17:12 ` Badari Pulavarty
2006-08-24 18:53 ` Christoph Hellwig [this message]
2006-08-24 19:11 ` Badari Pulavarty
2006-08-25 2:24 ` [Ext2-devel] " Theodore Tso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060824185342.GA20935@infradead.org \
--to=hch@infradead.org \
--cc=Ext2-devel@lists.sourceforge.net \
--cc=akpm@osdl.org \
--cc=herbert@gondor.apana.org.au \
--cc=linux-kernel@vger.kernel.org \
--cc=pbadari@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox