Re: [PATCH 1/4] Inconsistent extern declarations.

Adrian Bunk
2006-08-24T21:17:17Z

On Thu, Aug 24, 2006 at 04:25:18PM +0100, David Woodhouse wrote:

> When you compile multiple files together with --combine, the compiler
> starts to _notice_ when you do things like this in one file:
>
> extern int ipxrtr_route_packet(struct sock *sk, struct sockaddr_ipx *usipx,
> struct iovec *iov, int len, int noblock);
>
> .. but the actual function looks like this:
>
> extern int ipxrtr_route_packet(struct sock *sk, struct sockaddr_ipx *usipx,
> struct iovec *iov, size_t len, int noblock);
>
> This fixes a bunch of those, which are mostly just a missing 'const' on
> the extern declaration.
>...

Nice.

This is a subset of -Wmissing-prototypes warnings, and I'm working for
some time to get the function prototypes into header files to avoid such
bugs (that can in some cases lead to nasty stack corruptions).

But they should be fixed properly by moving the prototypes to header
files.

> dwmw2

cu
Adrian

--

Gentoo kernels are 42 times more popular than SUSE kernels among
KLive users (a service by SUSE contractor Andrea Arcangeli that
gathers data about kernels from many users worldwide).

There are three kinds of lies: Lies, Damn Lies, and Statistics.
Benjamin Disraeli