From: Russell King <rmk+lkml@arm.linux.org.uk>
To: Jan Bernatik <jan.bernatik@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: platform device / driver question
Date: Fri, 25 Aug 2006 14:39:33 +0100 [thread overview]
Message-ID: <20060825133933.GC2287@flint.arm.linux.org.uk> (raw)
In-Reply-To: <dca824fc0608250608s3b371291qd313986cffc1e028@mail.gmail.com>
On Fri, Aug 25, 2006 at 03:08:51PM +0200, Jan Bernatik wrote:
> I studied smc91x driver to understand how platform driver / device
> subsystem works. On #kernelnewbies channel I was told this driver is
> "hopelessly broken". How should one create and register the
> platform_device/driver ? Is the implementation in smc91x correct ?
That's probably from some ill-informed person. As far as I'm aware,
the driver works perfectly and uses the driver model correctly.
There are some aspects of the driver which are less good (such as all
the machine specific configuration gunk in smc91x.h) but apart from
that, it's fine.
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of: 2.6 Serial core
next prev parent reply other threads:[~2006-08-25 13:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-25 13:08 platform device / driver question Jan Bernatik
2006-08-25 13:39 ` Russell King [this message]
2006-08-25 17:07 ` Marc Singer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060825133933.GC2287@flint.arm.linux.org.uk \
--to=rmk+lkml@arm.linux.org.uk \
--cc=jan.bernatik@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox