From: Ingo Molnar <mingo@elte.hu>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: Arjan van de Ven <arjan@linux.intel.com>,
linux-kernel@vger.kernel.org, len.brown@intel.com, akpm@osdl.org,
jbarnes@virtuousgeek.org, dwalker@mvista.com,
nickpiggin@yahoo.com.au
Subject: Re: [RFC] maximum latency tracking infrastructure (version 2)
Date: Fri, 25 Aug 2006 15:58:15 +0200 [thread overview]
Message-ID: <20060825135815.GA29706@elte.hu> (raw)
In-Reply-To: <20060825133034.GC5205@martell.zuzino.mipt.ru>
* Alexey Dobriyan <adobriyan@gmail.com> wrote:
> > +#ifndef _INCLUDE_GUARD_LATENCY_H_
> > +#define _INCLUDE_GUARD_LATENCY_H_
> > +
> > +#include <linux/notifier.h>
>
> Just
> struct notifier_block;
not really. Either use the #include, or if you want less stuff included,
split notifier.h into notifier_types.h and notifier.h and move the data
structure declarations to notifier_types.h and then #include
notifier_types.h. (spinlock_types.h works like this.) This allows
headers to be separated into pure 'data structure' and 'access methods'
portions. Using explicit forward declarations is less cleaner.
Ingo
next prev parent reply other threads:[~2006-08-25 14:05 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-25 11:22 [RFC] maximum latency tracking infrastructure (version 2) Arjan van de Ven
2006-08-25 13:30 ` Alexey Dobriyan
2006-08-25 13:34 ` Arjan van de Ven
2006-08-25 13:58 ` Ingo Molnar [this message]
2006-08-25 13:43 ` Jan Kiszka
2006-08-25 13:48 ` Arjan van de Ven
2006-08-25 14:18 ` Jan Kiszka
2006-08-25 15:15 ` Jesse Barnes
2006-08-25 15:43 ` Daniel Walker
2006-08-25 19:26 ` Arjan van de Ven
2006-08-25 19:35 ` Daniel Walker
2006-08-25 22:14 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060825135815.GA29706@elte.hu \
--to=mingo@elte.hu \
--cc=adobriyan@gmail.com \
--cc=akpm@osdl.org \
--cc=arjan@linux.intel.com \
--cc=dwalker@mvista.com \
--cc=jbarnes@virtuousgeek.org \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nickpiggin@yahoo.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox