Re: [PATCH 1/2] Add SATA support to libsas

[Adrian Bunk <bunk@stusta.de>]

On Fri, Aug 25, 2006 at 03:43:38PM -0400, Konrad Rzeszutek wrote:
> On Thu, Aug 10, 2006 at 07:19:47PM -0700, Darrick J. Wong wrote:
> > Hook the scsi_host_template functions in libsas to delegate
> > functionality to libata when appropriate.
> > 
> > Signed-off-by: Darrick J. Wong <djwong@us.ibm.com>
> > 
> > diff --git a/drivers/scsi/libsas/sas_discover.c b/drivers/scsi/libsas/sas_discover.c
> > index b0705ee..76bbb9f 100644
> > --- a/drivers/scsi/libsas/sas_discover.c
> > +++ b/drivers/scsi/libsas/sas_discover.c
> 
> (...)
> 
> >  /* ---------- Domain device ---------- */
> > @@ -626,4 +634,8 @@ void sas_unregister_devices(struct sas_h
> >  
> >  void sas_init_dev(struct domain_device *);
> >  
> > +extern void sas_target_destroy(struct scsi_target *);
> > +extern int sas_slave_alloc(struct scsi_device *);
> > +extern int sas_ioctl(struct scsi_device *sdev, int cmd, void __user *arg);
> > +
> 
> Those should not be 'extern' otherwise the EXPORT_SYMBOL functions 
> won't be found when the aic94xx is built as a module.

The "extern"s can be dropped since they don't have any effect, but 
I don't see what problem you are thinking of.

cu
Adrian

-- 

    Gentoo kernels are 42 times more popular than SUSE kernels among
    KLive users  (a service by SUSE contractor Andrea Arcangeli that
    gathers data about kernels from many users worldwide).

       There are three kinds of lies: Lies, Damn Lies, and Statistics.
                                                    Benjamin Disraeli