From: Michael Halcrow <mhalcrow@us.ibm.com>
To: David Howells <dhowells@redhat.com>
Cc: akpm@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/4] eCryptfs: ino_t to u64 for filldir
Date: Fri, 25 Aug 2006 17:16:15 -0500 [thread overview]
Message-ID: <20060825221615.GA11613@us.ibm.com> (raw)
In-Reply-To: <22796.1156542677@warthog.cambridge.redhat.com>
On Fri, Aug 25, 2006 at 10:51:17PM +0100, David Howells wrote:
> Michael Halcrow <mhalcrow@us.ibm.com> wrote:
> > filldir()'s inode number is now type u64 instead of ino_t.
>
> Btw, in ecryptfs_interpose(), you have:
>
> inode = iget(sb, lower_inode->i_ino);
>
> But you have to be *very* *very* careful doing that. i_ino may be
> ambiguous. My suggestions to make i_ino bigger were turned down by
> Al Viro; and even it were bigger, it might still not be unique.
Is this the case as long as we stay under the same mountpoint?
Mike
next prev parent reply other threads:[~2006-08-25 22:16 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-24 18:17 [PATCH 0/4] eCryptfs: Public key support Michael Halcrow
2006-08-24 18:18 ` [PATCH 1/4] eCryptfs: Netlink functions for public key Michael Halcrow
2006-08-25 3:54 ` Andrew Morton
2006-08-25 19:18 ` Michael Halcrow
2006-08-28 20:02 ` Andrew Morton
2006-08-24 18:19 ` [PATCH 2/4] eCryptfs: Public key header packets Michael Halcrow
2006-08-24 18:20 ` [PATCH 3/4] eCryptfs: Open-code flag manipulation Michael Halcrow
2006-08-25 21:42 ` David Howells
2006-08-24 18:20 ` [PATCH 4/4] eCryptfs: ino_t to u64 for filldir Michael Halcrow
2006-08-25 21:42 ` David Howells
2006-08-25 21:51 ` David Howells
2006-08-25 22:16 ` Michael Halcrow [this message]
2006-08-25 22:59 ` David Howells
2006-08-30 21:12 ` Michael Halcrow
2006-08-31 10:30 ` David Howells
2006-09-04 22:54 ` Michael Halcrow
2006-09-06 9:44 ` David Howells
2006-09-06 23:20 ` Michael Halcrow
2006-09-07 10:28 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060825221615.GA11613@us.ibm.com \
--to=mhalcrow@us.ibm.com \
--cc=akpm@osdl.org \
--cc=dhowells@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox