From: Arnd Bergmann <arnd.bergmann@de.ibm.com>
To: David Howells <dhowells@redhat.com>
Cc: Sam Ravnborg <sam@ravnborg.org>,
axboe@kernel.dk, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 04/18] [PATCH] BLOCK: Separate the bounce buffering code from the highmem code [try #4]
Date: Tue, 29 Aug 2006 15:59:20 +0200 [thread overview]
Message-ID: <200608291559.20802.arnd.bergmann@de.ibm.com> (raw)
In-Reply-To: <29516.1156859236@warthog.cambridge.redhat.com>
On Tuesday 29 August 2006 15:47, David Howells wrote:
> Arnd Bergmann <arnd.bergmann@de.ibm.com> wrote:
>
> > You could write it as
> >
> > bounce-$(CONFIG_MMU) += bounce.o
> > obj-$(CONFIG_BLOCK) += $(bounce-y)
>
> I could, yes, but why? What does it buy? I think this:
>
> ifeq ($(CONFIG_MMU)$(CONFIG_BLOCK),yy)
> obj-y += bounce.o
> endif
>
> is clearer.
I remember having seen the first one in the kernel before
(e.g. in arch/powerpc/kernel/Makefile), but not the other one.
I agree that it doesn't make much difference at all, but it
would be nice to be consistant.
Arnd <><
next prev parent reply other threads:[~2006-08-29 13:59 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-25 19:36 [PATCH 00/18] BLOCK: Permit block layer to be disabled [try #4] David Howells
2006-08-25 19:37 ` [PATCH 01/18] [PATCH] BLOCK: Move functions out of buffer code " David Howells
2006-08-25 19:37 ` [PATCH 02/18] [PATCH] BLOCK: Remove duplicate declaration of exit_io_context() " David Howells
2006-08-25 19:37 ` [PATCH 03/18] [PATCH] BLOCK: Stop fallback_migrate_page() from using page_has_buffers() " David Howells
2006-08-25 19:37 ` [PATCH 04/18] [PATCH] BLOCK: Separate the bounce buffering code from the highmem code " David Howells
2006-08-25 20:04 ` Sam Ravnborg
2006-08-25 20:18 ` David Howells
2006-08-28 11:52 ` Arnd Bergmann
2006-08-29 13:47 ` David Howells
2006-08-29 13:59 ` Arnd Bergmann [this message]
2006-08-25 19:37 ` [PATCH 05/18] [PATCH] BLOCK: Don't call block_sync_page() from AFS " David Howells
2006-08-27 21:21 ` Chris Wedgwood
2006-08-29 9:00 ` David Howells
2006-08-29 11:57 ` Christoph Hellwig
2006-08-29 12:25 ` David Howells
2006-08-25 19:37 ` [PATCH 06/18] [PATCH] BLOCK: Move extern declarations out of fs/*.c into header files " David Howells
2006-08-25 20:07 ` Sam Ravnborg
2006-08-25 20:20 ` David Howells
2006-08-25 19:37 ` [PATCH 07/18] [PATCH] BLOCK: Remove dependence on existence of blockdev_superblock " David Howells
2006-08-25 19:37 ` [PATCH 08/18] [PATCH] BLOCK: Dissociate generic_writepages() from mpage stuff " David Howells
2006-08-25 19:37 ` [PATCH 09/18] [PATCH] BLOCK: Move __invalidate_device() to block_dev.c " David Howells
2006-08-25 19:37 ` [PATCH 10/18] [PATCH] BLOCK: Move the loop device ioctl compat stuff to the loop driver " David Howells
2006-08-25 19:37 ` [PATCH 11/18] [PATCH] BLOCK: Move common FS-specific ioctls to linux/fs.h " David Howells
2006-08-25 19:37 ` [PATCH 12/18] [PATCH] BLOCK: Move the ReiserFS device ioctl compat stuff to the ReiserFS driver " David Howells
2006-08-25 19:37 ` [PATCH 13/18] [PATCH] BLOCK: Move the Ext2 device ioctl compat stuff to the Ext2 " David Howells
2006-08-25 19:37 ` [PATCH 14/18] [PATCH] BLOCK: Move the Ext3 device ioctl compat stuff to the Ext3 " David Howells
2006-08-25 19:37 ` [PATCH 15/18] [PATCH] BLOCK: Move the msdos device ioctl compat stuff to the msdos " David Howells
2006-08-25 19:37 ` [PATCH 16/18] [PATCH] BLOCK: Remove no-longer necessary linux/mpage.h inclusions " David Howells
2006-08-25 19:37 ` [PATCH 17/18] [PATCH] BLOCK: Remove no-longer necessary linux/buffer_head.h " David Howells
2006-08-25 19:37 ` [PATCH 18/18] [PATCH] BLOCK: Make it possible to disable the block layer " David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200608291559.20802.arnd.bergmann@de.ibm.com \
--to=arnd.bergmann@de.ibm.com \
--cc=axboe@kernel.dk \
--cc=dhowells@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox