public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Benjamin LaHaise <bcrl@kvack.org>
To: Zach Brown <zab@zabbo.net>
Cc: Yi Yang <yang.y.yi@gmail.com>,
	linux-kernel@vger.kernel.org, Andrew Morton <akpm@osdl.org>,
	linux-aio <linux-aio@kvack.org>
Subject: Re: [2.6.18-rc* PATCH RFC]: Correct ambiguous errno of aio
Date: Tue, 29 Aug 2006 15:04:11 -0400	[thread overview]
Message-ID: <20060829190411.GK18092@kvack.org> (raw)
In-Reply-To: <44F48825.4050408@zabbo.net>

On Tue, Aug 29, 2006 at 11:32:05AM -0700, Zach Brown wrote:
> Like it or not, the sys_io_submit() interface returns -EINVAL when the
> file descriptor doesn't support the requested command.  Changing the
> binary interface is a big deal and should not be done lightly.  What is
> the motivation for making this change?

-EOPNOTSUPP also gives the wrong error message, as it is a networking 
error.  Any program which knows that it is submitting a correctly filled 
in set of parameters can deduce the reason for the -EINVAL.  Changing it 
otherwise would result in behaviour outside of that specified in the man 
page (which lists reasons for the -EINVAL result).

		-ben
-- 
"Time is of no importance, Mr. President, only life is important."
Don't Email: <dont@kvack.org>.

  reply	other threads:[~2006-08-29 19:04 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-08-29 13:21 [2.6.18-rc* PATCH RFC]: Correct ambiguous errno of aio Yi Yang
2006-08-29 18:32 ` Zach Brown
2006-08-29 19:04   ` Benjamin LaHaise [this message]
2006-08-30 14:19   ` [2.6.18-rc5 PATCH]: aio cleanup Yi Yang
2006-08-30 16:30     ` Zach Brown
     [not found]   ` <4c4443230608300651n34e8dbbdn8749c6874ce8791@mail.gmail.com>
2006-08-30 16:35     ` [2.6.18-rc* PATCH RFC]: Correct ambiguous errno of aio Zach Brown
  -- strict thread matches above, loose matches on Subject: below --
2006-08-30 13:55 Yi Yang
2006-08-28 13:28 Yi Yang
2006-08-28 15:42 ` Randy.Dunlap
2006-08-28 16:08 ` Frederik Deweerdt
2006-08-28 14:55   ` Yi Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060829190411.GK18092@kvack.org \
    --to=bcrl@kvack.org \
    --cc=akpm@osdl.org \
    --cc=linux-aio@kvack.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=yang.y.yi@gmail.com \
    --cc=zab@zabbo.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox