Re: [PATCH] MODULE_FIRMWARE for binary firmware(s)

Greg KH
2006-08-29T20:17:39Z

On Tue, Aug 29, 2006 at 03:13:34PM +0200, Marcel Holtmann wrote:
> Hi James,
>
> > From: Jon Masters <jcm@redhat.com>
> >
> > Right now, various kernel modules are being migrated over to use
> > request_firmware in order to pull in binary firmware blobs from userland
> > when the module is loaded. This makes sense.
> >
> > However, there is right now little mechanism in place to automatically
> > determine which binary firmware blobs must be included with a kernel in
> > order to satisfy the prerequisites of these drivers. This affects
> > vendors, but also regular users to a certain extent too.
> >
> > The attached patch introduces MODULE_FIRMWARE as a mechanism for
> > advertising that a particular firmware file is to be loaded - it will
> > then show up via modinfo and could be used e.g. when packaging a kernel.
>
> this patch was debated, but we never came to a final conclusion. I am
> all for it. It is simple and can improve the current situation.
>
> > Signed-off-by: Jon Masters <jcm@redhat.com>
>
> Signed-off-by: Marcel Holtmann <marcel@holtmann.org>

Since your tree will depend on this change, you can add it there and
add:

Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

from me to the patch.

thanks,

greg k-h