Re: [PATCH][RFC] exception processing in early boot

[Willy Tarreau <w@1wt.eu>]

On Wed, Aug 30, 2006 at 11:51:39AM +0200, Andi Kleen wrote:
> Willy Tarreau <w@1wt.eu> writes:
> 
> > Hi,
> > 
> > PaX Team has sent me this patch for inclusion. Basically, during early
> > boot on x86, the exception handler does not make a special case for
> > exceptions which push an error code onto the stack, leading to a return
> > to a wrong address. Two patches were proposed, one which would add a
> > special case for all exceptions using the return code, and this one. The
> > former was of no use in its form because the return from the exception
> > handler would get back to the faulting exception, causing it to loop.
> > 
> > This one should be better as it effectively hangs the system using HLT
> > to prevent CPU from burning.
> 
> Looks good.
> 
> [I'm glad this particular ward in x86 was fixed in x86-64 ...]

good.

> > If nobody has any objections, I will merge it. In this case, I would also
> > like someone to check if 2.6 needs it and to port it in this case.
> 
> I don't think you should merge anything like this before 2.6 does. Otherwise
> we just end up with the mad situation again that an old release has 
> more bugs fixed or more features than the new release.

Unfortunately, this situation is even more difficult for me, because it's
getting very hard to track patches that get applied, rejected, modified or
obsoleted, which is even more true when people don't always think about
sending an ACK after the patch finally gets in. I already have a few pending
patches in my queue waiting for an ACK that will have to be tracked if the
persons do not respond, say, within one week. Otherwise I might simply lose
them.

I think that the good method would be to :
  - announce the patch
  - find a volunteer to port it
  - apply it once the volunteer agrees to handle it

This way, no code gets lost because there's always someone to track it.

> -Andi

Regards,
Willy