From: Mathieu Desnoyers <compudj@krystal.dyndns.org>
To: linux-kernel@vger.kernel.org, ak@muc.de, vojtech@suse.cz
Subject: arch/x86_64/kernel/traps.c:show_trace should use __kernel_text_address
Date: Wed, 30 Aug 2006 12:02:14 -0400 [thread overview]
Message-ID: <20060830160214.GA5557@Krystal> (raw)
Hi,
I noticed arch/x86_64/kernel/traps.c:show_trace uses kernel_text_address to
verify that an address can potentially belong to kernel code. However, this
version takes a spinlock and should not be called from oops. I think
__kernel_text_address would be more appropriate there.
Mathieu Desnoyers
OpenPGP public key: http://krystal.dyndns.org:8080/key/compudj.gpg
Key fingerprint: 8CD5 52C3 8E3C 4140 715F BA06 3F25 A8FE 3BAE 9A68
next reply other threads:[~2006-08-30 16:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-30 16:02 Mathieu Desnoyers [this message]
2006-08-30 16:58 ` arch/x86_64/kernel/traps.c:show_trace should use __kernel_text_address Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060830160214.GA5557@Krystal \
--to=compudj@krystal.dyndns.org \
--cc=ak@muc.de \
--cc=linux-kernel@vger.kernel.org \
--cc=vojtech@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox