* arch/x86_64/kernel/traps.c:show_trace should use __kernel_text_address
@ 2006-08-30 16:02 Mathieu Desnoyers
2006-08-30 16:58 ` Andi Kleen
0 siblings, 1 reply; 2+ messages in thread
From: Mathieu Desnoyers @ 2006-08-30 16:02 UTC (permalink / raw)
To: linux-kernel, ak, vojtech
Hi,
I noticed arch/x86_64/kernel/traps.c:show_trace uses kernel_text_address to
verify that an address can potentially belong to kernel code. However, this
version takes a spinlock and should not be called from oops. I think
__kernel_text_address would be more appropriate there.
Mathieu Desnoyers
OpenPGP public key: http://krystal.dyndns.org:8080/key/compudj.gpg
Key fingerprint: 8CD5 52C3 8E3C 4140 715F BA06 3F25 A8FE 3BAE 9A68
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: arch/x86_64/kernel/traps.c:show_trace should use __kernel_text_address
2006-08-30 16:02 arch/x86_64/kernel/traps.c:show_trace should use __kernel_text_address Mathieu Desnoyers
@ 2006-08-30 16:58 ` Andi Kleen
0 siblings, 0 replies; 2+ messages in thread
From: Andi Kleen @ 2006-08-30 16:58 UTC (permalink / raw)
To: Mathieu Desnoyers; +Cc: linux-kernel
Mathieu Desnoyers <compudj@krystal.dyndns.org> writes:
> Hi,
>
> I noticed arch/x86_64/kernel/traps.c:show_trace uses kernel_text_address to
> verify that an address can potentially belong to kernel code. However, this
> version takes a spinlock and should not be called from oops. I think
> __kernel_text_address would be more appropriate there.
Ok I changed it. Thanks
-Andi
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2006-08-30 16:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-08-30 16:02 arch/x86_64/kernel/traps.c:show_trace should use __kernel_text_address Mathieu Desnoyers
2006-08-30 16:58 ` Andi Kleen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox