* 2.6.18-rc4-mm3: ROOT_NFS=y compile error
2006-08-26 23:09 2.6.18-rc4-mm3 Andrew Morton
@ 2006-08-26 23:56 ` Adrian Bunk
2006-08-27 18:25 ` Chuck Lever
2006-08-27 1:59 ` [-mm patch] drivers/i2c/busses/scx200_i2c.c: update struct scx200_i2c_data Adrian Bunk
` (12 subsequent siblings)
13 siblings, 1 reply; 36+ messages in thread
From: Adrian Bunk @ 2006-08-26 23:56 UTC (permalink / raw)
To: Andrew Morton, Chuck Lever, Trond Myklebust; +Cc: linux-kernel
On Sat, Aug 26, 2006 at 04:09:22PM -0700, Andrew Morton wrote:
>...
> Changes since 2.6.18-rc4-mm2:
>...
> git-nfs.patch
>...
> git trees
>...
This breaks CONFIG_ROOT_NFS=y:
<-- snip -->
...
CC fs/nfs/mount_clnt.o
/home/bunk/linux/kernel-2.6/linux-2.6.18-rc4-mm3/fs/nfs/mount_clnt.c: In function ‘mnt_create’:
/home/bunk/linux/kernel-2.6/linux-2.6.18-rc4-mm3/fs/nfs/mount_clnt.c:82: error: implicit declaration of function ‘xprt_create_proto’
/home/bunk/linux/kernel-2.6/linux-2.6.18-rc4-mm3/fs/nfs/mount_clnt.c:82: warning: assignment makes pointer from integer without a cast
/home/bunk/linux/kernel-2.6/linux-2.6.18-rc4-mm3/fs/nfs/mount_clnt.c:86: error: implicit declaration of function ‘rpc_create_client’
/home/bunk/linux/kernel-2.6/linux-2.6.18-rc4-mm3/fs/nfs/mount_clnt.c:88: warning: assignment makes pointer from integer without a cast
make[3]: *** [fs/nfs/mount_clnt.o] Error 1
<-- snip -->
cu
Adrian
--
Gentoo kernels are 42 times more popular than SUSE kernels among
KLive users (a service by SUSE contractor Andrea Arcangeli that
gathers data about kernels from many users worldwide).
There are three kinds of lies: Lies, Damn Lies, and Statistics.
Benjamin Disraeli
^ permalink raw reply [flat|nested] 36+ messages in thread* Re: 2.6.18-rc4-mm3: ROOT_NFS=y compile error
2006-08-26 23:56 ` 2.6.18-rc4-mm3: ROOT_NFS=y compile error Adrian Bunk
@ 2006-08-27 18:25 ` Chuck Lever
2006-08-27 20:56 ` Andrew Morton
0 siblings, 1 reply; 36+ messages in thread
From: Chuck Lever @ 2006-08-27 18:25 UTC (permalink / raw)
To: Adrian Bunk, Andrew Morton, Trond Myklebust; +Cc: linux-kernel
----- Original Message -----
From: "Adrian Bunk" <bunk@stusta.de>
To: "Andrew Morton" <akpm@osdl.org>; "Chuck Lever" <chuck.lever@oracle.com>;
"Trond Myklebust" <Trond.Myklebust@netapp.com>
Cc: <linux-kernel@vger.kernel.org>
Sent: Saturday, August 26, 2006 7:56 PM
Subject: 2.6.18-rc4-mm3: ROOT_NFS=y compile error
> On Sat, Aug 26, 2006 at 04:09:22PM -0700, Andrew Morton wrote:
>>...
>> Changes since 2.6.18-rc4-mm2:
>>...
>> git-nfs.patch
>>...
>> git trees
>>...
>
> This breaks CONFIG_ROOT_NFS=y:
>
> <-- snip -->
>
> ...
> CC fs/nfs/mount_clnt.o
> /home/bunk/linux/kernel-2.6/linux-2.6.18-rc4-mm3/fs/nfs/mount_clnt.c: In
> function ‘mnt_create’:
> /home/bunk/linux/kernel-2.6/linux-2.6.18-rc4-mm3/fs/nfs/mount_clnt.c:82:
> error: implicit declaration of function ‘xprt_create_proto’
> /home/bunk/linux/kernel-2.6/linux-2.6.18-rc4-mm3/fs/nfs/mount_clnt.c:82:
> warning: assignment makes pointer from integer without a cast
> /home/bunk/linux/kernel-2.6/linux-2.6.18-rc4-mm3/fs/nfs/mount_clnt.c:86:
> error: implicit declaration of function ‘rpc_create_client’
> /home/bunk/linux/kernel-2.6/linux-2.6.18-rc4-mm3/fs/nfs/mount_clnt.c:88:
> warning: assignment makes pointer from integer without a cast
> make[3]: *** [fs/nfs/mount_clnt.o] Error 1
>
> <-- snip -->
Looks like a patch got misapplied somewhere. All my copies of this patch
series has this change, but Andrew's doesn't. Trond, let's hook up Monday
and work this out.
^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: 2.6.18-rc4-mm3: ROOT_NFS=y compile error
2006-08-27 18:25 ` Chuck Lever
@ 2006-08-27 20:56 ` Andrew Morton
2006-08-28 17:36 ` Chuck Lever
0 siblings, 1 reply; 36+ messages in thread
From: Andrew Morton @ 2006-08-27 20:56 UTC (permalink / raw)
To: Chuck Lever; +Cc: Adrian Bunk, Trond Myklebust, linux-kernel
On Sun, 27 Aug 2006 14:25:21 -0400
"Chuck Lever" <chuck.lever@oracle.com> wrote:
> > CC fs/nfs/mount_clnt.o
> > /home/bunk/linux/kernel-2.6/linux-2.6.18-rc4-mm3/fs/nfs/mount_clnt.c: In
> > function ‘mnt_create’:
> > /home/bunk/linux/kernel-2.6/linux-2.6.18-rc4-mm3/fs/nfs/mount_clnt.c:82:
> > error: implicit declaration of function ‘xprt_create_proto’
> > /home/bunk/linux/kernel-2.6/linux-2.6.18-rc4-mm3/fs/nfs/mount_clnt.c:82:
> > warning: assignment makes pointer from integer without a cast
> > /home/bunk/linux/kernel-2.6/linux-2.6.18-rc4-mm3/fs/nfs/mount_clnt.c:86:
> > error: implicit declaration of function ‘rpc_create_client’
> > /home/bunk/linux/kernel-2.6/linux-2.6.18-rc4-mm3/fs/nfs/mount_clnt.c:88:
> > warning: assignment makes pointer from integer without a cast
> > make[3]: *** [fs/nfs/mount_clnt.o] Error 1
> >
> > <-- snip -->
>
> Looks like a patch got misapplied somewhere.
That's quite possible.
> All my copies of this patch
> series has this change, but Andrew's doesn't.
What is "this change"? The only change I see in Trond's mount_clnt.c is the
removal of the xprt.h include.
^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: 2.6.18-rc4-mm3: ROOT_NFS=y compile error
2006-08-27 20:56 ` Andrew Morton
@ 2006-08-28 17:36 ` Chuck Lever
2006-08-28 17:43 ` Trond Myklebust
0 siblings, 1 reply; 36+ messages in thread
From: Chuck Lever @ 2006-08-28 17:36 UTC (permalink / raw)
To: Andrew Morton; +Cc: Adrian Bunk, Trond Myklebust, linux-kernel
----- Original Message -----
From: "Andrew Morton" <akpm@osdl.org>
To: "Chuck Lever" <chuck.lever@oracle.com>
Cc: "Adrian Bunk" <bunk@stusta.de>; "Trond Myklebust"
<Trond.Myklebust@netapp.com>; <linux-kernel@vger.kernel.org>
Sent: Sunday, August 27, 2006 4:56 PM
Subject: Re: 2.6.18-rc4-mm3: ROOT_NFS=y compile error
>> All my copies of this patch
>> series has this change, but Andrew's doesn't.
>
> What is "this change"? The only change I see in Trond's mount_clnt.c is
> the
> removal of the xprt.h include.
Found the problem. Because of changes Trond had included already in his
tree, my patches didn't fit on his repository. When I ported my patches to
his tree, I accidentally left out the hunk that updates fs/nfs/mount_clnt.c.
Trond should be sending out the missing hunk soon.
^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: 2.6.18-rc4-mm3: ROOT_NFS=y compile error
2006-08-28 17:36 ` Chuck Lever
@ 2006-08-28 17:43 ` Trond Myklebust
0 siblings, 0 replies; 36+ messages in thread
From: Trond Myklebust @ 2006-08-28 17:43 UTC (permalink / raw)
To: Chuck Lever; +Cc: Andrew Morton, Adrian Bunk, linux-kernel
On Mon, 2006-08-28 at 13:36 -0400, Chuck Lever wrote:
> ----- Original Message -----
> From: "Andrew Morton" <akpm@osdl.org>
> To: "Chuck Lever" <chuck.lever@oracle.com>
> Cc: "Adrian Bunk" <bunk@stusta.de>; "Trond Myklebust"
> <Trond.Myklebust@netapp.com>; <linux-kernel@vger.kernel.org>
> Sent: Sunday, August 27, 2006 4:56 PM
> Subject: Re: 2.6.18-rc4-mm3: ROOT_NFS=y compile error
>
> >> All my copies of this patch
> >> series has this change, but Andrew's doesn't.
> >
> > What is "this change"? The only change I see in Trond's mount_clnt.c is
> > the
> > removal of the xprt.h include.
>
> Found the problem. Because of changes Trond had included already in his
> tree, my patches didn't fit on his repository. When I ported my patches to
> his tree, I accidentally left out the hunk that updates fs/nfs/mount_clnt.c.
>
> Trond should be sending out the missing hunk soon.
Already merged into the NFS git tree. See
http://linux-nfs.org/cgi-bin/gitweb.cgi?p=nfs-2.6.git;a=commitdiff;h=f0d01cd34daccb47b7eeab03f80fe7986485528e
The raw patch can also be found on
http://client.linux-nfs.org/Linux-2.6.x/2.6.18-rc5/linux-2.6.18-056-fix_nfsroot.dif
Cheers,
Trond
^ permalink raw reply [flat|nested] 36+ messages in thread
* [-mm patch] drivers/i2c/busses/scx200_i2c.c: update struct scx200_i2c_data
2006-08-26 23:09 2.6.18-rc4-mm3 Andrew Morton
2006-08-26 23:56 ` 2.6.18-rc4-mm3: ROOT_NFS=y compile error Adrian Bunk
@ 2006-08-27 1:59 ` Adrian Bunk
2006-08-27 8:20 ` Jean Delvare
2006-08-27 2:42 ` 2.6.18-rc4-mm3: NF_CONNTRACK_FTP=y compile error Adrian Bunk
` (11 subsequent siblings)
13 siblings, 1 reply; 36+ messages in thread
From: Adrian Bunk @ 2006-08-27 1:59 UTC (permalink / raw)
To: Andrew Morton, Jean Delvare
Cc: linux-kernel, christer, Greg Kroah-Hartman, i2c
On Sat, Aug 26, 2006 at 04:09:22PM -0700, Andrew Morton wrote:
>...
> Changes since 2.6.18-rc4-mm2:
>...
> +gregkh-i2c-i2c-algo-bit-kill-mdelay.patch
>...
> I2C tree updates
>...
drivers/i2c/busses/scx200_i2c.c was forgotten:
<-- snip -->
...
CC drivers/i2c/busses/scx200_i2c.o
/home/bunk/linux/kernel-2.6/linux-2.6.18-rc4-mm3/drivers/i2c/busses/scx200_i2c.c:79: warning: excess elements in struct initializer
/home/bunk/linux/kernel-2.6/linux-2.6.18-rc4-mm3/drivers/i2c/busses/scx200_i2c.c:79: warning: (near initialization for ‘scx200_i2c_data’)
...
<-- snip -->
While fixing it, I also converted the struct to C99 initializers.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
--- linux-2.6.18-rc4-mm3/drivers/i2c/busses/scx200_i2c.c.old 2006-08-27 03:57:50.000000000 +0200
+++ linux-2.6.18-rc4-mm3/drivers/i2c/busses/scx200_i2c.c 2006-08-27 03:51:50.000000000 +0200
@@ -71,12 +71,12 @@
*/
static struct i2c_algo_bit_data scx200_i2c_data = {
- NULL,
- scx200_i2c_setsda,
- scx200_i2c_setscl,
- scx200_i2c_getsda,
- scx200_i2c_getscl,
- 10, 10, 100, /* waits, timeout */
+ .setsda = scx200_i2c_setsda,
+ .setscl = scx200_i2c_setscl,
+ .getsda = scx200_i2c_getsda,
+ .getscl = scx200_i2c_getscl,
+ .udelay = 10,
+ .timeout = 100,
};
static struct i2c_adapter scx200_i2c_ops = {
^ permalink raw reply [flat|nested] 36+ messages in thread* Re: [-mm patch] drivers/i2c/busses/scx200_i2c.c: update struct scx200_i2c_data
2006-08-27 1:59 ` [-mm patch] drivers/i2c/busses/scx200_i2c.c: update struct scx200_i2c_data Adrian Bunk
@ 2006-08-27 8:20 ` Jean Delvare
0 siblings, 0 replies; 36+ messages in thread
From: Jean Delvare @ 2006-08-27 8:20 UTC (permalink / raw)
To: Adrian Bunk
Cc: Andrew Morton, linux-kernel, christer, Greg Kroah-Hartman, i2c
Hi Adrian,
> On Sat, Aug 26, 2006 at 04:09:22PM -0700, Andrew Morton wrote:
> >...
> > Changes since 2.6.18-rc4-mm2:
> >...
> > +gregkh-i2c-i2c-algo-bit-kill-mdelay.patch
> >...
> > I2C tree updates
> >...
>
> drivers/i2c/busses/scx200_i2c.c was forgotten:
>
> <-- snip -->
>
> ...
> CC drivers/i2c/busses/scx200_i2c.o
> /home/bunk/linux/kernel-2.6/linux-2.6.18-rc4-mm3/drivers/i2c/busses/scx200_i2c.c:79: warning: excess elements in struct initializer
> /home/bunk/linux/kernel-2.6/linux-2.6.18-rc4-mm3/drivers/i2c/busses/scx200_i2c.c:79: warning: (near initialization for ‘scx200_i2c_data’)
> ...
>
> <-- snip -->
>
> While fixing it, I also converted the struct to C99 initializers.
>
> Signed-off-by: Adrian Bunk <bunk@stusta.de>
>
> --- linux-2.6.18-rc4-mm3/drivers/i2c/busses/scx200_i2c.c.old 2006-08-27 03:57:50.000000000 +0200
> +++ linux-2.6.18-rc4-mm3/drivers/i2c/busses/scx200_i2c.c 2006-08-27 03:51:50.000000000 +0200
> @@ -71,12 +71,12 @@
> */
>
> static struct i2c_algo_bit_data scx200_i2c_data = {
> - NULL,
> - scx200_i2c_setsda,
> - scx200_i2c_setscl,
> - scx200_i2c_getsda,
> - scx200_i2c_getscl,
> - 10, 10, 100, /* waits, timeout */
> + .setsda = scx200_i2c_setsda,
> + .setscl = scx200_i2c_setscl,
> + .getsda = scx200_i2c_getsda,
> + .getscl = scx200_i2c_getscl,
> + .udelay = 10,
> + .timeout = 100,
> };
>
> static struct i2c_adapter scx200_i2c_ops = {
Good catch, thanks for fixing that. I tried to catch and fix all users
when dropping mdelay from struct i2c_algo_bit_data, but obviously I
missed this one.
Patch applied.
--
Jean Delvare
^ permalink raw reply [flat|nested] 36+ messages in thread
* 2.6.18-rc4-mm3: NF_CONNTRACK_FTP=y compile error
2006-08-26 23:09 2.6.18-rc4-mm3 Andrew Morton
2006-08-26 23:56 ` 2.6.18-rc4-mm3: ROOT_NFS=y compile error Adrian Bunk
2006-08-27 1:59 ` [-mm patch] drivers/i2c/busses/scx200_i2c.c: update struct scx200_i2c_data Adrian Bunk
@ 2006-08-27 2:42 ` Adrian Bunk
2006-08-27 2:49 ` David Miller
2006-08-27 2:47 ` [-mm patch] struct i2c_algo_pcf_data: remove the mdelay member Adrian Bunk
` (10 subsequent siblings)
13 siblings, 1 reply; 36+ messages in thread
From: Adrian Bunk @ 2006-08-27 2:42 UTC (permalink / raw)
To: Andrew Morton, YOSHIFUJI Hideaki, davem; +Cc: linux-kernel, netdev, coreteam
On Sat, Aug 26, 2006 at 04:09:22PM -0700, Andrew Morton wrote:
>...
> Changes since 2.6.18-rc4-mm2:
>...
> git-net.patch
>...
> git trees
>...
<-- snip -->
...
CC net/netfilter/nf_conntrack_ftp.o
/home/bunk/linux/kernel-2.6/linux-2.6.18-rc4-mm3/net/netfilter/nf_conntrack_ftp.c: In function ‘get_ipv6_addr’:
/home/bunk/linux/kernel-2.6/linux-2.6.18-rc4-mm3/net/netfilter/nf_conntrack_ftp.c:117: warning: implicit declaration of function ‘in6_pton’
/home/bunk/linux/kernel-2.6/linux-2.6.18-rc4-mm3/net/netfilter/nf_conntrack_ftp.c:117: error: ‘end’ undeclared (first use in this function)
/home/bunk/linux/kernel-2.6/linux-2.6.18-rc4-mm3/net/netfilter/nf_conntrack_ftp.c:117: error: (Each undeclared identifier is reported only once
/home/bunk/linux/kernel-2.6/linux-2.6.18-rc4-mm3/net/netfilter/nf_conntrack_ftp.c:117: error: for each function it appears in.)
make[3]: *** [net/netfilter/nf_conntrack_ftp.o] Error 1
<-- snip -->
cu
Adrian
--
Gentoo kernels are 42 times more popular than SUSE kernels among
KLive users (a service by SUSE contractor Andrea Arcangeli that
gathers data about kernels from many users worldwide).
There are three kinds of lies: Lies, Damn Lies, and Statistics.
Benjamin Disraeli
^ permalink raw reply [flat|nested] 36+ messages in thread* Re: 2.6.18-rc4-mm3: NF_CONNTRACK_FTP=y compile error
2006-08-27 2:42 ` 2.6.18-rc4-mm3: NF_CONNTRACK_FTP=y compile error Adrian Bunk
@ 2006-08-27 2:49 ` David Miller
0 siblings, 0 replies; 36+ messages in thread
From: David Miller @ 2006-08-27 2:49 UTC (permalink / raw)
To: bunk; +Cc: akpm, yoshfuji, linux-kernel, netdev, coreteam
From: Adrian Bunk <bunk@stusta.de>
Date: Sun, 27 Aug 2006 04:42:19 +0200
> CC net/netfilter/nf_conntrack_ftp.o
> /home/bunk/linux/kernel-2.6/linux-2.6.18-rc4-mm3/net/netfilter/nf_conntrack_ftp.c: In function ^[$,1rx^[(Bget_ipv6_addr^[$,1ry^[(B:
> /home/bunk/linux/kernel-2.6/linux-2.6.18-rc4-mm3/net/netfilter/nf_conntrack_ftp.c:117: warning: implicit declaration of function ^[$,1rx^[(Bin6_pton^[$,1ry^[(B
> /home/bunk/linux/kernel-2.6/linux-2.6.18-rc4-mm3/net/netfilter/nf_conntrack_ftp.c:117: error: ^[$,1rx^[(Bend^[$,1ry^[(B undeclared (first use in this function)
> /home/bunk/linux/kernel-2.6/linux-2.6.18-rc4-mm3/net/netfilter/nf_conntrack_ftp.c:117: error: (Each undeclared identifier is reported only once
> /home/bunk/linux/kernel-2.6/linux-2.6.18-rc4-mm3/net/netfilter/nf_conntrack_ftp.c:117: error: for each function it appears in.)
> make[3]: *** [net/netfilter/nf_conntrack_ftp.o] Error 1
So the one single place where we call this new in6_pton() thing,
it doesn't even compile.
Yoshifuji, what tree are you testing your builds against? This
is the second build failure introduced by this in6_pton()
changeset.
I'm going to butcher it like this so at least it builds.
commit 32677088bc145cf7d45466e39286f1a8c7bf2d67
Author: David S. Miller <davem@sunset.davemloft.net>
Date: Sat Aug 26 19:48:49 2006 -0700
[NETFILTER]: Fix nf_conntrack_ftp.c build.
Noticed by Adrian Bunk.
Signed-off-by: David S. Miller <davem@davemloft.net>
diff --git a/net/netfilter/nf_conntrack_ftp.c b/net/netfilter/nf_conntrack_ftp.c
index 9dccb40..0c17a5b 100644
--- a/net/netfilter/nf_conntrack_ftp.c
+++ b/net/netfilter/nf_conntrack_ftp.c
@@ -21,6 +21,7 @@ #include <linux/netfilter.h>
#include <linux/ip.h>
#include <linux/ipv6.h>
#include <linux/ctype.h>
+#include <linux/inet.h>
#include <net/checksum.h>
#include <net/tcp.h>
@@ -114,7 +115,8 @@ static struct ftp_search {
static int
get_ipv6_addr(const char *src, size_t dlen, struct in6_addr *dst, u_int8_t term)
{
- int ret = in6_pton(src, min_t(size_t, dlen, 0xffff), dst, term, &end);
+ const char *end;
+ int ret = in6_pton(src, min_t(size_t, dlen, 0xffff), (u8 *)dst, term, &end);
if (ret > 0)
return (int)(end - src);
return 0;
^ permalink raw reply related [flat|nested] 36+ messages in thread
* [-mm patch] struct i2c_algo_pcf_data: remove the mdelay member
2006-08-26 23:09 2.6.18-rc4-mm3 Andrew Morton
` (2 preceding siblings ...)
2006-08-27 2:42 ` 2.6.18-rc4-mm3: NF_CONNTRACK_FTP=y compile error Adrian Bunk
@ 2006-08-27 2:47 ` Adrian Bunk
2006-08-27 8:44 ` Jean Delvare
2006-08-27 12:50 ` 2.6.18-rc4-mm3 Benoit Boissinot
` (9 subsequent siblings)
13 siblings, 1 reply; 36+ messages in thread
From: Adrian Bunk @ 2006-08-27 2:47 UTC (permalink / raw)
To: Andrew Morton, Jean Delvare; +Cc: linux-kernel, Greg Kroah-Hartman, i2c
On Sat, Aug 26, 2006 at 04:09:22PM -0700, Andrew Morton wrote:
>...
> Changes since 2.6.18-rc4-mm2:
>...
> +gregkh-i2c-i2c-algo-bit-kill-mdelay.patch
>...
> I2C tree updates
>...
This patch also removes the only usage of the mdelay member in
struct i2c_algo_pcf_data, but doesn't remove the struct member itself.
Is seems this patch was also intended?
Signed-off-by: Adrian Bunk <bunk@stusta.de>
--- linux-2.6.18-rc4-mm3/include/linux/i2c-algo-pcf.h.old 2006-08-27 04:01:35.000000000 +0200
+++ linux-2.6.18-rc4-mm3/include/linux/i2c-algo-pcf.h 2006-08-27 04:01:40.000000000 +0200
@@ -35,7 +35,6 @@ struct i2c_algo_pcf_data {
/* local settings */
int udelay;
- int mdelay;
int timeout;
};
^ permalink raw reply [flat|nested] 36+ messages in thread* Re: [-mm patch] struct i2c_algo_pcf_data: remove the mdelay member
2006-08-27 2:47 ` [-mm patch] struct i2c_algo_pcf_data: remove the mdelay member Adrian Bunk
@ 2006-08-27 8:44 ` Jean Delvare
0 siblings, 0 replies; 36+ messages in thread
From: Jean Delvare @ 2006-08-27 8:44 UTC (permalink / raw)
To: Adrian Bunk; +Cc: Andrew Morton, linux-kernel, Greg Kroah-Hartman, i2c
Hi Adrian,
> On Sat, Aug 26, 2006 at 04:09:22PM -0700, Andrew Morton wrote:
> >...
> > Changes since 2.6.18-rc4-mm2:
> >...
> > +gregkh-i2c-i2c-algo-bit-kill-mdelay.patch
> >...
> > I2C tree updates
> >...
>
> This patch also removes the only usage of the mdelay member in
> struct i2c_algo_pcf_data, but doesn't remove the struct member itself.
>
> Is seems this patch was also intended?
>
> Signed-off-by: Adrian Bunk <bunk@stusta.de>
>
> --- linux-2.6.18-rc4-mm3/include/linux/i2c-algo-pcf.h.old 2006-08-27 04:01:35.000000000 +0200
> +++ linux-2.6.18-rc4-mm3/include/linux/i2c-algo-pcf.h 2006-08-27 04:01:40.000000000 +0200
> @@ -35,7 +35,6 @@ struct i2c_algo_pcf_data {
>
> /* local settings */
> int udelay;
> - int mdelay;
> int timeout;
> };
I removed mdelay from i2c-elektor thinking that it was using
i2c-algo-bit, I didn't realize it was using a different i2c algorithm.
And I didn't know i2c-algo-pcf also had an unused mdelay.
I will send an updated i2c-algo-bit-kill-mdelay.patch to Greg which
doesn't affect i2c-elektor. Then we can stack a second patch doing the
same for i2c-algo-pcf, which will include your change above, and my
change to i2c-elektor.
I agree it doesn't matter much, in the end we end up removing
everything and it was dead code anyway, but let's still have clean
separate patches doing just one thing at a time.
I just found that i2c-algo-ite has the same unused mdelay member in its
algorithm data structure... But I wouldn't bother cleaning it up, given
that it is planed for removal next month anyway.
Thanks,
--
Jean Delvare
^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: 2.6.18-rc4-mm3
2006-08-26 23:09 2.6.18-rc4-mm3 Andrew Morton
` (3 preceding siblings ...)
2006-08-27 2:47 ` [-mm patch] struct i2c_algo_pcf_data: remove the mdelay member Adrian Bunk
@ 2006-08-27 12:50 ` Benoit Boissinot
2006-08-28 7:35 ` 2.6.18-rc4-mm3 Pablo Neira Ayuso
2006-08-27 16:00 ` 2.6.18-rc4-mm3 Benoit Boissinot
` (8 subsequent siblings)
13 siblings, 1 reply; 36+ messages in thread
From: Benoit Boissinot @ 2006-08-27 12:50 UTC (permalink / raw)
To: Andrew Morton; +Cc: linux-kernel, Pablo Neira Ayuso, David S. Miller
On 8/27/06, Andrew Morton <akpm@osdl.org> wrote:
>
> ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.18-rc4/2.6.18-rc4-mm3/
>
> Changes since 2.6.18-rc4-mm2:
>
> git-net.patch
It introduces a new warning for me:
net/netfilter/xt_CONNMARK.c: In function 'target':
net/netfilter/xt_CONNMARK.c:59: warning: implicit declaration of
function 'nf_conntrack_event_cache'
The warning is due to the following .config:
CONFIG_IP_NF_CONNTRACK=m
CONFIG_IP_NF_CONNTRACK_MARK=y
# CONFIG_IP_NF_CONNTRACK_EVENTS is not set
CONFIG_IP_NF_CONNTRACK_NETLINK=m
This change was introduced by:
http://www.kernel.org/git/?p=linux/kernel/git/davem/net-2.6.19.git;a=commit;h=76e4b41009b8a2e9dd246135cf43c7fe39553aa5
Proposed solution (based on the define in
include/net/netfilter/nf_conntrack_compat.h:
Signed-off-by: Benoit Boissinot <benoit.boissinot@ens-lyon.org>
Index: linux/net/netfilter/xt_CONNMARK.c
===================================================================
--- linux.orig/net/netfilter/xt_CONNMARK.c
+++ linux/net/netfilter/xt_CONNMARK.c
@@ -53,7 +53,7 @@ target(struct sk_buff **pskb,
newmark = (*ctmark & ~markinfo->mask) | markinfo->mark;
if (newmark != *ctmark) {
*ctmark = newmark;
-#ifdef CONFIG_IP_NF_CONNTRACK_EVENTS
+#if defined(CONFIG_IP_NF_CONNTRACK) || defined(CONFIG_IP_NF_CONNTRACK_MODULE)
ip_conntrack_event_cache(IPCT_MARK, *pskb);
#else
nf_conntrack_event_cache(IPCT_MARK, *pskb);
@@ -65,7 +65,7 @@ target(struct sk_buff **pskb,
((*pskb)->nfmark & markinfo->mask);
if (*ctmark != newmark) {
*ctmark = newmark;
-#ifdef CONFIG_IP_NF_CONNTRACK_EVENTS
+#if defined(CONFIG_IP_NF_CONNTRACK) || defined(CONFIG_IP_NF_CONNTRACK_MODULE)
ip_conntrack_event_cache(IPCT_MARK, *pskb);
#else
nf_conntrack_event_cache(IPCT_MARK, *pskb);
^ permalink raw reply [flat|nested] 36+ messages in thread* Re: 2.6.18-rc4-mm3
2006-08-26 23:09 2.6.18-rc4-mm3 Andrew Morton
` (4 preceding siblings ...)
2006-08-27 12:50 ` 2.6.18-rc4-mm3 Benoit Boissinot
@ 2006-08-27 16:00 ` Benoit Boissinot
2006-08-28 9:07 ` 2.6.18-rc4-mm3 Mel Gorman
` (7 subsequent siblings)
13 siblings, 0 replies; 36+ messages in thread
From: Benoit Boissinot @ 2006-08-27 16:00 UTC (permalink / raw)
To: Andrew Morton; +Cc: linux-kernel, Venkatesh Pallipadi, Len Brown
On 8/27/06, Andrew Morton <akpm@osdl.org> wrote:
>
> ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.18-rc4/2.6.18-rc4-mm3/
>
> git-acpi.patch
commit f62d31ee2f2f453b07107465fea54540cab418eb broke my laptop
(pentium M, dell D600).
I can reliably get a hard lockup (no sysrq) when modprobing ehci_hcd
and uhci_hci. It works when reverting the changeset.
I can provide cpuinfo or dmesg if necessary.
regards,
Benoit
^ permalink raw reply [flat|nested] 36+ messages in thread* Re: 2.6.18-rc4-mm3
2006-08-26 23:09 2.6.18-rc4-mm3 Andrew Morton
` (5 preceding siblings ...)
2006-08-27 16:00 ` 2.6.18-rc4-mm3 Benoit Boissinot
@ 2006-08-28 9:07 ` Mel Gorman
2006-08-28 18:34 ` 2.6.18-rc4-mm3 Andrew Morton
2006-08-28 20:07 ` divide error: 0000 in fib6_rule_match [Re: 2.6.18-rc4-mm3] Mattia Dongili
` (6 subsequent siblings)
13 siblings, 1 reply; 36+ messages in thread
From: Mel Gorman @ 2006-08-28 9:07 UTC (permalink / raw)
To: Andrew Morton; +Cc: linux-kernel
On (26/08/06 16:09), Andrew Morton didst pronounce:
>
> ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.18-rc4/2.6.18-rc4-mm3/
>
This failed to build on two x86_64 machines I have access to with (one
on test.kernel.org);
OBJCOPY arch/x86_64/boot/compressed/vmlinux.bin
BFD: Warning: Writing section `.data.percpu' to huge (ie negative)
file offset 0x80471000.
/usr/local/autobench/sources/x86_64-cross/gcc-3.4.0-glibc-2.3.2/bin/x86_64-unknown-linux-gnu-objcopy:
arch/x86_64/boot/compressed/vmlinux.bin: File truncated
make[2]: *** [arch/x86_64/boot/compressed/vmlinux.bin] Error 1
make[1]: *** [arch/x86_64/boot/compressed/vmlinux] Error 2
make: *** [bzImage] Error 2
08/26/06-17:16:14 Build the kernel. Failed rc = 2
08/26/06-17:16:14 build: kernel build Failed rc = 1
08/26/06-17:16:14 command complete: (2) rc=126
Failed and terminated the run
Fatal error, aborting autorun
CONFIG_NR_CPUS was 8. The build log can be seen at
http://test.kernel.org/abat/45342/debug/test.log.0 and the .config is at
http://test.kernel.org/abat/45342/build/dotconfig . I haven't done any
further investigation in case this is a known problem. If it's new, I'll
start digging.
--
Mel Gorman
Part-time Phd Student Linux Technology Center
University of Limerick IBM Dublin Software Lab
^ permalink raw reply [flat|nested] 36+ messages in thread* Re: 2.6.18-rc4-mm3
2006-08-28 9:07 ` 2.6.18-rc4-mm3 Mel Gorman
@ 2006-08-28 18:34 ` Andrew Morton
2006-08-29 14:44 ` 2.6.18-rc4-mm3 Mel Gorman
0 siblings, 1 reply; 36+ messages in thread
From: Andrew Morton @ 2006-08-28 18:34 UTC (permalink / raw)
To: Mel Gorman; +Cc: linux-kernel
On Mon, 28 Aug 2006 10:07:54 +0100
mel@skynet.ie (Mel Gorman) wrote:
> On (26/08/06 16:09), Andrew Morton didst pronounce:
> >
> > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.18-rc4/2.6.18-rc4-mm3/
> >
>
> This failed to build on two x86_64 machines I have access to with (one
> on test.kernel.org);
>
> OBJCOPY arch/x86_64/boot/compressed/vmlinux.bin
> BFD: Warning: Writing section `.data.percpu' to huge (ie negative)
> file offset 0x80471000.
> /usr/local/autobench/sources/x86_64-cross/gcc-3.4.0-glibc-2.3.2/bin/x86_64-unknown-linux-gnu-objcopy:
> arch/x86_64/boot/compressed/vmlinux.bin: File truncated
> make[2]: *** [arch/x86_64/boot/compressed/vmlinux.bin] Error 1
> make[1]: *** [arch/x86_64/boot/compressed/vmlinux] Error 2
> make: *** [bzImage] Error 2
> 08/26/06-17:16:14 Build the kernel. Failed rc = 2
> 08/26/06-17:16:14 build: kernel build Failed rc = 1
> 08/26/06-17:16:14 command complete: (2) rc=126
> Failed and terminated the run
> Fatal error, aborting autorun
>
> CONFIG_NR_CPUS was 8. The build log can be seen at
> http://test.kernel.org/abat/45342/debug/test.log.0 and the .config is at
> http://test.kernel.org/abat/45342/build/dotconfig . I haven't done any
> further investigation in case this is a known problem. If it's new, I'll
> start digging.
>
hm. It works for me.
BINUTILS_DIR=binutils-2.16.1
GCC_DIR=gcc-4.0.2
GLIBC_DIR=glibc-2.3.6
I guess one could poke around in vmlinux, find out what's happened to the
.data.percpu section. `readelf --sections vmlinux', etc?
^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: 2.6.18-rc4-mm3
2006-08-28 18:34 ` 2.6.18-rc4-mm3 Andrew Morton
@ 2006-08-29 14:44 ` Mel Gorman
0 siblings, 0 replies; 36+ messages in thread
From: Mel Gorman @ 2006-08-29 14:44 UTC (permalink / raw)
To: Andrew Morton; +Cc: Linux Kernel Mailing List
On Mon, 28 Aug 2006, Andrew Morton wrote:
> On Mon, 28 Aug 2006 10:07:54 +0100
> mel@skynet.ie (Mel Gorman) wrote:
>
>> On (26/08/06 16:09), Andrew Morton didst pronounce:
>>>
>>> ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.18-rc4/2.6.18-rc4-mm3/
>>>
>>
>> This failed to build on two x86_64 machines I have access to with (one
>> on test.kernel.org);
>>
>> OBJCOPY arch/x86_64/boot/compressed/vmlinux.bin
>> BFD: Warning: Writing section `.data.percpu' to huge (ie negative)
>> file offset 0x80471000.
>> /usr/local/autobench/sources/x86_64-cross/gcc-3.4.0-glibc-2.3.2/bin/x86_64-unknown-linux-gnu-objcopy:
>> arch/x86_64/boot/compressed/vmlinux.bin: File truncated
>> make[2]: *** [arch/x86_64/boot/compressed/vmlinux.bin] Error 1
>> make[1]: *** [arch/x86_64/boot/compressed/vmlinux] Error 2
>> make: *** [bzImage] Error 2
>> 08/26/06-17:16:14 Build the kernel. Failed rc = 2
>> 08/26/06-17:16:14 build: kernel build Failed rc = 1
>> 08/26/06-17:16:14 command complete: (2) rc=126
>> Failed and terminated the run
>> Fatal error, aborting autorun
>>
>> CONFIG_NR_CPUS was 8. The build log can be seen at
>> http://test.kernel.org/abat/45342/debug/test.log.0 and the .config is at
>> http://test.kernel.org/abat/45342/build/dotconfig . I haven't done any
>> further investigation in case this is a known problem. If it's new, I'll
>> start digging.
>>
>
> hm. It works for me.
>
> BINUTILS_DIR=binutils-2.16.1
> GCC_DIR=gcc-4.0.2
> GLIBC_DIR=glibc-2.3.6
>
> I guess one could poke around in vmlinux, find out what's happened to the
> .data.percpu section. `readelf --sections vmlinux', etc?
There didn't seem to be anything unusual about the .data.percpu section It
turned out to be a binutils version problem. On the two test machines, the
cross-compiler from
http://developer.osdl.org/dev/plm/cross_compile/x86_64-unknown-linux-gnu.tar.bz2
was being used. When later versions were used, the problem disappeared.
Thanks
--
Mel Gorman
Part-time Phd Student Linux Technology Center
University of Limerick IBM Dublin Software Lab
^ permalink raw reply [flat|nested] 36+ messages in thread
* divide error: 0000 in fib6_rule_match [Re: 2.6.18-rc4-mm3]
2006-08-26 23:09 2.6.18-rc4-mm3 Andrew Morton
` (6 preceding siblings ...)
2006-08-28 9:07 ` 2.6.18-rc4-mm3 Mel Gorman
@ 2006-08-28 20:07 ` Mattia Dongili
2006-08-28 20:28 ` Andrew Morton
2006-08-28 21:30 ` Andrew Morton
2006-08-28 20:24 ` one more ACPI Error (utglobal-0125): Unknown exception code: 0xFFFFFFEA " Mattia Dongili
` (5 subsequent siblings)
13 siblings, 2 replies; 36+ messages in thread
From: Mattia Dongili @ 2006-08-28 20:07 UTC (permalink / raw)
To: Andrew Morton; +Cc: linux-kernel, davem, netdev
On Sat, Aug 26, 2006 at 04:09:22PM -0700, Andrew Morton wrote:
>
> ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.18-rc4/2.6.18-rc4-mm3/
[...]
> git-net.patch
got this one when starting sshd:
[ 44.412000] divide error: 0000 [#1]
[ 44.412000] 4K_STACKS PREEMPT
[ 44.412000] last sysfs file: /devices/system/cpu/cpu0/cpufreq/ondemand/ignore_nice_load
[ 44.412000] Modules linked in: nfsd exportfs lockd sunrpc ipt_MASQUERADE iptable_nat ip_nat xt_tcpudp xt_state ip_conntrack iptable_filter ip_tables x_tables ipv6 jfs aes dm_crypt dm_mod rtc sony_acpi tun psmouse sonypi speedstep_ich speedstep_lib cpufreq_conservative cpufreq_ondemand freq_table cpufreq_powersave sd_mod usb_storage scsi_mod usbhid pcmcia snd_intel8x0 snd_ac97_codec snd_ac97_bus snd_pcm_oss snd_mixer_oss snd_pcm snd_timer intel_agp agpgart i2c_i801 snd soundcore snd_page_alloc yenta_socket rsrc_nonstatic pcmcia_core uhci_hcd usbcore evdev e100 mii pcspkr
[ 44.412000] CPU: 0
[ 44.412000] EIP: 0060:[<d1516aca>] Not tainted VLI
[ 44.412000] EFLAGS: 00210246 (2.6.18-rc4-mm3-1 #6)
[ 44.412000] EIP is at fib6_rule_match+0x7a/0x150 [ipv6]
[ 44.412000] eax: 00000000 ebx: cd9d4e30 ecx: d15290e0 edx: 00000000
[ 44.412000] esi: cd7d9e08 edi: cd9d4e30 ebp: cd9d4d34 esp: cd9d4d0c
[ 44.412000] ds: 007b es: 007b ss: 0068
[ 44.412000] Process sshd (pid: 3780, ti=cd9d4000 task=cf131590 task.ti=cd9d4000)
[ 44.412000] Stack: 00000003 c018b200 00000000 ced9df60 cd9d4d6c 00000000 ced9df60 d15290e0
[ 44.412000] cd7d9e08 cd9d4e30 cd9d4d58 c02c198e d15290e0 cd9d4e30 00000000 c123f380
[ 44.412000] cd9d4e30 cd7d9e08 cd9d4e30 cd9d4d80 d15169dc d15290a0 cd9d4e30 00000000
[ 44.412000] Call Trace:
[ 44.412000] [<c02c198e>] fib_rules_lookup+0x5e/0xe0
[ 44.412000] [<d15169dc>] fib6_rule_lookup+0x3c/0xb0 [ipv6]
[ 44.412000] [<d14f8702>] ip6_route_output+0x32/0x40 [ipv6]
[ 44.412000] [<d14ed155>] ip6_dst_lookup_tail+0x95/0xd0 [ipv6]
[ 44.412000] [<d14ed1a7>] ip6_dst_lookup+0x17/0x20 [ipv6]
[ 44.412000] [<d15120ce>] ip6_datagram_connect+0x36e/0x6c0 [ipv6]
[ 44.412000] [<c02f6829>] inet_dgram_connect+0x39/0x80
[ 44.412000] [<c02a6ceb>] sys_connect+0x6b/0x90
[ 44.412000] [<c02a846f>] sys_socketcall+0x9f/0x260
[ 44.412000] [<c010325b>] syscall_call+0x7/0xb
[ 44.412000] [<b7c7c93c>] 0xb7c7c93c
[ 44.412000] =======================
[ 44.412000] Code: 00 00 00 89 d8 83 e0 1f 0f 85 9a 00 00 00 8b 5d 08 0f b6 53 68 84 d2 75 78 8b 55 08 8b 5d 0c 8b 4a 60 8b 43 28 31 c8 89 d1 31 d2 <f7> 71 64 85 c0 0f 94 c0 0f b6 c0 8b 5d f4 8b 75 f8 8b 7d fc 89
[ 44.412000] EIP: [<d1516aca>] fib6_rule_match+0x7a/0x150 [ipv6] SS:ESP 0068:cd9d4d0c
[ 44.412000] <6>note: sshd[3780] exited with preempt_count 1
config and full dmesg:
http://oioio.altervista.org/linux/config-2.6.18-rc4-mm3-1
http://oioio.altervista.org/linux/dmesg-2.6.18-rc4-mm3-1
it's at fib6_rules.c:132 but since I can't tell why r->fwmask is 0 I'll
avoid proposing a wrong patch :)
--
mattia
:wq!
^ permalink raw reply [flat|nested] 36+ messages in thread* Re: divide error: 0000 in fib6_rule_match [Re: 2.6.18-rc4-mm3]
2006-08-28 20:07 ` divide error: 0000 in fib6_rule_match [Re: 2.6.18-rc4-mm3] Mattia Dongili
@ 2006-08-28 20:28 ` Andrew Morton
2006-08-28 21:22 ` Andi Kleen
2006-08-28 21:30 ` Andrew Morton
1 sibling, 1 reply; 36+ messages in thread
From: Andrew Morton @ 2006-08-28 20:28 UTC (permalink / raw)
To: Mattia Dongili; +Cc: linux-kernel, davem, netdev
On Mon, 28 Aug 2006 22:07:16 +0200
Mattia Dongili <malattia@linux.it> wrote:
> On Sat, Aug 26, 2006 at 04:09:22PM -0700, Andrew Morton wrote:
> >
> > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.18-rc4/2.6.18-rc4-mm3/
> [...]
> > git-net.patch
>
> got this one when starting sshd:
>
> [ 44.412000] divide error: 0000 [#1]
> [ 44.412000] 4K_STACKS PREEMPT
> [ 44.412000] last sysfs file: /devices/system/cpu/cpu0/cpufreq/ondemand/ignore_nice_load
> [ 44.412000] Modules linked in: nfsd exportfs lockd sunrpc ipt_MASQUERADE iptable_nat ip_nat xt_tcpudp xt_state ip_conntrack iptable_filter ip_tables x_tables ipv6 jfs aes dm_crypt dm_mod rtc sony_acpi tun psmouse sonypi speedstep_ich speedstep_lib cpufreq_conservative cpufreq_ondemand freq_table cpufreq_powersave sd_mod usb_storage scsi_mod usbhid pcmcia snd_intel8x0 snd_ac97_codec snd_ac97_bus snd_pcm_oss snd_mixer_oss snd_pcm snd_timer intel_agp agpgart i2c_i801 snd soundcore snd_page_alloc yenta_socket rsrc_nonstatic pcmcia_core uhci_hcd usbcore evdev e100 mii pcspkr
> [ 44.412000] CPU: 0
> [ 44.412000] EIP: 0060:[<d1516aca>] Not tainted VLI
> [ 44.412000] EFLAGS: 00210246 (2.6.18-rc4-mm3-1 #6)
> [ 44.412000] EIP is at fib6_rule_match+0x7a/0x150 [ipv6]
> [ 44.412000] eax: 00000000 ebx: cd9d4e30 ecx: d15290e0 edx: 00000000
> [ 44.412000] esi: cd7d9e08 edi: cd9d4e30 ebp: cd9d4d34 esp: cd9d4d0c
> [ 44.412000] ds: 007b es: 007b ss: 0068
> [ 44.412000] Process sshd (pid: 3780, ti=cd9d4000 task=cf131590 task.ti=cd9d4000)
> [ 44.412000] Stack: 00000003 c018b200 00000000 ced9df60 cd9d4d6c 00000000 ced9df60 d15290e0
> [ 44.412000] cd7d9e08 cd9d4e30 cd9d4d58 c02c198e d15290e0 cd9d4e30 00000000 c123f380
> [ 44.412000] cd9d4e30 cd7d9e08 cd9d4e30 cd9d4d80 d15169dc d15290a0 cd9d4e30 00000000
> [ 44.412000] Call Trace:
> [ 44.412000] [<c02c198e>] fib_rules_lookup+0x5e/0xe0
> [ 44.412000] [<d15169dc>] fib6_rule_lookup+0x3c/0xb0 [ipv6]
> [ 44.412000] [<d14f8702>] ip6_route_output+0x32/0x40 [ipv6]
> [ 44.412000] [<d14ed155>] ip6_dst_lookup_tail+0x95/0xd0 [ipv6]
> [ 44.412000] [<d14ed1a7>] ip6_dst_lookup+0x17/0x20 [ipv6]
> [ 44.412000] [<d15120ce>] ip6_datagram_connect+0x36e/0x6c0 [ipv6]
> [ 44.412000] [<c02f6829>] inet_dgram_connect+0x39/0x80
> [ 44.412000] [<c02a6ceb>] sys_connect+0x6b/0x90
> [ 44.412000] [<c02a846f>] sys_socketcall+0x9f/0x260
> [ 44.412000] [<c010325b>] syscall_call+0x7/0xb
> [ 44.412000] [<b7c7c93c>] 0xb7c7c93c
> [ 44.412000] =======================
> [ 44.412000] Code: 00 00 00 89 d8 83 e0 1f 0f 85 9a 00 00 00 8b 5d 08 0f b6 53 68 84 d2 75 78 8b 55 08 8b 5d 0c 8b 4a 60 8b 43 28 31 c8 89 d1 31 d2 <f7> 71 64 85 c0 0f 94 c0 0f b6 c0 8b 5d f4 8b 75 f8 8b 7d fc 89
> [ 44.412000] EIP: [<d1516aca>] fib6_rule_match+0x7a/0x150 [ipv6] SS:ESP 0068:cd9d4d0c
I cannot work out how the heck you got a divide instruction in
fib6_rule_match().
Can you please do `make net/ipv6/fib6_rules.s', find the code which
implements fib6_rule_match() (line starting with "fib6_rule_match:") and
send that plus the next 200-odd lines? Or just stick fib6_rules.s on a
server somewhere? Or mail me fib6_rules.s off-list.
Thanks.
^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: divide error: 0000 in fib6_rule_match [Re: 2.6.18-rc4-mm3]
2006-08-28 20:28 ` Andrew Morton
@ 2006-08-28 21:22 ` Andi Kleen
0 siblings, 0 replies; 36+ messages in thread
From: Andi Kleen @ 2006-08-28 21:22 UTC (permalink / raw)
To: Andrew Morton; +Cc: Mattia Dongili, linux-kernel, davem, netdev
> I cannot work out how the heck you got a divide instruction in
> fib6_rule_match().
This might be another symptom of the broken smp-alternatives patch.
It tended to randomly corrupt some instructions by inserting different
bytes which then crash in interesting ways.
I already sent a fix for that, but it's not in yet.
-Andi
^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: divide error: 0000 in fib6_rule_match [Re: 2.6.18-rc4-mm3]
2006-08-28 20:07 ` divide error: 0000 in fib6_rule_match [Re: 2.6.18-rc4-mm3] Mattia Dongili
2006-08-28 20:28 ` Andrew Morton
@ 2006-08-28 21:30 ` Andrew Morton
2006-08-28 21:51 ` divide error: 0000 in fib6_rule_match David Miller
2006-08-29 6:33 ` divide error: 0000 in fib6_rule_match [Re: 2.6.18-rc4-mm3] Mattia Dongili
1 sibling, 2 replies; 36+ messages in thread
From: Andrew Morton @ 2006-08-28 21:30 UTC (permalink / raw)
To: Mattia Dongili; +Cc: linux-kernel, davem, netdev
On Mon, 28 Aug 2006 22:07:16 +0200
Mattia Dongili <malattia@linux.it> wrote:
> [ 44.412000] =======================
> [ 44.412000] Code: 00 00 00 89 d8 83 e0 1f 0f 85 9a 00 00 00 8b 5d 08 0f b6 53 68 84 d2 75 78 8b 55 08 8b 5d 0c 8b 4a 60 8b 43 28 31 c8 89 d1 31 d2 <f7> 71 64 85 c0 0f 94 c0 0f b6 c0 8b 5d f4 8b 75 f8 8b 7d fc 89
> [ 44.412000] EIP: [<d1516aca>] fib6_rule_match+0x7a/0x150 [ipv6] SS:ESP 0068:cd9d4d0c
> [ 44.412000] <6>note: sshd[3780] exited with preempt_count 1
>
> config and full dmesg:
> http://oioio.altervista.org/linux/config-2.6.18-rc4-mm3-1
> http://oioio.altervista.org/linux/dmesg-2.6.18-rc4-mm3-1
>
> it's at fib6_rules.c:132 but since I can't tell why r->fwmask is 0 I'll
> avoid proposing a wrong patch :)
Oh. It looks like this has already been fixed:
#ifdef CONFIG_IPV6_ROUTE_FWMARK
if ((r->fwmark ^ fl->fl6_fwmark) & r->fwmask)
return 0;
#endif
there's no divide in there now.
^ permalink raw reply [flat|nested] 36+ messages in thread* Re: divide error: 0000 in fib6_rule_match
2006-08-28 21:30 ` Andrew Morton
@ 2006-08-28 21:51 ` David Miller
2006-08-29 6:33 ` divide error: 0000 in fib6_rule_match [Re: 2.6.18-rc4-mm3] Mattia Dongili
1 sibling, 0 replies; 36+ messages in thread
From: David Miller @ 2006-08-28 21:51 UTC (permalink / raw)
To: akpm; +Cc: malattia, linux-kernel, netdev
From: Andrew Morton <akpm@osdl.org>
Date: Mon, 28 Aug 2006 14:30:03 -0700
> Oh. It looks like this has already been fixed:
>
> #ifdef CONFIG_IPV6_ROUTE_FWMARK
> if ((r->fwmark ^ fl->fl6_fwmark) & r->fwmask)
> return 0;
> #endif
>
> there's no divide in there now.
That's right there used to be a typo there.
^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: divide error: 0000 in fib6_rule_match [Re: 2.6.18-rc4-mm3]
2006-08-28 21:30 ` Andrew Morton
2006-08-28 21:51 ` divide error: 0000 in fib6_rule_match David Miller
@ 2006-08-29 6:33 ` Mattia Dongili
1 sibling, 0 replies; 36+ messages in thread
From: Mattia Dongili @ 2006-08-29 6:33 UTC (permalink / raw)
To: Andrew Morton; +Cc: Mattia Dongili, linux-kernel, davem, netdev
On Mon, August 28, 2006 11:30 pm, Andrew Morton said:
> On Mon, 28 Aug 2006 22:07:16 +0200
> Mattia Dongili <malattia@linux.it> wrote:
[...]
>> it's at fib6_rules.c:132 but since I can't tell why r->fwmask is 0 I'll
>> avoid proposing a wrong patch :)
>
> Oh. It looks like this has already been fixed:
>
> #ifdef CONFIG_IPV6_ROUTE_FWMARK
> if ((r->fwmark ^ fl->fl6_fwmark) & r->fwmask)
> return 0;
> #endif
>
> there's no divide in there now.
Ok, great, I have a division instead of the bitwise and there in fact.
thanks
--
mattia
:wq!
^ permalink raw reply [flat|nested] 36+ messages in thread
* one more ACPI Error (utglobal-0125): Unknown exception code: 0xFFFFFFEA [Re: 2.6.18-rc4-mm3]
2006-08-26 23:09 2.6.18-rc4-mm3 Andrew Morton
` (7 preceding siblings ...)
2006-08-28 20:07 ` divide error: 0000 in fib6_rule_match [Re: 2.6.18-rc4-mm3] Mattia Dongili
@ 2006-08-28 20:24 ` Mattia Dongili
2006-08-28 22:16 ` 2.6.18-rc4-mm3 Rafael J. Wysocki
` (4 subsequent siblings)
13 siblings, 0 replies; 36+ messages in thread
From: Mattia Dongili @ 2006-08-28 20:24 UTC (permalink / raw)
To: Andrew Morton; +Cc: linux-kernel, linux-acpi
On Sat, Aug 26, 2006 at 04:09:22PM -0700, Andrew Morton wrote:
>
> ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.18-rc4/2.6.18-rc4-mm3/
[...]
> git-acpi.patch
Sorry for reporting separately, I deleted the other thread on the issue.
Here we go:
[ 9.386644] PCI: Using ACPI for IRQ routing
[ 9.386688] PCI: If a device doesn't work, try "pci=routeirq". If it helps, post a report
[ 9.391209] ACPI Error (utglobal-0125): Unknown exception code: 0xFFFFFFEA [20060707]
[ 9.391521] [<c0103a9f>] dump_trace+0x1ef/0x230
[ 9.391626] [<c0103b06>] show_trace_log_lvl+0x26/0x40
[ 9.391724] [<c01042bb>] show_trace+0x1b/0x20
[ 9.391820] [<c01043a4>] dump_stack+0x24/0x30
[ 9.391918] [<c0249f15>] acpi_format_exception+0xa3/0xb0
[ 9.392729] [<c0246fb6>] acpi_ut_status_exit+0x31/0x5e
[ 9.393453] [<c0243352>] acpi_walk_resources+0x10e/0x11b
[ 9.394174] [<c025697e>] acpi_motherboard_add+0x22/0x31
[ 9.394977] [<c0255890>] acpi_bus_driver_init+0x2b/0x7c
[ 9.395742] [<c02568da>] acpi_bus_register_driver+0xa1/0x123
[ 9.396507] [<c0418adb>] acpi_motherboard_init+0x17/0xfb
[ 9.397268] [<c01003d0>] init+0x80/0x290
[ 9.397343] [<c0103593>] kernel_thread_helper+0x7/0x14
[ 9.397439] =======================
full dmesg: http://oioio.altervista.org/linux/dmesg-2.6.18-rc4-mm3-1
config: http://oioio.altervista.org/linux/config-2.6.18-rc4-mm3-1
DSDT: http://oioio.altervista.org/linux/DSDT.aml
http://oioio.altervista.org/linux/DSDT.dsl
lspci: http://oioio.altervista.org/linux/lspci-v
--
mattia
:wq!
^ permalink raw reply [flat|nested] 36+ messages in thread* Re: 2.6.18-rc4-mm3
2006-08-26 23:09 2.6.18-rc4-mm3 Andrew Morton
` (8 preceding siblings ...)
2006-08-28 20:24 ` one more ACPI Error (utglobal-0125): Unknown exception code: 0xFFFFFFEA " Mattia Dongili
@ 2006-08-28 22:16 ` Rafael J. Wysocki
2006-08-29 13:37 ` 2.6.18-rc4-mm3 Haavard Skinnemoen
` (3 subsequent siblings)
13 siblings, 0 replies; 36+ messages in thread
From: Rafael J. Wysocki @ 2006-08-28 22:16 UTC (permalink / raw)
To: Andrew Morton; +Cc: linux-kernel, Ingo Molnar
On Sunday 27 August 2006 01:09, Andrew Morton wrote:
>
> ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.18-rc4/2.6.18-rc4-mm3/
I get things like the appended one on a regular basis at the system startup.
IIRC it has been reported for one of the previous -mm kernels, but it's still
there.
Adding 2104504k swap on /dev/hdc3. Priority:-1 extents:1 across:2104504k
skge eth0: enabling interface
BUG: MAX_STACK_TRACE_ENTRIES too low!
turning off the locking correctness validator.
Call Trace:
[<ffffffff8020b119>] dump_trace+0xb9/0x3d0
[<ffffffff8020b473>] show_trace+0x43/0x60
[<ffffffff8020b785>] dump_stack+0x15/0x20
[<ffffffff802489a6>] save_trace+0xd6/0xf0
[<ffffffff80248ad1>] add_lock_to_list+0x91/0xc0
[<ffffffff8024ad31>] __lock_acquire+0xb01/0xd30
[<ffffffff8024b2fb>] lock_acquire+0x8b/0xc0
[<ffffffff80475b05>] _spin_lock_irq+0x35/0x50
[<ffffffff80472aec>] schedule+0x16c/0x5ef
[<ffffffff804734b7>] preempt_schedule_irq+0x57/0x90
[<ffffffff8020a3f6>] retint_kernel+0x26/0x30
[<ffffffff804740fb>] __mutex_lock_slowpath+0x23b/0x270
[<ffffffff80474139>] mutex_lock+0x9/0x10
[<ffffffff8821801a>] :snd_seq_device:snd_seq_device_info+0x1a/0xd0
[<ffffffff8806be5e>] :snd:snd_info_entry_open+0x27e/0x360
[<ffffffff8028d19c>] __dentry_open+0x13c/0x290
[<ffffffff8028d39d>] nameidata_to_filp+0x2d/0x50
[<ffffffff8028d3fd>] do_filp_open+0x3d/0x50
[<ffffffff8028d46a>] do_sys_open+0x5a/0xf0
[<ffffffff8028d52b>] sys_open+0x1b/0x20
[<ffffffff80209d2e>] system_call+0x7e/0x83
[<00002ab9c19f1722>]
[<ffffffff802489a6>] save_trace+0xd6/0xf0
[<ffffffff80248ad1>] add_lock_to_list+0x91/0xc0
[<ffffffff8024ad31>] __lock_acquire+0xb01/0xd30
[<ffffffff80472aec>] schedule+0x16c/0x5ef
[<ffffffff8024b2fb>] lock_acquire+0x8b/0xc0
[<ffffffff80472aec>] schedule+0x16c/0x5ef
[<ffffffff80475b05>] _spin_lock_irq+0x35/0x50
[<ffffffff80472aec>] schedule+0x16c/0x5ef
[<ffffffff8024b3a9>] mark_held_locks+0x79/0xa0
[<ffffffff804734b1>] preempt_schedule_irq+0x51/0x90
[<ffffffff804734b7>] preempt_schedule_irq+0x57/0x90
[<ffffffff8020a3f6>] retint_kernel+0x26/0x30
[<ffffffff804740fb>] __mutex_lock_slowpath+0x23b/0x270
[<ffffffff8047411d>] __mutex_lock_slowpath+0x25d/0x270
[<ffffffff80474139>] mutex_lock+0x9/0x10
[<ffffffff8821801a>] :snd_seq_device:snd_seq_device_info+0x1a/0xd0
[<ffffffff8806be5e>] :snd:snd_info_entry_open+0x27e/0x360
[<ffffffff8806bbe0>] :snd:snd_info_entry_open+0x0/0x360
[<ffffffff8028d19c>] __dentry_open+0x13c/0x290
[<ffffffff8028d39d>] nameidata_to_filp+0x2d/0x50
[<ffffffff8028d3fd>] do_filp_open+0x3d/0x50
[<ffffffff80475960>] _spin_unlock+0x30/0x60
[<ffffffff8028cb58>] get_unused_fd+0xf8/0x110
[<ffffffff803581fa>] strncpy_from_user+0x3a/0x50
[<ffffffff8028d46a>] do_sys_open+0x5a/0xf0
[<ffffffff8028d52b>] sys_open+0x1b/0x20
[<ffffffff80209d2e>] system_call+0x7e/0x83
NET: Registered protocol family 17
^ permalink raw reply [flat|nested] 36+ messages in thread* Re: 2.6.18-rc4-mm3
2006-08-26 23:09 2.6.18-rc4-mm3 Andrew Morton
` (9 preceding siblings ...)
2006-08-28 22:16 ` 2.6.18-rc4-mm3 Rafael J. Wysocki
@ 2006-08-29 13:37 ` Haavard Skinnemoen
2006-08-29 15:18 ` 2.6.18-rc4-mm3 Cedric Le Goater
2006-08-30 20:35 ` [-mm patch] net/sched/act_simple.c: make struct simp_hash_info static Adrian Bunk
` (2 subsequent siblings)
13 siblings, 1 reply; 36+ messages in thread
From: Haavard Skinnemoen @ 2006-08-29 13:37 UTC (permalink / raw)
To: Andrew Morton; +Cc: linux-kernel
On Sat, 26 Aug 2006 16:09:22 -0700
Andrew Morton <akpm@osdl.org> wrote:
> +namespaces-add-nsproxy-move-init_nsproxy-into-kernel-nsproxyc.patch
This causes a multiple definition of init_nsproxy on AVR32. Reverting
namespaces-add-nsproxy-avr32-fix.patch fixes it.
Haavard
^ permalink raw reply [flat|nested] 36+ messages in thread* Re: 2.6.18-rc4-mm3
2006-08-29 13:37 ` 2.6.18-rc4-mm3 Haavard Skinnemoen
@ 2006-08-29 15:18 ` Cedric Le Goater
2006-08-29 15:42 ` 2.6.18-rc4-mm3 Haavard Skinnemoen
0 siblings, 1 reply; 36+ messages in thread
From: Cedric Le Goater @ 2006-08-29 15:18 UTC (permalink / raw)
To: Haavard Skinnemoen; +Cc: Andrew Morton, linux-kernel, Serge E. Hallyn
Haavard Skinnemoen wrote:
> On Sat, 26 Aug 2006 16:09:22 -0700
> Andrew Morton <akpm@osdl.org> wrote:
>
>> +namespaces-add-nsproxy-move-init_nsproxy-into-kernel-nsproxyc.patch
>
> This causes a multiple definition of init_nsproxy on AVR32. Reverting
> namespaces-add-nsproxy-avr32-fix.patch fixes it.
Could you try this ?
thanks,
C.
Signed-off-by: Cedric Le Goater <clg@fr.ibm.com>
---
arch/avr32/kernel/init_task.c | 2 --
1 file changed, 2 deletions(-)
Index: 2.6.18-rc4-mm3/arch/avr32/kernel/init_task.c
===================================================================
--- 2.6.18-rc4-mm3.orig/arch/avr32/kernel/init_task.c
+++ 2.6.18-rc4-mm3/arch/avr32/kernel/init_task.c
@@ -10,7 +10,6 @@
#include <linux/sched.h>
#include <linux/init_task.h>
#include <linux/mqueue.h>
-#include <linux/nsproxy.h>
#include <asm/pgtable.h>
@@ -19,7 +18,6 @@ static struct files_struct init_files =
static struct signal_struct init_signals = INIT_SIGNALS(init_signals);
static struct sighand_struct init_sighand = INIT_SIGHAND(init_sighand);
struct mm_struct init_mm = INIT_MM(init_mm);
-struct nsproxy init_nsproxy = INIT_NSPROXY(init_nsproxy);
EXPORT_SYMBOL(init_mm);
^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: 2.6.18-rc4-mm3
2006-08-29 15:18 ` 2.6.18-rc4-mm3 Cedric Le Goater
@ 2006-08-29 15:42 ` Haavard Skinnemoen
0 siblings, 0 replies; 36+ messages in thread
From: Haavard Skinnemoen @ 2006-08-29 15:42 UTC (permalink / raw)
To: Cedric Le Goater; +Cc: Andrew Morton, linux-kernel, Serge E. Hallyn
On Tue, 29 Aug 2006 17:18:58 +0200
Cedric Le Goater <clg@fr.ibm.com> wrote:
> Haavard Skinnemoen wrote:
> > On Sat, 26 Aug 2006 16:09:22 -0700
> > Andrew Morton <akpm@osdl.org> wrote:
> >
> >> +namespaces-add-nsproxy-move-init_nsproxy-into-kernel-nsproxyc.patch
> >
> > This causes a multiple definition of init_nsproxy on AVR32.
> > Reverting namespaces-add-nsproxy-avr32-fix.patch fixes it.
>
> Could you try this ?
Yes, this works fine. This does in fact revert
namespaces-add-nsproxy-avr32-fix.patch, so it would work equally well
to just drop that patch.
Thanks,
Haavard
^ permalink raw reply [flat|nested] 36+ messages in thread
* [-mm patch] net/sched/act_simple.c: make struct simp_hash_info static
2006-08-26 23:09 2.6.18-rc4-mm3 Andrew Morton
` (10 preceding siblings ...)
2006-08-29 13:37 ` 2.6.18-rc4-mm3 Haavard Skinnemoen
@ 2006-08-30 20:35 ` Adrian Bunk
2006-08-30 22:03 ` David Miller
2006-08-30 20:35 ` [-mm patch] drivers/input/misc/wistron_btns.c: fix section mismatch Adrian Bunk
2006-08-30 20:35 ` [-mm patch] improve SECURITY_SELINUX_POLICYDB_VERSION_MAX{,_VALUE} help texts Adrian Bunk
13 siblings, 1 reply; 36+ messages in thread
From: Adrian Bunk @ 2006-08-30 20:35 UTC (permalink / raw)
To: Andrew Morton, davem; +Cc: linux-kernel, netdev
On Sat, Aug 26, 2006 at 04:09:22PM -0700, Andrew Morton wrote:
>...
> Changes since 2.6.18-rc4-mm2:
>...
> git-net.patch
>...
> git trees
>...
This patch makes the needlessly global struct simp_hash_info static.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
--- linux-2.6.18-rc4-mm3/net/sched/act_simple.c.old 2006-08-30 20:54:20.000000000 +0200
+++ linux-2.6.18-rc4-mm3/net/sched/act_simple.c 2006-08-30 20:54:43.000000000 +0200
@@ -28,7 +28,7 @@
static u32 simp_idx_gen;
static DEFINE_RWLOCK(simp_lock);
-struct tcf_hashinfo simp_hash_info = {
+static struct tcf_hashinfo simp_hash_info = {
.htab = tcf_simp_ht,
.hmask = SIMP_TAB_MASK,
.lock = &simp_lock,
^ permalink raw reply [flat|nested] 36+ messages in thread* [-mm patch] drivers/input/misc/wistron_btns.c: fix section mismatch
2006-08-26 23:09 2.6.18-rc4-mm3 Andrew Morton
` (11 preceding siblings ...)
2006-08-30 20:35 ` [-mm patch] net/sched/act_simple.c: make struct simp_hash_info static Adrian Bunk
@ 2006-08-30 20:35 ` Adrian Bunk
2006-08-30 23:26 ` Dmitry Torokhov
2006-08-30 20:35 ` [-mm patch] improve SECURITY_SELINUX_POLICYDB_VERSION_MAX{,_VALUE} help texts Adrian Bunk
13 siblings, 1 reply; 36+ messages in thread
From: Adrian Bunk @ 2006-08-30 20:35 UTC (permalink / raw)
To: Andrew Morton, dmitry.torokhov; +Cc: linux-kernel, linux-input
This patch fixes the following section mismatch
(dmi_matched() is referenced from struct dmi_ids):
<-- snip -->
...
Building modules, stage 2.
MODPOST 1956 modules
WARNING: drivers/input/misc/wistron_btns.o - Section mismatch: reference to .init.text: from .data between 'dmi_ids' (at offset 0x1e0) and '__param_str_force'
WARNING: drivers/input/misc/wistron_btns.o - Section mismatch: reference to .init.text: from .data between 'dmi_ids' (at offset 0x20c) and '__param_str_force'
WARNING: drivers/input/misc/wistron_btns.o - Section mismatch: reference to .init.text: from .data between 'dmi_ids' (at offset 0x238) and '__param_str_force'
WARNING: drivers/input/misc/wistron_btns.o - Section mismatch: reference to .init.text: from .data between 'dmi_ids' (at offset 0x264) and '__param_str_force'
WARNING: drivers/input/misc/wistron_btns.o - Section mismatch: reference to .init.text: from .data between 'dmi_ids' (at offset 0x290) and '__param_str_force'
WARNING: drivers/input/misc/wistron_btns.o - Section mismatch: reference to .init.text: from .data between 'dmi_ids' (at offset 0x2bc) and '__param_str_force'
WARNING: drivers/input/misc/wistron_btns.o - Section mismatch: reference to .init.text: from .data between 'dmi_ids' (at offset 0x2e8) and '__param_str_force'
...
<-- snip -->
Signed-off-by: Adrian Bunk <bunk@stusta.de>
--- linux-2.6.18-rc4-mm3/drivers/input/misc/wistron_btns.c.old 2006-08-30 21:47:00.000000000 +0200
+++ linux-2.6.18-rc4-mm3/drivers/input/misc/wistron_btns.c 2006-08-30 21:47:57.000000000 +0200
@@ -242,7 +242,7 @@
static int have_wifi;
static int have_bluetooth;
-static int __init dmi_matched(struct dmi_system_id *dmi)
+static int dmi_matched(struct dmi_system_id *dmi)
{
const struct key_entry *key;
^ permalink raw reply [flat|nested] 36+ messages in thread* Re: [-mm patch] drivers/input/misc/wistron_btns.c: fix section mismatch
2006-08-30 20:35 ` [-mm patch] drivers/input/misc/wistron_btns.c: fix section mismatch Adrian Bunk
@ 2006-08-30 23:26 ` Dmitry Torokhov
2006-08-30 23:36 ` Adrian Bunk
0 siblings, 1 reply; 36+ messages in thread
From: Dmitry Torokhov @ 2006-08-30 23:26 UTC (permalink / raw)
To: Adrian Bunk; +Cc: Andrew Morton, linux-kernel, linux-input
On Wednesday 30 August 2006 16:35, Adrian Bunk wrote:
> This patch fixes the following section mismatch
> (dmi_matched() is referenced from struct dmi_ids):
>
dmi_ids is only used in select_keymap, which is __init. Moreover,
dmi_ids is marked __initdata so I do not see what the problem is...
--
Dmitry
^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: [-mm patch] drivers/input/misc/wistron_btns.c: fix section mismatch
2006-08-30 23:26 ` Dmitry Torokhov
@ 2006-08-30 23:36 ` Adrian Bunk
2006-08-31 2:54 ` Dmitry Torokhov
0 siblings, 1 reply; 36+ messages in thread
From: Adrian Bunk @ 2006-08-30 23:36 UTC (permalink / raw)
To: Dmitry Torokhov; +Cc: Andrew Morton, linux-kernel, linux-input
On Wed, Aug 30, 2006 at 07:26:37PM -0400, Dmitry Torokhov wrote:
> On Wednesday 30 August 2006 16:35, Adrian Bunk wrote:
> > This patch fixes the following section mismatch
> > (dmi_matched() is referenced from struct dmi_ids):
> >
>
> dmi_ids is only used in select_keymap, which is __init. Moreover,
> dmi_ids is marked __initdata so I do not see what the problem is...
ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.18-rc4/2.6.18-rc4-mm3/broken-out/revert-input-wistron-fix-section-reference-mismatches.patch
> Dmitry
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
^ permalink raw reply [flat|nested] 36+ messages in thread* Re: [-mm patch] drivers/input/misc/wistron_btns.c: fix section mismatch
2006-08-30 23:36 ` Adrian Bunk
@ 2006-08-31 2:54 ` Dmitry Torokhov
0 siblings, 0 replies; 36+ messages in thread
From: Dmitry Torokhov @ 2006-08-31 2:54 UTC (permalink / raw)
To: Adrian Bunk; +Cc: Andrew Morton, linux-kernel, linux-input
On Wednesday 30 August 2006 19:36, Adrian Bunk wrote:
> On Wed, Aug 30, 2006 at 07:26:37PM -0400, Dmitry Torokhov wrote:
> > On Wednesday 30 August 2006 16:35, Adrian Bunk wrote:
> > > This patch fixes the following section mismatch
> > > (dmi_matched() is referenced from struct dmi_ids):
> > >
> >
> > dmi_ids is only used in select_keymap, which is __init. Moreover,
> > dmi_ids is marked __initdata so I do not see what the problem is...
>
> ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.18-rc4/2.6.18-rc4-mm3/broken-out/revert-input-wistron-fix-section-reference-mismatches.patch
>
Ah, I see. I think it is fixed properly in Linus' tree.
--
Dmitry
^ permalink raw reply [flat|nested] 36+ messages in thread
* [-mm patch] improve SECURITY_SELINUX_POLICYDB_VERSION_MAX{,_VALUE} help texts
2006-08-26 23:09 2.6.18-rc4-mm3 Andrew Morton
` (12 preceding siblings ...)
2006-08-30 20:35 ` [-mm patch] drivers/input/misc/wistron_btns.c: fix section mismatch Adrian Bunk
@ 2006-08-30 20:35 ` Adrian Bunk
13 siblings, 0 replies; 36+ messages in thread
From: Adrian Bunk @ 2006-08-30 20:35 UTC (permalink / raw)
To: Andrew Morton, Stephen Smalley, jmorris; +Cc: linux-kernel
We can't expect everyone to know what "FC3" is.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
--- linux-2.6.18-rc4-mm3/security/selinux/Kconfig.old 2006-08-30 21:56:31.000000000 +0200
+++ linux-2.6.18-rc4-mm3/security/selinux/Kconfig 2006-08-30 21:58:21.000000000 +0200
@@ -135,8 +135,10 @@ config SECURITY_SELINUX_POLICYDB_VERSION
It can be adjusted downward to support legacy userland (init) that
does not correctly handle kernels that support newer policy versions.
- Examples: For FC3 or FC4, enable this option and set the value via
- the next option. For FC5 and later, do not enable this option.
+ Examples:
+ For the Fedora Core 3 or 4 Linux distributions, enable this option
+ and set the value via the next option. For Fedore Core 5 and later,
+ do not enable this option.
If you are unsure how to answer this question, answer N.
@@ -149,7 +151,9 @@ config SECURITY_SELINUX_POLICYDB_VERSION
This option sets the value for the maximum policy format version
supported by SELinux.
- Examples: For FC3, use 18. For FC4, use 19.
+ Examples:
+ For Fedora Core 3, use 18.
+ For Fedora Core 4, use 19.
If you are unsure how to answer this question, look for the
policy format version supported by your policy toolchain, by
^ permalink raw reply [flat|nested] 36+ messages in thread