public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Greg KH <greg@kroah.com>
Cc: Andrew Morton <akpm@osdl.org>,
	LKML <linux-kernel@vger.kernel.org>, Pavel Machek <pavel@ucw.cz>
Subject: Re: [PATCH -mm] PM: Add pm_trace switch
Date: Wed, 30 Aug 2006 22:22:36 +0200	[thread overview]
Message-ID: <200608302222.36535.rjw@sisk.pl> (raw)
In-Reply-To: <20060830172246.GD4534@kroah.com>

On Wednesday 30 August 2006 19:22, Greg KH wrote:
> On Wed, Aug 30, 2006 at 12:02:59PM +0200, Rafael J. Wysocki wrote:
> > On Tuesday 29 August 2006 22:46, Andrew Morton wrote:
> > > On Tue, 29 Aug 2006 13:09:57 +0200
> > > "Rafael J. Wysocki" <rjw@sisk.pl> wrote:
> > > 
> > > > +int pm_trace_enabled;
> > > > +
> > > > +static ssize_t pm_trace_show(struct subsystem * subsys, char * buf)
> > > > +{
> > > > +	return sprintf(buf, "%d\n", pm_trace_enabled);
> > > > +}
> > > > +
> > > > +static ssize_t
> > > > +pm_trace_store(struct subsystem * subsys, const char * buf, size_t n)
> > > > +{
> > > > +	int val;
> > > > +
> > > > +	if (sscanf(buf, "%d", &val) == 1) {
> > > > +		pm_trace_enabled = !!val;
> > > > +		return n;
> > > > +	}
> > > > +	return -EINVAL;
> > > > +}
> > > > +
> > > > +power_attr(pm_trace);
> > > 
> > > <grumbles about documentation>
> > 
> > Well, this is the most difficult part. ;-)
> > 
> > Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
> > ---
> >  Documentation/power/interface.txt |   15 +++++++++++++++
> 
> Please update Documentation/ABI/ too.

I could, but there's nothing related to /sys/power/ in Documentation/ABI/
right now.

Do you mean I should create a file for /sys/power/ in there?  If so, what
should I put in there?  I guess pretty much the same as in
Documentation/power/interface.txt ...

Greetings,
Rafael


-- 
You never change things by fighting the existing reality.
		R. Buckminster Fuller

  reply	other threads:[~2006-08-30 20:19 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-08-29 11:09 [PATCH -mm] PM: Add pm_trace switch Rafael J. Wysocki
2006-08-29 20:46 ` Andrew Morton
2006-08-30 10:02   ` Rafael J. Wysocki
2006-08-30 17:22     ` Greg KH
2006-08-30 20:22       ` Rafael J. Wysocki [this message]
2006-08-30 20:33         ` Greg KH
2006-08-30 20:54           ` Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200608302222.36535.rjw@sisk.pl \
    --to=rjw@sisk.pl \
    --cc=akpm@osdl.org \
    --cc=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pavel@ucw.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox