Re: [PATCH] THE LINUX/I386 BOOT PROTOCOL - Breaking the 256 limit (ping)

Andi Kleen
2006-08-30T17:32:43Z

On Wednesday 30 August 2006 19:06, Alon Bar-Lev wrote:

> >
> > And the other thing is that this will cost memory. Either make
> > it dependend on !CONFIG_SMALL or fix the boot code to save the
> > command line into a kmalloc'ed buffer of the right size and __init
> > the original one
>
> I don't mind doing either... Any preference for one of them? The
> kmalloc approach seems nicer..

kmalloc is better yes. You just have to do it after kmalloc is up
and running and make sure the users before reference the __init'ed version.
I suspect only /proc/cmdline will need the kmalloc version after booting,
nobody else should look at the command line.

-Andi