From: Adrian Bunk <bunk@stusta.de>
To: Andrew Morton <akpm@osdl.org>, reiserfs-dev@namesys.com
Cc: linux-kernel@vger.kernel.org
Subject: [-mm patch] fs/reiser4/: possible cleanups
Date: Fri, 1 Sep 2006 21:58:18 +0200 [thread overview]
Message-ID: <20060901195818.GF18276@stusta.de> (raw)
In-Reply-To: <20060901015818.42767813.akpm@osdl.org>
This patch contains the following possible cleanups:
- make the following needlessly global function static:
- plugin/file/file.c: hint_validate()
- #if 0 the following unused global function:
- jnode.c: page_detach_jnode()
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
fs/reiser4/jnode.c | 2 ++
fs/reiser4/jnode.h | 3 ---
fs/reiser4/plugin/file/file.c | 4 +++-
fs/reiser4/plugin/file/file.h | 2 --
4 files changed, 5 insertions(+), 6 deletions(-)
--- linux-2.6.18-rc5-mm1/fs/reiser4/plugin/file/file.h.old 2006-09-01 20:54:04.000000000 +0200
+++ linux-2.6.18-rc5-mm1/fs/reiser4/plugin/file/file.h 2006-09-01 20:54:09.000000000 +0200
@@ -157,8 +157,6 @@
void reiser4_set_hint(hint_t *, const reiser4_key *, znode_lock_mode);
int hint_is_set(const hint_t *);
void reiser4_unset_hint(hint_t *);
-int hint_validate(hint_t *, const reiser4_key *, int check_key,
- znode_lock_mode);
void hint_init_zero(hint_t *);
int reiser4_update_file_size(struct inode *, reiser4_key *, int update_sd);
--- linux-2.6.18-rc5-mm1/fs/reiser4/plugin/file/file.c.old 2006-09-01 20:54:17.000000000 +0200
+++ linux-2.6.18-rc5-mm1/fs/reiser4/plugin/file/file.c 2006-09-01 20:55:08.000000000 +0200
@@ -26,6 +26,8 @@
static int unpack(struct file *file, struct inode *inode, int forever);
static void drop_access(unix_file_info_t *);
+static int hint_validate(hint_t * hint, const reiser4_key * key, int check_key,
+ znode_lock_mode lock_mode);
/* get unix file plugin specific portion of inode */
unix_file_info_t *unix_file_inode_data(const struct inode *inode)
@@ -747,7 +749,7 @@
}
#endif
-int
+static int
hint_validate(hint_t * hint, const reiser4_key * key, int check_key,
znode_lock_mode lock_mode)
{
--- linux-2.6.18-rc5-mm1/fs/reiser4/jnode.h.old 2006-09-01 20:55:19.000000000 +0200
+++ linux-2.6.18-rc5-mm1/fs/reiser4/jnode.h 2006-09-01 20:55:27.000000000 +0200
@@ -486,9 +486,6 @@
return atomic_read(&node->d_count) > 0;
}
-extern void page_detach_jnode(struct page *page,
- struct address_space *mapping,
- unsigned long index) NONNULL;
extern void page_clear_jnode(struct page *page, jnode * node) NONNULL;
static inline void jnode_set_reloc(jnode * node)
--- linux-2.6.18-rc5-mm1/fs/reiser4/jnode.c.old 2006-09-01 20:55:33.000000000 +0200
+++ linux-2.6.18-rc5-mm1/fs/reiser4/jnode.c 2006-09-01 20:55:47.000000000 +0200
@@ -697,6 +697,7 @@
page_cache_release(page);
}
+#if 0
/* it is only used in one place to handle error */
void
page_detach_jnode(struct page *page, struct address_space *mapping,
@@ -716,6 +717,7 @@
}
unlock_page(page);
}
+#endif /* 0 */
/* return @node page locked.
next prev parent reply other threads:[~2006-09-01 19:58 UTC|newest]
Thread overview: 141+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-01 8:58 2.6.18-rc5-mm1 Andrew Morton
2006-09-01 9:53 ` 2.6.18-rc5-mm1 Manuel Lauss
2006-09-01 10:44 ` 2.6.18-rc5-mm1 Grant Wilson
2006-09-01 13:50 ` [-mm patch] drivers/md/Kconfig: fix BLOCK dependency Adrian Bunk
2006-09-01 14:15 ` David Howells
2006-09-01 14:26 ` Jens Axboe
2006-09-01 16:00 ` 2.6.18-rc5-mm1: drivers/infiniband/hw/amso1100/c2.c compile error Adrian Bunk
2006-09-01 17:13 ` Andrew Morton
2006-09-01 17:34 ` Roland Dreier
2006-09-01 18:23 ` Andrew Morton
2006-09-01 19:53 ` Roland Dreier
2006-09-01 20:04 ` Andrew Morton
2006-09-01 20:20 ` Tom Tucker
2006-09-01 20:43 ` Russell King
2006-09-01 20:54 ` Roland Dreier
2006-09-01 21:01 ` [openib-general] " Bryan O'Sullivan
2006-09-01 20:59 ` Andrew Morton
2006-09-01 21:05 ` Roland Dreier
2006-09-01 21:26 ` Andrew Morton
2006-09-01 22:42 ` Roland Dreier
2006-09-01 20:51 ` Roland Dreier
2006-09-01 21:03 ` Andrew Morton
2006-09-01 20:45 ` [openib-general] " Bryan O'Sullivan
2006-09-01 20:59 ` Roland Dreier
2006-09-01 21:03 ` Bryan O'Sullivan
2006-09-01 16:40 ` 2.6.18-rc5-mm1 Maciej Rutecki
2006-09-05 16:16 ` 2.6.18-rc5-mm1 Bjorn Helgaas
2006-09-06 16:55 ` 2.6.18-rc5-mm1 Maciej Rutecki
2006-09-07 3:08 ` 2.6.18-rc5-mm1 Andrew Morton
2006-09-07 17:33 ` 2.6.18-rc5-mm1 keith mannthey
2006-09-01 19:58 ` Adrian Bunk [this message]
2006-09-01 23:13 ` 2.6.18-rc5-mm1 (IDE resume regression) Rafael J. Wysocki
2006-09-02 0:08 ` Andrew Morton
2006-09-02 1:00 ` 2.6.18-rc5-mm1 Matthias Hentges
2006-09-02 1:30 ` 2.6.18-rc5-mm1 Andrew Morton
[not found] ` <44F93EB3.8050500@goop.org>
2006-09-02 8:37 ` 2.6.18-rc5-mm1 Jeremy Fitzhardinge
2006-09-02 8:44 ` 2.6.18-rc5-mm1 Greg KH
2006-09-02 8:47 ` 2.6.18-rc5-mm1 Jeremy Fitzhardinge
2006-09-02 8:52 ` 2.6.18-rc5-mm1 Greg KH
2006-09-02 9:36 ` 2.6.18-rc5-mm1 Jeremy Fitzhardinge
2006-09-02 9:38 ` 2.6.18-rc5-mm1 Jeff Garzik
2006-09-02 9:47 ` 2.6.18-rc5-mm1 Jeremy Fitzhardinge
2006-09-02 9:56 ` 2.6.18-rc5-mm1 Jeremy Fitzhardinge
2006-09-09 23:47 ` 2.6.18-rc5-mm1 Jeremy Fitzhardinge
2006-09-10 16:24 ` 2.6.18-rc5-mm1 Matthias Hentges
2006-09-02 1:06 ` 2.6.18-rc5-mm1 Grant Coady
2006-09-02 1:12 ` 2.6.18-rc5-mm1 Dmitry Torokhov
2006-09-02 1:33 ` 2.6.18-rc5-mm1 Dmitry Torokhov
2006-09-02 2:10 ` 2.6.18-rc5-mm1 Grant Coady
2006-09-02 1:39 ` 2.6.18-rc5-mm1 Andrew Morton
2006-09-02 3:51 ` 2.6.18-rc5-mm1 Grant Coady
2006-09-02 20:20 ` 2.6.18-rc5-mm1 Grant Coady
2006-09-02 20:38 ` "VGER BF report:.." ? Matti Aarnio
2006-09-03 15:06 ` Jan Engelhardt
2006-09-03 19:59 ` Grant Coady
2006-09-02 9:05 ` 2.6.18-rc5-mm1 Philippe Gramoullé
2006-09-02 11:40 ` 2.6.18-rc5-mm1 Stefan Richter
2006-09-02 11:51 ` 2.6.18-rc5-mm1 Philippe Gramoullé
2006-09-03 9:09 ` [2.6.18-rc5-mm1 ACPI] Unknown exception code: 0xFFFFFFEA Mike Galbraith
2006-09-05 16:18 ` Bjorn Helgaas
2006-09-03 17:25 ` 2.6.18-rc5-mm1: sysfs_init() related compile error Adrian Bunk
2006-09-03 22:17 ` 2.6.18-rc5-mm1: MMU=n " Adrian Bunk
2006-09-04 7:44 ` Peter Zijlstra
2006-09-04 15:44 ` Adrian Bunk
2006-09-03 23:34 ` Lost DVD-RW [Was Re: 2.6.18-rc5-mm1] J.A. Magallón
2006-09-04 1:12 ` Andrew Morton
2006-09-04 2:42 ` Tejun Heo
2006-09-04 22:26 ` J.A. Magallón
2006-09-07 9:34 ` Tejun Heo
2006-09-07 11:13 ` J.A. Magallón
2006-09-07 11:32 ` [PATCH libata-dev#upstream-fixes] libata: ignore CFA signature while sanity-checking an ATAPI device Tejun Heo
2006-09-07 20:27 ` Andrew Morton
2006-09-07 21:03 ` Jeff Garzik
2006-09-08 7:56 ` Tejun Heo
2006-09-09 14:46 ` Lost DVD-RW [Was Re: 2.6.18-rc5-mm1] Alan Cox
2006-09-04 11:41 ` 2.6.18-rc5-mm1: is_init() parisc compile error Adrian Bunk
2006-09-04 13:48 ` [parisc-linux] " Matthew Wilcox
2006-09-04 18:24 ` [PATCH] Fix conflict with the is_init identifier on parisc Eric W. Biederman
2006-09-04 18:41 ` Adrian Bunk
2006-09-04 19:18 ` Andrew Morton
2006-09-04 17:03 ` [-mm patch] drivers/infiniband/hw/amso1100/: possible cleanups Adrian Bunk
2006-09-04 17:03 ` [-mm patch] make fs/lockd/host.c:nlm_lookup_host() static Adrian Bunk
2006-09-04 17:04 ` 2.6.18-rc5-mm1: ARCH_DISCONTIGMEM_ENABLE=y, SMP=n compile error Adrian Bunk
2006-09-04 19:04 ` Andrew Morton
2006-09-04 19:24 ` Adrian Bunk
2006-09-04 17:04 ` [-mm patch] fix kernel_execve() related compile errors Adrian Bunk
2006-09-04 17:04 ` [-mm patch] lib/ioremap.c must #include <linux/mm.h> Adrian Bunk
2006-09-04 18:41 ` [-mm patch] mm/memory_hotplug.c must #include <linux/cpuset.h> Adrian Bunk
2006-09-04 22:17 ` [-mm patch] arch/m68knommu/kernel/sys_m68k.c must #include <asm/unistd.h> Adrian Bunk
2006-09-05 13:03 ` lockdep oddity Heiko Carstens
2006-09-05 18:12 ` Ingo Molnar
2006-09-05 18:57 ` Hua Zhong
2006-09-05 18:52 ` Ingo Molnar
2006-09-05 19:08 ` Ingo Molnar
2006-09-05 19:37 ` Ingo Molnar
2006-09-06 6:54 ` Heiko Carstens
2006-09-06 10:05 ` Ingo Molnar
2006-09-06 7:20 ` Heiko Carstens
2006-09-06 7:47 ` Andrew Morton
2006-09-06 8:01 ` Heiko Carstens
2006-09-06 8:23 ` Hua Zhong
2006-09-06 8:40 ` Ingo Molnar
2006-09-06 14:19 ` Daniel Walker
2006-09-06 14:29 ` Heiko Carstens
2006-09-06 14:34 ` Daniel Walker
2006-09-05 20:07 ` Daniel Walker
2006-09-06 7:18 ` Heiko Carstens
2006-09-06 11:58 ` Heiko Carstens
2006-09-05 13:25 ` 2.6.18-rc5-mm1: {dis,en}able_irq_lockdep_irqrestore compile error Adrian Bunk
2006-09-05 15:21 ` [PATCH] FRV: Fix " David Howells
2006-09-06 12:50 ` Ingo Molnar
2006-09-05 15:27 ` [PATCH] NOMMU: Move the fallback arch_vma_name() to a sensible place David Howells
2006-09-05 15:29 ` [PATCH] NOMMU: Provide page_mkclean() for NOMMU David Howells
2006-09-05 15:31 ` [PATCH] NOMMU: Make lib/ioremap.c conditional David Howells
2006-09-05 15:35 ` [PATCH] FRV: do_gettimeofday() should no longer use tickadj David Howells
2006-09-06 1:46 ` john stultz
2006-09-06 9:27 ` David Howells
2006-09-06 9:43 ` Ingo Molnar
2006-09-06 12:30 ` David Howells
2006-09-06 12:56 ` Ingo Molnar
2006-09-06 14:46 ` David Howells
2006-09-06 23:01 ` Benjamin Herrenschmidt
2006-09-07 9:55 ` David Howells
2006-09-07 10:26 ` Ingo Molnar
2006-09-07 13:34 ` David Howells
2006-09-07 22:53 ` Benjamin Herrenschmidt
2006-09-08 10:25 ` David Howells
2006-09-08 11:05 ` Benjamin Herrenschmidt
2006-09-08 12:24 ` David Howells
2006-09-08 12:29 ` David Howells
2006-09-11 4:06 ` Benjamin Herrenschmidt
2006-09-09 5:46 ` Ingo Molnar
2006-09-11 10:46 ` David Howells
2006-09-05 16:00 ` 2.6.18-rc5-mm1 dependency on curses devel still there Steve Fox
2006-09-06 23:06 ` [-mm patch] ATA_JMICRON: remove the superfluous ATA dependency Adrian Bunk
2006-09-06 23:07 ` [-mm patch] ACPI_SONY shouldn't default m Adrian Bunk
2006-09-07 3:30 ` Andrew Morton
2006-09-07 4:41 ` Randy.Dunlap
-- strict thread matches above, loose matches on Subject: below --
2006-11-14 9:41 2.6.19-rc5-mm2 Andrew Morton
2006-11-20 2:24 ` [-mm patch] fs/reiser4/: possible cleanups Adrian Bunk
2006-06-21 10:48 2.6.17-mm1 Andrew Morton
2006-06-23 10:55 ` [-mm patch] fs/reiser4/: possible cleanups Adrian Bunk
2006-06-23 15:54 ` Hans Reiser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060901195818.GF18276@stusta.de \
--to=bunk@stusta.de \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=reiserfs-dev@namesys.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).