Re: [PATCH 01/26] Dynamic kernel command-line - common

Bill Davidsen
2006-09-05T23:51:54Z

Matthew Wilcox wrote:
> On Mon, Sep 04, 2006 at 12:52:14AM +0300, Alon Bar-Lev wrote:
>> @@ -116,8 +116,12 @@ extern void time_init(void);
>> void (*late_time_init)(void);
>> extern void softirq_init(void);
>>
>> -/* Untouched command line (eg. for /proc) saved by
>> arch-specific code. */
>> -char saved_command_line[COMMAND_LINE_SIZE];
>> +/* Untouched command line saved by arch-specific code. */
>> +char __initdata boot_command_line[COMMAND_LINE_SIZE];
>
> Your patch is wordwrapped.
>
> Also, what was the point of all this? Was there some discussion that
> this would be useful?
>
Assuming that this works as described, the benefits are obvious. In most
cases I would expect the memory saved to be more than the patch takes,
and the patch is init code. Having the possibility of having very long
command lines is bound to be useful on occasion, particularly when using
drivers with option-names-way-too-long.

I agree that this wouldn't make my top 200 list of wanted features, but
it's here, it saves a little memory, it adds a capability someone will
find useful, why not use it? It appears to be a small win in every case.

--
Bill Davidsen <davidsen@tmr.com>
Obscure bug of 2004: BASH BUFFER OVERFLOW - if bash is being run by a
normal user and is setuid root, with the "vi" line edit mode selected,
and the character set is "big5," an off-by-one errors occurs during
wildcard (glob) expansion.