From: Vojtech Pavlik <vojtech@suse.cz>
To: Adrian Bunk <bunk@stusta.de>
Cc: Jeremy Roberson <jroberson@gtcocalcomp.com>,
Greg Kroah-Hartman <gregkh@suse.de>,
linux-kernel@vger.kernel.org,
linux-usb-devel@lists.sourceforge.net
Subject: Re: [2.6 patch] drivers/usb/input/hid-core.c: fix duplicate USB_DEVICE_ID_GTCO_404
Date: Mon, 4 Sep 2006 13:54:23 +0200 [thread overview]
Message-ID: <20060904115423.GA31489@suse.cz> (raw)
In-Reply-To: <20060904114110.GK4416@stusta.de>
On Mon, Sep 04, 2006 at 01:41:10PM +0200, Adrian Bunk wrote:
> On Fri, Sep 01, 2006 at 01:58:18AM -0700, Andrew Morton wrote:
> >...
> > Changes since 2.6.18-rc4-mm3:
> >...
> > +gregkh-usb-hid-core.c-adds-all-gtco-calcomp-digitizers-and-interwrite-school-products-to-blacklist.patch
> >...
> > USB tree updates.
> >...
>
> The GNU C compiler spotted the following bug:
>
> <-- snip -->
>
> ...
> CC drivers/usb/input/hid-core.o
> /home/bunk/linux/kernel-2.6/linux-2.6.18-rc5-mm1/drivers/usb/input/hid-core.c:1446:1: warning: "USB_DEVICE_ID_GTCO_404" redefined
> /home/bunk/linux/kernel-2.6/linux-2.6.18-rc5-mm1/drivers/usb/input/hid-core.c:1445:1: warning: this is the location of the previous definition
> ...
>
> <-- snip -->
>
> This patch fixes this cut'n'paste error.
Thanks, Adrian. Greg, please apply.
>
> Signed-off-by: Adrian Bunk <bunk@stusta.de>
>
> --- linux-2.6.18-rc5-mm1/drivers/usb/input/hid-core.c.old 2006-09-03 21:00:25.000000000 +0200
> +++ linux-2.6.18-rc5-mm1/drivers/usb/input/hid-core.c 2006-09-03 21:00:44.000000000 +0200
> @@ -1443,7 +1443,7 @@
> #define USB_DEVICE_ID_GTCO_402 0x0402
> #define USB_DEVICE_ID_GTCO_403 0x0403
> #define USB_DEVICE_ID_GTCO_404 0x0404
> -#define USB_DEVICE_ID_GTCO_404 0x0405
> +#define USB_DEVICE_ID_GTCO_405 0x0405
> #define USB_DEVICE_ID_GTCO_500 0x0500
> #define USB_DEVICE_ID_GTCO_501 0x0501
> #define USB_DEVICE_ID_GTCO_502 0x0502
> @@ -1663,7 +1663,7 @@
> { USB_VENDOR_ID_GTCO, USB_DEVICE_ID_GTCO_402, HID_QUIRK_IGNORE },
> { USB_VENDOR_ID_GTCO, USB_DEVICE_ID_GTCO_403, HID_QUIRK_IGNORE },
> { USB_VENDOR_ID_GTCO, USB_DEVICE_ID_GTCO_404, HID_QUIRK_IGNORE },
> - { USB_VENDOR_ID_GTCO, USB_DEVICE_ID_GTCO_404, HID_QUIRK_IGNORE },
> + { USB_VENDOR_ID_GTCO, USB_DEVICE_ID_GTCO_405, HID_QUIRK_IGNORE },
> { USB_VENDOR_ID_GTCO, USB_DEVICE_ID_GTCO_500, HID_QUIRK_IGNORE },
> { USB_VENDOR_ID_GTCO, USB_DEVICE_ID_GTCO_501, HID_QUIRK_IGNORE },
> { USB_VENDOR_ID_GTCO, USB_DEVICE_ID_GTCO_502, HID_QUIRK_IGNORE },
>
>
>
--
Vojtech Pavlik
Director SuSE Labs
--
VGER BF report: H 0.0165713
next prev parent reply other threads:[~2006-09-04 11:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-04 11:41 [2.6 patch] drivers/usb/input/hid-core.c: fix duplicate USB_DEVICE_ID_GTCO_404 Adrian Bunk
2006-09-04 11:54 ` Vojtech Pavlik [this message]
2006-09-04 14:29 ` Gene Heskett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060904115423.GA31489@suse.cz \
--to=vojtech@suse.cz \
--cc=bunk@stusta.de \
--cc=gregkh@suse.de \
--cc=jroberson@gtcocalcomp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox