From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750835AbWIFNn5 (ORCPT ); Wed, 6 Sep 2006 09:43:57 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750929AbWIFNnw (ORCPT ); Wed, 6 Sep 2006 09:43:52 -0400 Received: from brick.kernel.dk ([62.242.22.158]:21800 "EHLO kernel.dk") by vger.kernel.org with ESMTP id S1750945AbWIFNnZ (ORCPT ); Wed, 6 Sep 2006 09:43:25 -0400 Date: Wed, 6 Sep 2006 15:46:43 +0200 From: Jens Axboe To: Peter Zijlstra Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, Daniel Phillips , Rik van Riel , David Miller , Andrew Morton , Pavel Machek Subject: Re: [PATCH 10/21] block: elevator selection and pinning Message-ID: <20060906134642.GC14565@kernel.dk> References: <20060906131630.793619000@chello.nl>> <20060906133954.673752000@chello.nl> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20060906133954.673752000@chello.nl> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 06 2006, Peter Zijlstra wrote: > Provide an block queue init function that allows to set an elevator. And a > function to pin the current elevator. > > Signed-off-by: Peter Zijlstra > Signed-off-by: Daniel Phillips > CC: Jens Axboe > CC: Pavel Machek Generally I don't think this is the right approach, as what you really want to do is let the driver say "I want intelligent scheduling" or not. The type of scheduler is policy that is left with the user, not the driver. And this patch seems to do two things, and you don't explain what the pinning is useful for at all. So that's 2 for 2 currently, NAK from me. -- Jens Axboe