From: Olaf Hering <olaf@aepfle.de>
To: Kirill Korotaev <dev@openvz.org>
Cc: Andrew Morton <akpm@osdl.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Andrey Mirkin <amirkin@sw.ru>,
devel@openvz.org, mikpe@it.uu.se, sam@ravnborg.org,
bunk@stusta.de
Subject: Re: [PATCH] fail kernel compilation in case of unresolved symbols (v2)
Date: Thu, 7 Sep 2006 13:05:13 +0200 [thread overview]
Message-ID: <20060907110513.GA22319@aepfle.de> (raw)
In-Reply-To: <44FFEE5D.2050905@openvz.org>
On Thu, Sep 07, Kirill Korotaev wrote:
> At stage 2 modpost utility is used to check modules.
> In case of unresolved symbols modpost only prints warning.
>
> IMHO it is a good idea to fail compilation process in case of
> unresolved symbols (at least in modules coming with kernel),
> since usually such errors are left unnoticed, but kernel
> modules are broken.
It clearly depends on the context. An unimportant dvb module may have
unresolved symbols, but the drivers for your root filesystem should
rather not have unresolved symbols.
Better leave the current default, your patch seems to turn an unresolved
symbol with "unknown importance" into a hard error.
next prev parent reply other threads:[~2006-09-07 11:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-07 10:03 [PATCH] fail kernel compilation in case of unresolved symbols (v2) Kirill Korotaev
2006-09-07 11:05 ` Olaf Hering [this message]
2006-09-07 11:13 ` Adrian Bunk
2006-09-07 12:26 ` Olaf Hering
2006-09-07 15:23 ` Kirill Korotaev
2006-09-07 16:27 ` Andrew Morton
2006-09-08 0:13 ` Chris Wedgwood
2006-09-08 10:58 ` Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060907110513.GA22319@aepfle.de \
--to=olaf@aepfle.de \
--cc=akpm@osdl.org \
--cc=amirkin@sw.ru \
--cc=bunk@stusta.de \
--cc=dev@openvz.org \
--cc=devel@openvz.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mikpe@it.uu.se \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox