Re: [PATCH] fail kernel compilation in case of unresolved symbols (v2)

Adrian Bunk
2006-09-07T11:13:33Z

On Thu, Sep 07, 2006 at 01:05:13PM +0200, Olaf Hering wrote:
> On Thu, Sep 07, Kirill Korotaev wrote:
>
> > At stage 2 modpost utility is used to check modules.
> > In case of unresolved symbols modpost only prints warning.
> >
> > IMHO it is a good idea to fail compilation process in case of
> > unresolved symbols (at least in modules coming with kernel),
> > since usually such errors are left unnoticed, but kernel
> > modules are broken.
>
> It clearly depends on the context. An unimportant dvb module may have
> unresolved symbols, but the drivers for your root filesystem should
> rather not have unresolved symbols.
>
> Better leave the current default, your patch seems to turn an unresolved
> symbol with "unknown importance" into a hard error.

If any module shipped with the kernel has in any configuration
unresolved symbols that's a bug that should be reported, not ignored.

And changing runtime errors to build errors ensures that such errors
never reach users (if the module is really unimportant disabling it
is easy).

cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed