* PATCH] usbtouchscreen: fix ITM data reading
@ 2006-09-07 19:25 Daniel Ritz
2006-09-07 19:40 ` Dmitry Torokhov
0 siblings, 1 reply; 2+ messages in thread
From: Daniel Ritz @ 2006-09-07 19:25 UTC (permalink / raw)
To: Greg KH, Dmitry Torokhov; +Cc: linux-kernel, linux-usb, Kai Lindholm
before 2.6.19, please :)
[PATCH] usbtouchscreen: fix ITM data reading
From: Kai Lindhom <megantti@gmail.com>
Signed-off-by: Daniel Ritz <daniel.ritz@gmx.ch>
diff --git a/drivers/usb/input/usbtouchscreen.c b/drivers/usb/input/usbtouchscreen.c
index 3b175aa..a338bf4 100644
--- a/drivers/usb/input/usbtouchscreen.c
+++ b/drivers/usb/input/usbtouchscreen.c
@@ -286,7 +286,7 @@ #ifdef CONFIG_USB_TOUCHSCREEN_ITM
static int itm_read_data(unsigned char *pkt, int *x, int *y, int *touch, int *press)
{
*x = ((pkt[0] & 0x1F) << 7) | (pkt[3] & 0x7F);
- *x = ((pkt[1] & 0x1F) << 7) | (pkt[4] & 0x7F);
+ *y = ((pkt[1] & 0x1F) << 7) | (pkt[4] & 0x7F);
*press = ((pkt[2] & 0x1F) << 7) | (pkt[5] & 0x7F);
*touch = ~pkt[7] & 0x20;
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: PATCH] usbtouchscreen: fix ITM data reading
2006-09-07 19:25 PATCH] usbtouchscreen: fix ITM data reading Daniel Ritz
@ 2006-09-07 19:40 ` Dmitry Torokhov
0 siblings, 0 replies; 2+ messages in thread
From: Dmitry Torokhov @ 2006-09-07 19:40 UTC (permalink / raw)
To: Daniel Ritz; +Cc: Greg KH, linux-kernel, linux-usb, Kai Lindholm
On Thursday 07 September 2006 15:25, Daniel Ritz wrote:
> before 2.6.19, please :)
>
> [PATCH] usbtouchscreen: fix ITM data reading
>
> From: Kai Lindhom <megantti@gmail.com>
> Signed-off-by: Daniel Ritz <daniel.ritz@gmx.ch>
>
Acked-by: Dmitry Torokhov <dtor@mail.ru>
Greg, will you push it through your tree?
> diff --git a/drivers/usb/input/usbtouchscreen.c b/drivers/usb/input/usbtouchscreen.c
> index 3b175aa..a338bf4 100644
> --- a/drivers/usb/input/usbtouchscreen.c
> +++ b/drivers/usb/input/usbtouchscreen.c
> @@ -286,7 +286,7 @@ #ifdef CONFIG_USB_TOUCHSCREEN_ITM
> static int itm_read_data(unsigned char *pkt, int *x, int *y, int *touch, int *press)
> {
> *x = ((pkt[0] & 0x1F) << 7) | (pkt[3] & 0x7F);
> - *x = ((pkt[1] & 0x1F) << 7) | (pkt[4] & 0x7F);
> + *y = ((pkt[1] & 0x1F) << 7) | (pkt[4] & 0x7F);
> *press = ((pkt[2] & 0x1F) << 7) | (pkt[5] & 0x7F);
> *touch = ~pkt[7] & 0x20;
>
>
--
Dmitry
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2006-09-07 19:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-09-07 19:25 PATCH] usbtouchscreen: fix ITM data reading Daniel Ritz
2006-09-07 19:40 ` Dmitry Torokhov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox