Re: 2.6.18-rc6-mm1

[Frederik Deweerdt <deweerdt@free.fr>]

On Fri, Sep 08, 2006 at 01:13:17AM -0700, Andrew Morton wrote:
> 
> ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.18-rc6/2.6.18-rc6-mm1/
> 
Hi,

2.6.18-rc6-mm1 fails to build on x86 with !CONFIG_SMP with the following
message:
  CHK     include/linux/version.h
  CHK     include/linux/utsrelease.h
  CHK     include/linux/compile.h
  UPD     include/linux/compile.h
  CC      init/version.o
  LD      init/built-in.o
  CC      arch/i386/kernel/cpu/common.o
arch/i386/kernel/cpu/common.c: In function `init_gdt':
arch/i386/kernel/cpu/common.c:667: warning: implicit declaration of function `early_smp_processor_id'
  LD      arch/i386/kernel/cpu/built-in.o
  LD      arch/i386/kernel/built-in.o
  GEN     .version
  CHK     include/linux/compile.h
  UPD     include/linux/compile.h
  CC      init/version.o
  LD      init/built-in.o
  LD      .tmp_vmlinux1
arch/i386/kernel/built-in.o: In function `init_gdt':
arch/i386/kernel/cpu/common.c:667: undefined reference to `early_smp_processor_id'
arch/i386/kernel/built-in.o: In function `cpu_init':
arch/i386/kernel/cpu/common.c:737: undefined reference to `early_smp_processor_id'
make: *** [.tmp_vmlinux1] Error 1

We need to include <asm/smp.h> to define early_smp_processor_id().

Regards,
Frederik


Signed-off-by: Frederik Deweerdt <frederik.deweerdt@gmail.com>

--- arch/i386/kernel/cpu/common.c~	2006-09-08 11:57:09.000000000 +0200
+++ arch/i386/kernel/cpu/common.c	2006-09-08 11:57:24.000000000 +0200
@@ -13,6 +13,7 @@
 #include <asm/mmu_context.h>
 #include <asm/mtrr.h>
 #include <asm/mce.h>
+#include <asm/smp.h>
 #ifdef CONFIG_X86_LOCAL_APIC
 #include <asm/mpspec.h>
 #include <asm/apic.h>