From: David Miller <davem@davemloft.net>
To: benh@kernel.crashing.org
Cc: mchan@broadcom.com, segher@kernel.crashing.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
paulus@samba.org
Subject: Re: TG3 data corruption (TSO ?)
Date: Sat, 09 Sep 2006 02:22:28 -0700 (PDT) [thread overview]
Message-ID: <20060909.022228.41644790.davem@davemloft.net> (raw)
In-Reply-To: <1157751962.31071.102.camel@localhost.localdomain>
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Date: Sat, 09 Sep 2006 07:46:02 +1000
> I don't think that in general, you have ordering guarantees between
> cacheable and non-cacheable stores unless you use explicit barriers.
In fact, on most systems you absolutely do have ordering between
MMIO and memory accesses.
So you are making an extremely poor engineering decision
by trying to fixup all the drivers to match PowerPC's
semantics. I think a smart engineer would decrease his
debugging burdon, by matching his platform's MMIO accessors
such that it matches what other platforms do and therefore
inheriting the testing coverage provided by all platforms.
Otherwise you will be hunting down these kinds of memory
barrier issues forever.
next prev parent reply other threads:[~2006-09-09 9:21 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-08 8:30 TG3 data corruption (TSO ?) Benjamin Herrenschmidt
2006-09-08 15:49 ` Michael Chan
2006-09-08 19:29 ` Segher Boessenkool
2006-09-08 19:54 ` Michael Chan
2006-09-08 21:46 ` Benjamin Herrenschmidt
2006-09-08 22:22 ` Michael Chan
2006-09-09 9:22 ` David Miller [this message]
2006-09-09 22:36 ` Benjamin Herrenschmidt
2006-09-10 0:38 ` Alan Cox
2006-09-10 1:17 ` Benjamin Herrenschmidt
2006-09-11 4:53 ` Benjamin Herrenschmidt
2006-09-11 5:18 ` Michael Chan
2006-09-11 5:25 ` Benjamin Herrenschmidt
2006-09-11 5:33 ` Michael Chan
2006-09-11 5:52 ` Benjamin Herrenschmidt
2006-09-11 8:20 ` Benjamin Herrenschmidt
2006-09-11 13:54 ` Segher Boessenkool
2006-09-11 16:08 ` Michael Chan
2006-09-08 21:41 ` Benjamin Herrenschmidt
2006-09-08 22:07 ` Michael Chan
2006-09-08 22:25 ` Benjamin Herrenschmidt
2006-09-08 22:40 ` Michael Chan
2006-09-08 22:49 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060909.022228.41644790.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=benh@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=paulus@samba.org \
--cc=segher@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox