* Fwd: [-stable patch] pci_ids.h: add some VIA IDE identifiers
@ 2006-09-09 0:19 Dave Jones
2006-09-09 0:37 ` Grant Coady
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Dave Jones @ 2006-09-09 0:19 UTC (permalink / raw)
To: Greg KH
Cc: linux-kernel, stable, Justin Forbes, Zwane Mwaikambo,
Theodore Ts'o, Randy Dunlap, Dave Jones, Chuck Wolber,
Chris Wedgwood, torvalds, akpm, alan, Adrian Bunk
[-- Attachment #1: Type: text/plain, Size: 170 bytes --]
This never made it into 2.6.17.12
Without it, this happens..
drivers/ide/pci/via82cxxx.c:85: error: 'PCI_DEVICE_ID_VIA_8237A' undeclared here (not in a function)
Dave
[-- Attachment #2: Type: message/rfc822, Size: 5194 bytes --]
From: Adrian Bunk <bunk@stusta.de>
To: Greg KH <gregkh@suse.de>
Cc: linux-kernel@vger.kernel.org, stable@kernel.org, Justin Forbes <jmforbes@linuxtx.org>, Zwane Mwaikambo <zwane@arm.linux.org.uk>, "Theodore Ts'o" <tytso@mit.edu>, Randy Dunlap <rdunlap@xenotime.net>, Dave Jones <davej@redhat.com>, Chuck Wolber <chuckw@quantumlinux.com>, Chris Wedgwood <reviews@ml.cw.f00f.org>, torvalds@osdl.org, akpm@osdl.org, alan@lxorguk.ukuu.org.uk
Subject: [-stable patch] pci_ids.h: add some VIA IDE identifiers
Date: Thu, 7 Sep 2006 01:33:03 +0200
Message-ID: <20060906233303.GA25473@stusta.de>
On Wed, Sep 06, 2006 at 03:57:36PM -0700, Greg KH wrote:
> -stable review patch. If anyone has any objections, please let us know.
>
> ------------------
> From: Alan Cox <alan@lxorguk.ukuu.org.uk>
>
>
> The following change from -mm is important to 2.6.18 (actually to 2.6.17
> but its too late for that). This was contributed over three months ago
> by VIA to Bartlomiej and nothing happened. As a result the new chipset
> is now out and Linux won't run on it. By the time 2.6.18 is finalised
> this will be the defacto standard VIA chipset so support would be a good
> plan.
>
> Tested in -mm for a while, its essentially a PCI ident update but for
> the bridge chip because VIA do things in weird ways.
>
>
> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
>
>
> ---
> drivers/ide/pci/via82cxxx.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>...
If anyone actually tries to compile this driver the patch below might
be helpful.
cu
Adrian
<-- snip -->
commit 47251e05f74783cc03f83f5e88016fc2cbd059f1
Author: Alan Cox <alan@redhat.com>
Date: Wed Sep 6 19:55:17 2006 +0200
pci_ids.h: add some VIA IDE identifiers
Signed-off-by: Alan Cox <alan@redhat.com>
Signed-off-by: Adrian Bunk <bunk@stusta.de>
diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h
index 751eea5..960fb7b 100644
--- a/include/linux/pci_ids.h
+++ b/include/linux/pci_ids.h
@@ -1223,6 +1223,7 @@ #define PCI_DEVICE_ID_VIA_PT880 0x0258
#define PCI_DEVICE_ID_VIA_PX8X0_0 0x0259
#define PCI_DEVICE_ID_VIA_3269_0 0x0269
#define PCI_DEVICE_ID_VIA_K8T800PRO_0 0x0282
+#define PCI_DEVICE_ID_VIA_3296_0 0x0296
#define PCI_DEVICE_ID_VIA_8363_0 0x0305
#define PCI_DEVICE_ID_VIA_P4M800CE 0x0314
#define PCI_DEVICE_ID_VIA_8371_0 0x0391
@@ -1230,6 +1231,7 @@ #define PCI_DEVICE_ID_VIA_8501_0 0x0501
#define PCI_DEVICE_ID_VIA_82C561 0x0561
#define PCI_DEVICE_ID_VIA_82C586_1 0x0571
#define PCI_DEVICE_ID_VIA_82C576 0x0576
+#define PCI_DEVICE_ID_VIA_SATA_EIDE 0x0581
#define PCI_DEVICE_ID_VIA_82C586_0 0x0586
#define PCI_DEVICE_ID_VIA_82C596 0x0596
#define PCI_DEVICE_ID_VIA_82C597_0 0x0597
@@ -1270,10 +1272,11 @@ #define PCI_DEVICE_ID_VIA_8378_0 0x3205
#define PCI_DEVICE_ID_VIA_8783_0 0x3208
#define PCI_DEVICE_ID_VIA_8237 0x3227
#define PCI_DEVICE_ID_VIA_8251 0x3287
-#define PCI_DEVICE_ID_VIA_3296_0 0x0296
+#define PCI_DEVICE_ID_VIA_8237A 0x3337
#define PCI_DEVICE_ID_VIA_8231 0x8231
#define PCI_DEVICE_ID_VIA_8231_4 0x8235
#define PCI_DEVICE_ID_VIA_8365_1 0x8305
+#define PCI_DEVICE_ID_VIA_CX700 0x8324
#define PCI_DEVICE_ID_VIA_8371_1 0x8391
#define PCI_DEVICE_ID_VIA_82C598_1 0x8598
#define PCI_DEVICE_ID_VIA_838X_1 0xB188
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: Fwd: [-stable patch] pci_ids.h: add some VIA IDE identifiers
2006-09-09 0:19 Fwd: [-stable patch] pci_ids.h: add some VIA IDE identifiers Dave Jones
@ 2006-09-09 0:37 ` Grant Coady
2006-09-09 1:37 ` Grant Coady
2006-09-09 3:10 ` Greg KH
2 siblings, 0 replies; 6+ messages in thread
From: Grant Coady @ 2006-09-09 0:37 UTC (permalink / raw)
To: Dave Jones
Cc: Greg KH, linux-kernel, stable, Justin Forbes, Zwane Mwaikambo,
Theodore Ts'o, Randy Dunlap, Dave Jones, Chuck Wolber,
Chris Wedgwood, torvalds, akpm, alan, Adrian Bunk
On Fri, 8 Sep 2006 20:19:25 -0400, Dave Jones <davej@redhat.com> wrote:
>If anyone actually tries to compile this driver the patch below might
>be helpful.
It's a bit late now for -stable, 2.6.17.13 needed ASAP?
Grant.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Fwd: [-stable patch] pci_ids.h: add some VIA IDE identifiers
2006-09-09 0:19 Fwd: [-stable patch] pci_ids.h: add some VIA IDE identifiers Dave Jones
2006-09-09 0:37 ` Grant Coady
@ 2006-09-09 1:37 ` Grant Coady
2006-09-09 3:10 ` Greg KH
2 siblings, 0 replies; 6+ messages in thread
From: Grant Coady @ 2006-09-09 1:37 UTC (permalink / raw)
To: Dave Jones
Cc: Greg KH, linux-kernel, stable, Justin Forbes, Zwane Mwaikambo,
Theodore Ts'o, Randy Dunlap, Dave Jones, Chuck Wolber,
Chris Wedgwood, torvalds, akpm, alan, Adrian Bunk
On Fri, 8 Sep 2006 20:19:25 -0400, Dave Jones <davej@redhat.com> wrote:
>This never made it into 2.6.17.12
>Without it, this happens..
>
>drivers/ide/pci/via82cxxx.c:85: error: 'PCI_DEVICE_ID_VIA_8237A' undeclared here (not in a function)
>
> Dave
patching file include/linux/pci_ids.h
Hunk #1 succeeded at 1235 (offset 12 lines).
Hunk #3 succeeded at 1284 (offset 12 lines).
Works here ;)
Grant.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Fwd: [-stable patch] pci_ids.h: add some VIA IDE identifiers
2006-09-09 0:19 Fwd: [-stable patch] pci_ids.h: add some VIA IDE identifiers Dave Jones
2006-09-09 0:37 ` Grant Coady
2006-09-09 1:37 ` Grant Coady
@ 2006-09-09 3:10 ` Greg KH
2006-09-09 3:46 ` Dave Jones
2 siblings, 1 reply; 6+ messages in thread
From: Greg KH @ 2006-09-09 3:10 UTC (permalink / raw)
To: Dave Jones, linux-kernel, stable, Justin Forbes, Zwane Mwaikambo,
Theodore Ts'o, Randy Dunlap, Chuck Wolber, Chris Wedgwood,
torvalds, akpm, alan, Adrian Bunk
On Fri, Sep 08, 2006 at 08:19:25PM -0400, Dave Jones wrote:
> This never made it into 2.6.17.12
> Without it, this happens..
>
> drivers/ide/pci/via82cxxx.c:85: error: 'PCI_DEVICE_ID_VIA_8237A' undeclared here (not in a function)
Doh! Sorry about that, I forgot to do a run with 'make allmodconfig'
this time around, and it shows :(
.13 will be out shortly...
thanks,
greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Fwd: [-stable patch] pci_ids.h: add some VIA IDE identifiers
2006-09-09 3:10 ` Greg KH
@ 2006-09-09 3:46 ` Dave Jones
2006-09-09 4:14 ` Greg KH
0 siblings, 1 reply; 6+ messages in thread
From: Dave Jones @ 2006-09-09 3:46 UTC (permalink / raw)
To: Greg KH
Cc: linux-kernel, stable, Justin Forbes, Zwane Mwaikambo,
Theodore Ts'o, Randy Dunlap, Chuck Wolber, Chris Wedgwood,
torvalds, akpm, alan, Adrian Bunk
On Fri, Sep 08, 2006 at 08:10:20PM -0700, Greg KH wrote:
> On Fri, Sep 08, 2006 at 08:19:25PM -0400, Dave Jones wrote:
> > This never made it into 2.6.17.12
> > Without it, this happens..
> >
> > drivers/ide/pci/via82cxxx.c:85: error: 'PCI_DEVICE_ID_VIA_8237A' undeclared here (not in a function)
>
> Doh! Sorry about that, I forgot to do a run with 'make allmodconfig'
> this time around, and it shows :(
>
> .13 will be out shortly...
Might want to throw this in too, which removes a new warning that appeared in 2.6.17.12
warning about implicit declaration of idr_remove
Signed-off-by: Dave Jones <davej@redhat.com>
--- linux-2.6.17.noarch/drivers/md/dm.c~ 2006-09-08 23:37:08.000000000 -0400
+++ linux-2.6.17.noarch/drivers/md/dm.c 2006-09-08 23:37:16.000000000 -0400
@@ -20,6 +20,7 @@
#include <linux/idr.h>
#include <linux/hdreg.h>
#include <linux/blktrace_api.h>
+#include <linux/idr.h>
static const char *_name = DM_NAME;
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Fwd: [-stable patch] pci_ids.h: add some VIA IDE identifiers
2006-09-09 3:46 ` Dave Jones
@ 2006-09-09 4:14 ` Greg KH
0 siblings, 0 replies; 6+ messages in thread
From: Greg KH @ 2006-09-09 4:14 UTC (permalink / raw)
To: Dave Jones, linux-kernel, stable, Justin Forbes, Zwane Mwaikambo,
Theodore Ts'o, Randy Dunlap, Chuck Wolber, Chris Wedgwood,
torvalds, akpm, alan, Adrian Bunk
On Fri, Sep 08, 2006 at 11:46:38PM -0400, Dave Jones wrote:
> On Fri, Sep 08, 2006 at 08:10:20PM -0700, Greg KH wrote:
> > On Fri, Sep 08, 2006 at 08:19:25PM -0400, Dave Jones wrote:
> > > This never made it into 2.6.17.12
> > > Without it, this happens..
> > >
> > > drivers/ide/pci/via82cxxx.c:85: error: 'PCI_DEVICE_ID_VIA_8237A' undeclared here (not in a function)
> >
> > Doh! Sorry about that, I forgot to do a run with 'make allmodconfig'
> > this time around, and it shows :(
> >
> > .13 will be out shortly...
>
> Might want to throw this in too, which removes a new warning that appeared in 2.6.17.12
> warning about implicit declaration of idr_remove
That would not have worked, idr_remove wasn't even in the tree :(
I should have fixed it now, thanks.
greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2006-09-09 4:15 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-09-09 0:19 Fwd: [-stable patch] pci_ids.h: add some VIA IDE identifiers Dave Jones
2006-09-09 0:37 ` Grant Coady
2006-09-09 1:37 ` Grant Coady
2006-09-09 3:10 ` Greg KH
2006-09-09 3:46 ` Dave Jones
2006-09-09 4:14 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox