From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750749AbWIJHwv (ORCPT ); Sun, 10 Sep 2006 03:52:51 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750751AbWIJHwv (ORCPT ); Sun, 10 Sep 2006 03:52:51 -0400 Received: from mtagate1.uk.ibm.com ([195.212.29.134]:31530 "EHLO mtagate1.uk.ibm.com") by vger.kernel.org with ESMTP id S1750749AbWIJHwv (ORCPT ); Sun, 10 Sep 2006 03:52:51 -0400 Date: Sun, 10 Sep 2006 09:51:54 +0200 From: Heiko Carstens To: Roman Zippel Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Martin Schwidefsky Subject: Re: [patch 1/2] own header file for struct page. Message-ID: <20060910075154.GA8354@osiris.ibm.com> References: <20060908111716.GA6913@osiris.boeblingen.de.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: mutt-ng/devel-r804 (Linux) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org > > In order to get of all these problems caused by macros it seems to > > be a good idea to get rid of them and convert them to static inline > > functions. Because of header file include order it's necessary to have a > > seperate header file for the struct page definition. > > > > Cc: Martin Schwidefsky > > Signed-off-by: Heiko Carstens > > --- > > > > Patches are against git tree as of today. Better ideas welcome of course. > > > > include/linux/mm.h | 64 -------------------------------------------- > > include/linux/page.h | 74 +++++++++++++++++++++++++++++++++++++++++++++++++++ > > 2 files changed, 75 insertions(+), 63 deletions(-) > > To avoid the explosion in number of small header files each containing a > single definition, it would be better to generally split between the > definitions and implementations, so IMO mm_types.h with all the structures > and defines from mm.h would be better. That could be done, but I wouldn't know where to start and where to end. Moving simply all definitions to mm_types.h doesn't seem to be a good solution. E.g. having something like "struct shrinker" in mm_types.h seems to be rather pointless IMHO. Maybe we can simply leave it by just taking the struct page definition out for now?