From: Oleg Nesterov <oleg@tv-sign.ru>
To: Dipankar Sarma <dipankar@in.ibm.com>
Cc: "Paul E. McKenney" <paulmck@us.ibm.com>,
Srivatsa Vaddagiri <vatsa@in.ibm.com>,
Andrew Morton <akpm@osdl.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] force_quiescent_state: factor out duplicated code
Date: Mon, 11 Sep 2006 01:13:44 +0400 [thread overview]
Message-ID: <20060910211344.GA188@oleg> (raw)
In-Reply-To: <20060910210348.GE4690@in.ibm.com>
On 09/11, Dipankar Sarma wrote:
>
> On Sun, Sep 10, 2006 at 08:18:10PM +0400, Oleg Nesterov wrote:
> > On top of rcu-simplify-improve-batch-tuning.patch
> >
> > Cleanup. Move '#ifdef CONFIG_SMP' check and rdp->bhlimit setting
> > into force_quiescent_state().
>
>
> Pushing the rdp->blimit setting into force_quiescent_state is fine,
> but I see no need to insert #ifdef CONFIG_SMP into a routine.
Otherwise we need to push the rdp->blimit setting into both versions
of force_quiescent_state(), for CONFIG_SMP and !CONFIG_SMP.
> Let us continue to have separate versions of force_quiescent_state()
> for CONFIG_SMP and !CONFIG_SMP. It looks cleaner with #ifdefs inserted
> in between.
I personally think exactly opposite :)
Ok, let's forget about this patch, it was only cleanup.
Oleg.
prev parent reply other threads:[~2006-09-10 21:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-10 16:18 [PATCH] force_quiescent_state: factor out duplicated code Oleg Nesterov
2006-09-10 21:03 ` Dipankar Sarma
2006-09-10 21:13 ` Oleg Nesterov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060910211344.GA188@oleg \
--to=oleg@tv-sign.ru \
--cc=akpm@osdl.org \
--cc=dipankar@in.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=paulmck@us.ibm.com \
--cc=vatsa@in.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox