public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Dave Jones <davej@redhat.com>
To: Linux Kernel <linux-kernel@vger.kernel.org>
Cc: ak@suse.de
Subject: Split multi-line printk in oops output.
Date: Sun, 10 Sep 2006 23:07:21 -0400	[thread overview]
Message-ID: <20060911030721.GA4733@redhat.com> (raw)

Sometimes, bug reports come in where we've had an oops, and the
only record we have is what the reporter saw on screen shortly
before the system locked up completely.  Unfortunatly, syslog
only prints lines beginning with KERN_EMERG to the console, so
some lines get lost.
An example of this can be seen at https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=203723

Some of this information isn't vital to diagnosis, but some parts
are useful, such as the tainted flag.

Signed-off-by: Dave Jones <davej@redhat.com>

--- local-git/arch/i386/kernel/traps.c~	2006-09-10 23:01:18.000000000 -0400
+++ local-git/arch/i386/kernel/traps.c	2006-09-10 23:03:33.000000000 -0400
@@ -291,10 +291,11 @@ void show_registers(struct pt_regs *regs
 		ss = regs->xss & 0xffff;
 	}
 	print_modules();
-	printk(KERN_EMERG "CPU:    %d\nEIP:    %04x:[<%08lx>]    %s VLI\n"
-			"EFLAGS: %08lx   (%s %.*s) \n",
-		smp_processor_id(), 0xffff & regs->xcs, regs->eip,
-		print_tainted(), regs->eflags, system_utsname.release,
+	printk(KERN_EMERG "CPU:    %d\n", smp_processor_id());
+	printk(KERN_EMERG "EIP:    %04x:[<%08lx>]    %s VLI\n",
+		0xffff & regs->xcs, regs->eip, print_tainted());
+	printk(KERN_EMERG "EFLAGS: %08lx   (%s %.*s)\n",
+		regs->eflags, system_utsname.release,
 		(int)strcspn(system_utsname.version, " "),
 		system_utsname.version);
 	print_symbol(KERN_EMERG "EIP is at %s\n", regs->eip);

-- 
http://www.codemonkey.org.uk

             reply	other threads:[~2006-09-11  3:07 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-09-11  3:07 Dave Jones [this message]
2006-09-11  5:44 ` Split multi-line printk in oops output Andi Kleen
2006-09-11  6:07   ` Dave Jones
2006-09-11 20:24     ` Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060911030721.GA4733@redhat.com \
    --to=davej@redhat.com \
    --cc=ak@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox