Re: [RPC] OLPC tablet input driver.

Arjan van de Ven
2006-08-29T08:10:58Z

> +#undef DEBUG
> +#ifdef DEBUG
> +#define dbg(format, arg...) printk(KERN_INFO "olpc.c(%d): " format "\n", __LINE__, ## arg)
> +#else
> +#define dbg(format, arg...) do {} while (0)
> +#endif

why not use pr_debug or even dev_debug() ?
Those already have this ifdef included

> +
> +static struct olpc_model_info olpc_model_data[] = {
> + { { 0x67, 0x00, 0x0a }, 0xeb, 0xff, OLPC_PTGS }, /* OLPC in PT+GS mode. */
> +};

const?

also.. there's no locking visible anywhere in the driver... is this
right?

Greetings,
Arjan van de Ven