Re: [PATCH] - restore i8259A eoi status on resume

Andi Kleen
2006-09-12T13:36:34Z

On Tuesday 12 September 2006 14:47, Matthew Garrett wrote:
> On Tue, Sep 12, 2006 at 11:19:06AM +0200, Pavel Machek wrote:
> > Hi!
> >
> > > Got it. i8259A_resume calls init_8259A(0) unconditionally, even if
> > > auto_eoi has been set. Keep track of the current status and restore
> > > that on resume. This fixes it for AMD64 and i386.
> >
> > Patch looks okay to me...
>
> Cool. Andi, does it look sane to you? I'm not really sure who to wave
> 8259 code at...

Yes. I already have it queued for .19 at least. Not sure it's critical enough
for .18, especially since it doesn't seem to be a regression.

-Andi